CDR Tickets

I'm wondering if this is a problem that started happening but was working correctly before or if we're now starting to use revision markup in media documents.

Didn't we talk about this issue before or was it something closely related?
The reason why the marked-up text for Media captions is displayed is a result of the order in which our filters are applied. This is the order of our filters:

1. Insert all summary module links in our document

2. Resolve the insertion/deletion markup

3. Insert all Media documents

4. other filters

As you can see, when the media docs are included in the summary document the markup has already been resolved in the parent document (and the modules). Anny additional markup will be displayed as regular text.
I think the way to handle these changes is by not creating a version.

If this is a big enough issue we may consider changing the order in which our documents are filtered but this would be a big change and could potentially affect all summary reports. Another alternative to that approach could be to run the Revision Markup Filter a second time to resolve additional markup as the one included via the Media documents.

We have been using markup in media docs for a long time now.

Yes, I remember we talked about this in relationship with another topic. The part I don't understand is why the filters are picking up text from unpublishable versions of the media document. I would think that it would only attempt to pick up publishable versions of the document. Is there a way to make the filters pick up only publishable versions ?

I see! I thought the issue was the markup but your question is about picking up a different version.

We did - not too long ago - modify our filters to only select publishable versions for misc. documents. We could make that same change for media documents as well.

Sure. That will work. Thanks!

Will this be release dependent?

No, this would be a filter change which doesn't need to be included in a release.

Great. Thanks!

I have updated the title and the original post to reflect the fact that this affects all media docs and also, it is the captions that are affected and not the content descriptions. Sorry for the confusion.

The following filter has been updated on DEV:

• CDR410709 - Module: Multimedia Denormalization

The change has been versioned in a local branch: [cdr4335 fa6e147]

PP is not working very well on DEV so should I make changes so we can hot-fix to test?

I have updated the following docs for possible hot-fixing on DEV:

Media doc: CDR0000719086
Summary doc: CDR0000258038
Summary doc: CDR0000258029

This may be off topic but could you please explain what you mean with PP is not working very well on DEV?
Running a hot-fix has to go through the same processing as a publish preview report, so it's not going to be any faster and if there is a problem we need a ticket so we can fix it.

I have attached the blank page I got when I ran PP. That is all I see, no text on the page.

PP is not working very well on DEV

I think it's fair to say that PP is not working for summaries. This is something we need to know especially in light of being in the process of upgrading our database to SQL Server 2016. Please don't ignore these type of issues by trying to work around it.

Could you please add a new ticket for the PP problem?

The hot-fix to PINK completed.
https://www-pink-dev.cancer.gov/types/thyroid/patient/thyroid-treatment-pdq

Sorry, I did not notice that the initial push to Gatekeeper failed for the summaries. Those documents have been updated on PINK now.

I can't confirm that the changes have made it to pink yet. I entered "[Test]" after a paragraph in each of the summaries but I can't find it on PINK.

One reason why a PP report is better suited for testing than a hot-fix is that you won't have to deal with Percussion publishing issues. I had to manually run a Percussion publishing event. You should now see your changes.

It worked. Thanks! Please run the hot-fixes again for me.

Media doc: CDR0000719086
Summary doc: CDR0000258038
Summary doc: CDR0000258029

Since the PublishPreview report is working again on DEV please go ahead and test the results using the report.

I have verified the changes on DEV. Please proceed to apply the changes on QA.

~oseipokuw, the filter has been updated on QA.

I ran a diff report and found 4 documents with differences - all as part of the MediaLink caption:

• CDR256718.xml

• CDR258038.xml

• CDR584552.xml

• CDR62913.xml

Since QA had just been updated from PROD yesterday I'm assuming these are the same summaries currently displayed on PROD with problems.

Yes, I see at least one that I reported in my initial post.

The filter change has been updated on STAGE. Please verify before moving the change to PROD.

I can't get PP to run. I am getting

Error in PubPreview: HTTP error: 500 (Internal Server Error) (occurred at Wed Nov 15 15:26:33 2017)

I've been told that Percussion STAGE is currently being refreshed and won't be available until later tomorrow.
Since you checked the changes on DEV and QA already and this was a fairly minor change I've copied the filter to PROD.
Please verify and close this ticket if everything looks OK.

As discussed in the CDR meeting/conference call, tests on PROD show that the text in the caption is only showing the published version of the media documents, which is what we want. However, it appears
the images displaying in PP are revised images that have not been made publishable yet. The revised images are in versions of the media document that we expect to make publishable in the future.

Yes, this is correct. The PublishPreview report uses the program GetCdrImage.py for pulling the image out of the CDR in order to display it on the report. This program, however, does not take into account the version of the Media document. It always pulls the latest blob which relates to the current working document.

You may want to submit a ticket to have the version of the captions match the version of the image when running a PP report.

I have created OCECDR-4339 to take care of it.

PP in PROD is showing both the old Caption and the new Caption. The new Caption has been appended to the old Caption. It is the same on Cancer.gov.

https://www.cancer.gov/types/thyroid/patient/thyroid-treatment-pdq#section/_27

This appears to be the same problem we had with the scheduler, the filter change was overwritten by Fermi and needed to be re-applied. I've updated the modified filter on PROD again.

~oseipokuw, please check if this is resolving the issue we discussed at yesterday's status meeting.

The filter updated is:

• CDR410709 - Module: Multimedia Denormalization

https://github.com/NCIOCPL/cdr-server/pull/2/commits/fa6e147aa

The issue has been resolved. They are displaying correctly now. Thanks!