CDR Tickets

I've made a few initial modifications to the CSS:

• Summary.ctm

• CdrCommonSchema.css

• Summary.css

Additional changes are still necessary.

~bkline reminded me that the Media document itself still needs to be updated.

The following files have been updated to adjust the XMetaL display for the newly created element EmbeddedVideo and its child elements:

• R14626: Display\CdrCommonSchema.css

• R14626: Display\CdrCommonSchema_structure.css

• R14626: Display\DrugInformationSummary.css

• R14626: Display\GlossaryTermConcept_structure.css

• R14626: Display\Media.css

• R14626: Display\Media_Structure.css

• R14626: Display\Summary.css

• R14626: Display\Summary_structure.css

• R14626: Rules\DrugInformationSummary.ctm

• R14626: Rules\GlossaryTermConcept.ctm

• R14626: Rules\Summary.ctm

This is ready for review on DEV.

Please revise the instructional text in the VideoType field. There seems to be an extra "an" in the text.

Minor template rule changes (not related to the current set of changes):

• R14630: Media.ctm

The instructions in the color field says " Select the color for this image (required) ". Should it say "video" instead of "image" ?

Verified. Thanks!

I would think this should be a schema change. I can not imagine what the Color field for a video would be used for except maybe to indicate if the video is in black/white or color. In that case the entire text string is incorrect.
The element comes up because it's a mandatory child element for the ImageData and VideoData blocks but should - in my opinion - only be mandatory for ImageData.

Let's discuss at our meeting tomorrow.

I'm adding ~bkline as a watcher so that he can see the last comment regarding the Color element for videos.

Please make the default value for the "Color" element Color.

I've updated the template rules on DEV:

• R14638: Media.ctm

I can confirm that the "color" value is displayed by default. However, the VideoHosting and HostingID elements are not added to the Media template by default when (VideoData) selected from the element's list. Is this intentional?

the VideoHosting and HostingID elements are not added to the Media template by default

It hadn't been mentioned as an issue before. By default only mandatory child elements are included when inserting a wrapper element unless that's modified by the template rules.

Could you take a look and see if anything else needs changing so that I don't have to touch that file controlling the display multiple times for additional modifications?

The only other element that is not included in the default template is the DefaultVideoPresentationTemplate. I am not sure how that needs to be used so I am not sure if that needs to be included in the default template or not.

It's not required. You would use it to optionally specify the default rendering for the video (which could be overridden in turn by the EmbeddedVideo block in the linking document).

In that case, we can leave it out of the default template and let the user add it when appropriate.

Just to clarify: You'd like me to include the VideoHosting and the HostingID elements in the template but not the DefaultVideoPresentationTemplate element, right?

That is right.

The Media.ctm rules file has been updated and is ready for review on DEV:

• R14642: Media.ctm

Since "youtube" is the only option for Video Hosting, please make it the default selection. Apart from that, everything else looks great.

Do you mean it is not required for the Media Doc Schema or by the DTD? When I choose to exclude the template element from both the media document and the summary document, I get the following error message. So, I assume we have to enter the element for at least one of the document types.

CDRPreview web service error: Xml data validation error,The 'template' attribute has an invalid value according to its data type.Validation error occurred when validating the instance document.,142,7

The Content Description block in the media document is required and won't let you validate the media doc without it. However, it doesn't look like that content is used for anything video. Unless there is a plan to use the block for video/animation purposes, could you make the block a non-required block when we drop in the video data block?

youtube has been added as the default for the VideoHosting value:

• R14648: Media.ctm

Since the CSS changes are complete I'm reassigning the issue to ~bkline for the additionally requested schema changes.

First of all, this is the wrong ticket for schema changes. Second, we need to stop changing the requirements, or Einstein will never get out the door. Third, having a description (however brief) is a good thing. It was added to the schema for accessibility requirements, and the fact that we don't have a place to publish the information for video doesn't mean that we'll never be required to use it for 508 compliance. The description is separate from the blocks for the specific media, so making it optional would remove the safety measure you have which prevents you from ending up with unpublishable image documents. This is one of the prices paid for the decision to use the existing Media document type instead of creating a separate document type for the video.

Setting status to Resolved and Fixed for the CSS.

Verified. Thanks!

Verified on DEV. Thanks!

Could you please clarify the following? I asked a similar question above but didn't get an answer. When no value is selected for the DefaultVideoPresentationTemplate in the media doc, and no value is selected for the SpecificVideoPresentationTemplate in the summary, a python script error is displayed when trying to get PP for the summary. However, it appears that in both doc types, the elements are optional. Is there a requirement in the DTD for this value?

Yes, the DTD requires a display template to exist.

(Shouldn't questions about the DTD be in OCECDR-3558?)

I'm looking at the DTD in version control, and it looks to me like it's optional. If you're going to change that, Volker (that is, the downstream consumers of the documents won't have a default for the layout as I thought they would), please have the export filter insert a reasonable default. Thanks.

~oseipokuw, could you please let me know what default value you'd like me to use?

~bkline, I won't be able to change this until tomorrow since I have to leave work now.

Are we sure there's not a default already in place for the videos currently displayed on the web site? If there is, let's give some consideration to being consistent with the rest of the site.

I've added the display template Video75NoTitle as a default presentation template if none has been specified.

• R14651: CDR271370.xml (Module: Vendor Filter Templates)

Who's the best person to check with to see if there's already a default for video layout on the web site?

Why are you asking? Would you like to ask Michelle again? :-)

It thought perhaps there might be some interest in consistency with the rest of the web site, but if I'm the only one who was thinking along those lines, I'm happy to go with the dartboard method. :-)

It sounds like you're thinking I came up with the choice I implemented without consulting anybody. I did ask Victoria and Michelle which template I should be using as a default and their answer was to use Video75NoTitle.
Am I missing any additional steps I should be taking?

Verified on DEV. Thanks!

Nope. Thanks for following up.

Hi Volker, could you please add some CSS for the new ExternalRef element in the media document schema? (See OCECDR-3558). Thanks!

Should this element be included in the Media template? Should it always be displayed or only when added manually?
Is the label ExternalRef OK or would you prefer something shorter? URL, Ext. URL, XRef, ...?

No, it should only be added manually. We expect that we'll only be using this for animations for the time being anyway. The label "ExternalRef" is fine - we're used to that label from summaries anyway. thanks.

The following style files have been updated on DEV and QA:

• R14663: Display\Media.css

• R14663: Display\Media_Structure.css

• R14663: Rules\Media.ctm

Verified on QA.

~bkline, please keep in mind that the latest build you had installed with the updated CDRLoader did not include the additional CSS changes for this ticket.

As long as they're checked into SVN they'll be picked for the deployment to stage.