| Issue Number | 4221 |
|---|---|
| Summary | Filter Changes to Handle HTTPS |
| Created | 2017-01-20 15:28:42 |
| Issue Type | Improvement |
| Submitted By | Englisch, Volker (NIH/NCI) [C] |
| Assigned To | Englisch, Volker (NIH/NCI) [C] |
| Status | Closed |
| Resolved | 2018-07-17 17:58:53 |
| Resolution | Fixed |
| Path | /home/bkline/backups/jira/ocecdr/issue.201721 |
I was looking at the http/https conversion we talked about at the meeting yesterday. While I was updating the filters for the DrugRef element I’ve noticed that we didn’t pay close attention to the proper format of the URLs within our documents. We’re using this template getSummaryURL() to clean up URLs by removing a trailing slash and rewriting the hostname from ‘www.cancer.gov’ to ‘cancer.gov’. All other URLs within ExternalRefs, however, are using the format of ‘www.cancer.gov’.
In addition, that template is expecting the string http://www.cancer.gov as part of the summary URL. This will break if we’re starting to use https within URLs.
I'd like to modify our filters where necessary to specify "www.cancer.gov" as the hostname within URLs and use the https "protocol" exclusively for Cancer.gov URLs.
Please note, this change will require all summaries to be reprocessed when the changes are put in place due to the existence of the SummaryURL element in each summary.
I propose to include this ticket as part of Einstein-IT2
Adding a couple watchers to this ticket.
The following filters have been identified to need changes in order
to modify urls starting with _http://_ to _https://_:
CDR0000000105.xml - Needs minor work ✔
CDR0000000134.xml - Needs minor work ✔
CDR0000000150.xml - Filter deleted ✔
CDR0000000157.xml - Needs work ✔
CDR0000315588.xml - Needs minor work ✔
CDR0000315755.xml - Needs minor work ✔
CDR0000343579.xml - Filter deleted ✔
CDR0000385703.xml - Filter deleted ✔
CDR0000502087.xml - Filter deleted ✔
CDR0000505580.xml - Needs minor work ✔
CDR0000685090.xml - Filter deleted ✔
The following filters have been moved to my local git repository cdr-server[cdr4221 c2bf0d43]:
CDR0000000105.xml (cdr4221)
CDR0000000134.xml (cdr4221)
The relevant filters have been updated. Other filters have been removed from the list when the xref did not necessarily point to Cancer.gov.
I'm going to wait for Ising to be deployed to production and will move these filter changes to production after the master branch has been merged.
We're going to coordinate pushing this to PROD in the middle of next week, coordinated so that the bulk republishing of Summary documents happens at the same time as the republishing for the OCECDR-4511 global change happens.
~bkline will make sure the code changes for OCECDR-4511 are merged into trunk so Volker can create a branch for this ticket.
~volker: I'll need you to approve the PRs for OCECDR-4512 and merge before I can create PRs for OCECDR-4511.
I just realized one of the PRs I thought I had submitted didn't go
through (turns out that if you just selected a reviewer you have to
click twice on the button to click the PR - once to give it the focus
and a second time to actually do what you thought you were doing with
the first click) and the page disappeared when I did some browser tab
cleanup. It's been created now, waiting for review/approval/merge. I
also submitted the OCECDR-4511 PR for the cdr-server
repository, so there's one more PR for me to create (as soon as you
approve my cdr-publishing PR.
YIKES! I just noticed that you've got a pull request
for the cdr-publishing repository that you created and
assigned to yourself a week ago, ~volker (presumably thinking you were assigning
it to me). I'm so confused! 🙁
Are we talking about pull request #10? That's assigned to myself as I always do but the reviewer is set to you.
Yes, I see that now. Wonder how I missed the review request. :-(
The filter changes have been merged into master and the feature branch cdr4221 has been deleted.
Closing ticket.
| File Name | Posted | User |
|---|---|---|
| github pull request.png | 2018-11-02 17:10:43 | Englisch, Volker (NIH/NCI) [C] |
Elapsed: 0:00:00.000917