| Issue Number | 4217 |
|---|---|
| Summary | [Summaries] Type of Change Report - Changes to Interface |
| Created | 2017-01-17 14:43:38 |
| Issue Type | Improvement |
| Submitted By | Juthe, Robin (NIH/NCI) [E] |
| Assigned To | Kline, Bob (NIH/NCI) [C] |
| Status | Closed |
| Resolved | 2017-01-31 23:22:15 |
| Resolution | Fixed |
| Path | /home/bkline/backups/jira/ocecdr/issue.201526 |
The interface for the Type of Change report is confusing. It isn't clear that the Format, Audience, For Specific Summaries, and For Multiple Summaries options are applicable to both versions of the report - i.e., the most recent Type of Change and the Type of Change History.
I'll post my suggestions for reformatting this page.
I have created a mockup of a new form. I'll plug in the code to generate the report after we've worked in any tweaks the form needs. Please take a look.
https://cdr-dev.cancer.gov/cgi-bin/cdr/stcr.py?Session=guest
The stcr.py script now generates the reports. I left it under the temporary name to make it easier for you to compare results between the old and new versions of the code.
In the historical report, please flip the order of the changes so that the most recent change is at the top for each summary.
As a reminder, please also fix the column names.
Robin is reviewing this on DEV.
Both changes made on DEV.
Bob, could you please hide the date fields when the "current" version of the report is selected on the default report interface? Thanks.
Done.
I'm seeing some discrepancies beyond what I'm expecting to see between the two reports.
For instance, when I run the "current (most recent change)" version of the new report and the "basic" version of the old report, I'm seeing changes from 2013 on the new report when the old report is displaying more recent changes from 2015 for the same categories.
Here's a concrete example:
1. Run the "current" or "basic" report (both old and new versions)
for all genetics summaries, all change types and including
comments.
2. For the Genetics of Breast/Gyn Cancers summary, the new report shows
the most recent comprehensive revision change as being from 2014-12-03,
while the old report shows the most recent change (which happens to be a
comprehensive revision) dated 2015-11-11. I would expect the new report
to show me the change from 2015 in the comprehensive revision
column.
3. For the Genetics of Colorectal Cancer summary, a similar thing is
happening in the Major Change column - the new report shows a change
from 2013 while the old report displays a change from 2015.
4. The same is true for the Endocrine, Kidney, Prostate, and Skin
summaries in either the Comprehensive revision or Major change
columns.
Ah! I see what happened. When we reversed the order in which the changes are stored for the change request received on the 26th, that flipped the logic for the other flavor of the report. Try it again please.
This looks good although do you still have the link to the old report for comparison purposes?
I added a link back to the old version on the Board Manager menus (but not the general summary reports menu) on DEV.
Thanks, but unfortunately the old report isn't working. I'm getting a "CGI parameter tampering detected" error. If it isn't easy to fix, don't worry about it and I can just proceed with testing the new report.
Sorry about that. Give it another shot.
All better, thanks!
The "historical" version of the new report is ignoring the selected change types. It should display all changes of the selected type(s) for the selected date range. Thanks.
Evidently I thought that's how the historical report should work, given the wording on the user interface. I've changed the behavior, and when you've confirmed that it's working the way you want, I'll change the wording on the report request form too.
Hi ~bkline, this looks good to me. I'm considering it verified on DEV. You can remove the link to the old version of the report. Thank you!
The formatting of this report interface is a little wacky on QA.
Could you elaborate on "wacky"? I'm not seeing wacky. :-) Maybe you need to refresh your browser's cache?
Can we no longer add a screenshot in JIRA? I will send you one. Maybe it's just me - I will try updating my cache.
We confirmed this problem was only on my computer.
Verified on QA.
Bob, the "old" Type of Change report is still on Stage. Should it be?
JIRA's broken again, unable to show previous comments, so I can't just "reply" to your question about the link to the old interface, Robin. Looks like we missed that on QA. It'll be fixed on PROD.
Elapsed: 0:00:00.001362