Issue Number | 3919 |
---|---|
Summary | PublishPreview Option for DIS |
Created | 2015-06-03 12:03:41 |
Issue Type | Bug |
Submitted By | Englisch, Volker (NIH/NCI) [C] |
Assigned To | Learn, Blair (NIH/NCI) [C] |
Status | Closed |
Resolved | 2016-03-28 11:43:47 |
Resolution | Fixed |
Path | /home/bkline/backups/jira/ocecdr/issue.162456 |
The option to run the PublishPreview report from the Admin interface for Drug Info Summaries is running the QC report instead of the PP report.
Is this a change in behaviour from back in 2007, when you added the menu item to run the DIS Publish Preview using the QcReport.py script?
C:\Users\bkline\sandboxes\Ampere\Inetpub\wwwroot\cgi-bin\cdr>svn diff -c 7341 DrugInfoReports.py
Index: DrugInfoReports.py===================================================================
--- DrugInfoReports.py (revision 7340)
+++ DrugInfoReports.py (revision 7341)
@@ -1,8 +1,11 @@
#----------------------------------------------------------------------
#-# $Id: DrugInfoReports.py,v 1.1 2006-05-16 20:45:24 venglisc Exp $
+# $Id: DrugInfoReports.py,v 1.2 2007-04-27 22:51:54 venglisc Exp $
#
# $Log: not supported by cvs2svn $+# Revision 1.1 2006/05/16 20:45:24 venglisc
+# Initila copy of DrugInfoSummary reports menu (Bug 2053).
+#
# Inintial version of Drug Information Reports Menu page of the
# Admin interface. (Bug 2053)
#@@ -44,7 +47,9 @@
<OL>
""" % (cdrcgi.SESSION, session)
reports = [('QcReport.py?DocType=DrugInformationSummary',- 'Drug Information QC Report')]
+ 'Drug Information QC Report'),
+ ('QcReport.py?DocType=DrugInformationSummary&ReportType=pp&',
+ 'Publish Preview')]
for r in reports: form += "<LI><A HREF='%s/%s&%s=%s'>%s</LI></A>\n" % (
Or has it always behaved this way?
Is this a change in behaviour from back in 2007
I'm not able to answer your question. It's possible this option never worked correctly even though I would hope testing would have caught it. I may be the only person using this option and I remember having noticed this problem before but I did not submit a ticket. That's at least 6-12 months ago, maybe longer.
Now I'm putting it in the backlog.
As discussed in today's stand-up meeting I'm assigning this ticket to ~LearnB.
it looks like the error is in the logic for allowing the user to choose a document version. This leads to two requirements questions.
If the user is allowed to choose the document version, and the document type is anything other than DrugInformationSummary, then the "Choose a version" form includes a hidden field containing the report type. For DrugInformationSummary the ReportType is left out.
Since the next form submission has no value for the report type, the page defaults to a QC report instead of redirecting to Publish Preview.
The aforementioned requirements questions then are:
Should this report allow the user to choose a document version? (This is different behavior from the publish preview in XMetal.)
Assuming the choice of document version is supposed to be there (the way it's coded vs. Summary and GlossaryTerm implies that it's intentional), is there a reason why the report type shouldn't be included?
The description for OCECDR-2615 references a functional requirement that Publish Preview for DrugInformationSummary documents give the user the ability to specify a document version.
The conditional omission of the report type however appears to be an error.
Updated QcReport.py to maintain the ReportType value when displaying the Document Version selection page.
This is still calling up the QC report rather than Publish Preview.
To answer your earlier question (sorry), it should not allow us to select a document version. It should be running off the current working doc.
I had successfully tested this change earlier in the week on DEV, so I'm guessing that Blair's change was likely overwritten. He may just need to version the changes in SVN.
Nope. I committed my change on March 22nd. (Inetpub/wwwroot/cgi-bin/cdr/QcReport.py, revision13799).
~JutheR I'm confused. This works for me. Were you on Dev or somewhere else?
I'll take out the choice of document versions on Monday.
Removed the ability to choose document versions for DrugInfoSummary.
It works! Sorry- I must have inadvertently been on PROD or something. Too many windows open.
Thanks. Verified on DEV.
whew! I was worried I might have been losing my mind.
Verified on QA.
Verified on PROD.
Please let me know if it is okay to close this issue.
Yes, it's OK to close the ticket.
I'll do that now.
Elapsed: 0:00:00.001219