CDR Tickets

Issue Number 3921
Summary Add "CitationLink" text to Citation Link element
Created 2015-06-05 12:07:51
Issue Type Bug
Submitted By Juthe, Robin (NIH/NCI) [E]
Assigned To Englisch, Volker (NIH/NCI) [C]
Status Closed
Resolved 2015-06-05 14:11:07
Resolution Fixed
Path /home/bkline/backups/jira/ocecdr/issue.162703
Description

Please add the default prompt "CitationLink" to the CitationLink element. Thank you.

Comment entered 2015-06-05 13:15:13 by Englisch, Volker (NIH/NCI) [C]

This is for the summary templates, right?

Comment entered 2015-06-05 13:17:49 by Juthe, Robin (NIH/NCI) [E]

It's not actually in the template if you were to open a new summary document...but when you add a new citation element to a summary document, it should have this text already inside the element. I think some users search for that text to find citations that need to be added to the summary.

Comment entered 2015-06-05 13:25:11 by Englisch, Volker (NIH/NCI) [C]

You do already have the label

[Citation]

within the CitationLink, so you want to see

[Citation] {CitationLink}
Comment entered 2015-06-05 13:35:30 by Juthe, Robin (NIH/NCI) [E]

Yes, that's right. In order to search on that text it needs to be outside of the label.

Comment entered 2015-06-05 14:10:14 by Englisch, Volker (NIH/NCI) [C]

The following rules files have been modified:

  • Summary.ctm

  • PatientSummary.ctm

Please note that the original (4.0) templates displayed the prompt as

{CitationLink}

while we are displaying the prompt as

{ CitationLink }

I hope that's OK. I would like to keep it this way because it makes formatting the CSS files much cleaner.

I also gave you - as a special bonus - a slightly blueish colored CitationLink tag.

This is ready for review on DEV.

Comment entered 2015-06-10 13:35:41 by Juthe, Robin (NIH/NCI) [E]

This is strange, but when I add the CitationLink element without insertion tags, the "{ CitationLink }" text appears, but when I add it inside a set of insertion tags (as we typically are doing), it says "Insert text here" instead.

Comment entered 2015-06-11 15:30:39 by Englisch, Volker (NIH/NCI) [C]

The template seems to be doing the right thing even though it's not necessarily expected.
The text CitationLink is only inserted as a user prompt if there is no other text to be used. Let's say we have a paragraph with the text Eine Gurke is eine saftig, gruene Frucht. and we highlight Gurke and insert a CitationLink. The prompt will not be displayed and the text Gurke is listed as the text within the element tags. However, if you create a new Para element you will see the prompt for the Para being highlighted. If you then insert a CitationLink element again, the prompt for the CitationLink will be Para.
This is the exact same thing you're experiencing. Insert text here is the prompt for the Insertion element. In order to not see this text when creating the CitationLink - or any other element prompt - you'll have to remove the highlighting first and then insert the element.

Please let me know if this doesn't make sense and I'll be happy to demonstrate this.

Comment entered 2015-06-11 17:00:00 by Juthe, Robin (NIH/NCI) [E]

Thank you for demonstrating! Verified on DEV.

Comment entered 2015-06-11 17:04:00 by Englisch, Volker (NIH/NCI) [C]

I probably confused you with the Gurke. :-) (It's German for cucumber)

Comment entered 2015-06-18 14:01:59 by Englisch, Volker (NIH/NCI) [C]

The following rules files have been copied to subversion:

  • R13214: PatientSummary.ctm

  • R13214: Summary.ctm

Note:
Please double-check on DEV that the Insertion/Deletion default RevisionLevel is correct.
Due to the problems with versioning our changes in svn I'm not exactly sure if I may have overwritten earlier changes in the Summary.ctm.

Comment entered 2015-06-24 18:58:24 by Juthe, Robin (NIH/NCI) [E]

I just saw you latest comment about double-checking the default revision level. It is correct on QA. Do I still need to check DEV, too?

Comment entered 2015-06-24 22:22:46 by Englisch, Volker (NIH/NCI) [C]

No need, if it's correct on QA it's correct on DEV. Besides, DEV is currently unavailable so you'll have to take my word for it. :-)

Comment entered 2015-06-24 22:32:42 by Juthe, Robin (NIH/NCI) [E]

OK, great. Verified on QA, then. Thanks!

Comment entered 2015-09-01 13:17:09 by Englisch, Volker (NIH/NCI) [C]

This has been promoted to PROD.
Please verify and close the ticket.

Comment entered 2015-09-01 13:19:50 by Juthe, Robin (NIH/NCI) [E]

Verified on PROD. Closing issue.

Elapsed: 0:00:00.001207