Issue Number | 3755 |
---|---|
Summary | Prevent SendEmail.py from Failing |
Created | 2014-04-15 14:55:40 |
Issue Type | Improvement |
Submitted By | Englisch, Volker (NIH/NCI) [C] |
Assigned To | Englisch, Volker (NIH/NCI) [C] |
Status | Closed |
Resolved | 2014-11-18 23:38:57 |
Resolution | Fixed |
Path | /home/bkline/backups/jira/ocecdr/issue.123227 |
Our program to send emails to the licensees has a success rate of slightly above 50%. The program connects to the NIH mail server in order to send the messages and it does happen occasionally that one of those emails fails to connect causing the program to fail.
I'm going to modify the program to retry sending a message a few times before giving up and failing the program.
I was confused about this issue at our meeting today because I thought the SendEmail problems had already been taken care of and moved to production. However, I was thinking about OCECDR-3712. That issue had been modified so that the licensee data file wouldn't get corrupted when the program fails.
This issue is supposed to re-try sending an email after waiting for a little while instead of failing right away.
I've made the changes for this in my Ampere sandbox in:
/home/alan/src/branches/Ampere/Production/prod/bin/SendEmail.py
I have not tested. The code changes are very simple but I'd like you to look at it and walk through a test plan with me before I try to run it.
I've modified and tested the code using the test procedures Volker has set up.
It seemed to work fine with a normal test. Then I forced sendMail to raise an exception by passing it invalid parameters. The expected 5 tries were performed with logging and waiting between. I'll mark it resolved fixed.
The code is checked in to branches/Ampere.
Do you think it would make sense to attach your notes on how to
connect, etc. to this ticket? I know, it should be in the documentation
but it's hard to keep all of the documentation current all the
time.
Or you could add a ticket with your notes for me and I'll incorporate
the information into the documentation.
I would need to edit them, removing the irrelevant stuff and cleaning up the relevant stuff but, yes, I think it would be a good idea to add them.
I'll clean up the notes and send them to you so you make any changes needed. Then one of us can post them to the issue.
This is still waiting to be deployed.
These are my notes on what I learned, and what I planned to do and did. I don't know if any of them are relevant to your documentation, so I just included all of them.
They originated as an emacs outline file from which I replaced the asterisks that emacs uses to signify heading depth with spaces.
The notes may reveal more about my note making peculiarities than about the FTP email problem but, for whatever they're worth, here they are.
Re-assigning this issue back to Volker, as requested at today's status meeting.
The code has been copied to the Linux server but we have no way of
testing the results directly and a failure that this change is handling
may not occur in months.
Closing issue.
File Name | Posted | User |
---|---|---|
ftpemail.txt | 2015-03-26 16:36:14 |
Elapsed: 0:00:00.001384