| Issue Number | 3649 |
|---|---|
| Summary | [Summaries] PDQ Board Invitation History Report - Problem with exclude current members options |
| Created | 2013-08-21 14:32:15 |
| Issue Type | Bug |
| Submitted By | Juthe, Robin (NIH/NCI) [E] |
| Assigned To | Englisch, Volker (NIH/NCI) [C] |
| Status | Closed |
| Resolved | 2013-09-12 19:08:29 |
| Resolution | Fixed |
| Path | /home/bkline/backups/jira/ocecdr/issue.112248 |
The PDQ Board Invitation History Report has options to exclude current Editorial Board members and/or exclude current Advisory Board members from the report output. These options are working some of the time and not working some of the time. I think the problem is coming in when someone is a former member of one Board and a current member of another Board.
For example, Karen Lu recently left the Genetics EDITORIAL Board and joined the Genetics ADVISORY Board. If I run a report to see everyone who has been invited to the Editorial Board and I exclude both current Editorial Board members AND current Advisory Board members, then Karen should not display. But she does. Mark Robson is another example of a Board member who appears on this report despite being a current Advisory Board member (and former Ed Board member).
I see that the code assumes that a board member is only in one board,
either the editorial or the advisory board.
Is that correct or could a member be active on both boards?
Yes and no. To explain...a Board member cannot be an active member of the Editorial and Advisory Genetic Boards simultaneously, but they can be a member of the Genetics Editorial Board and the Screening and Prevention Advisory Board.
Oh boy, did you have to make it complicated? :-)
With this additional wrinkle I have an additional question:
What exactly should the checkbox for 'Exclude current Ed board members'
mean?
Lets say we have a member X who is active Genetics Adv. member,
inactive Genetics Ed board member, and active treatment board member and
we're running a report listing advisory board members.
Do we exclude this member X because he/she is active on
any editorial board or do we list the member because
he/she is not an active Genetics editorial board
member?
I think I am done with this issue. Could you please have a look on DEV (remember it has pretty old data) or give me a few of the special cases? I would like to do a little more testing but it's taking me some time to find the specific persons that would be affected by the changes and I'm guessing you already know the persons to look at.
If it would help I could move the report to QA (with has much more recent data).
Ready for review on DEV.
The option to Exclude Current Adv Board members seems to be excluding current Editorial and Advisory Board members.
For example,
I ran the report for the Genetics Editorial Board with neither "exclude"
option selected. I saw some of my current Editorial Board members on the
report (as expected). Example: Ilana Cass. I also saw some current Adv
Board members (as expected). Example: Kathleen Blazer
I then ran the report for the Genetics Editorial Board with only the "exclude current Adv Board members" option selected. I no longer saw current Adv Board members (such as Kathleen Blazer) but I also no longer saw current Editorial Board members (such as Ilana Cass).
It was meant as a feature so that you don't get overwhelmed with too many board members. :-)
Could you please take another look. Ilana Cass is listed again even with 'exclude advisory board' selected. I believe the other three options where already working properly.
Robin, I tested this using the Adult Treatment Board, and I think it is working properly. If you have time, could you give it one more try so we can move this ahead? Thanks.
I ran this for the Genetics Ed and Adv Boards and it looked good. Marking this QA verified.
I've saved the changes to the report in subversion:
R12095: BoardInvitationHistory.py
Verified on QA.
Verified in production.
Elapsed: 0:00:00.001681