CDR Tickets

Issue Number 3645
Summary [Summaries] Changes section in summary modules
Created 2013-08-16 09:01:18
Issue Type Improvement
Submitted By Juthe, Robin (NIH/NCI) [E]
Assigned To Englisch, Volker (NIH/NCI) [C]
Status Closed
Resolved 2013-11-12 15:12:21
Resolution Fixed
Path /home/bkline/backups/jira/ocecdr/issue.112017
Description

We would like to be able to add a "Changes To This Summary" section to summary modules and have it display when the module is published as a stand-alone summary but have it be suppressed when the module is included in another summary document. This may be done in the vendor filter, as we discussed in yesterday's status meeting, so I am giving it that component for now.

Comment entered 2013-08-20 13:52:47 by chengep

Assigned 13 story points at the planning meeting. Requires filter change to recognize how a module is being used and include or exclude content. Requires analysis to determine how tables and table numbering and other references will be affected.

Comment entered 2013-09-13 16:05:22 by Englisch, Volker (NIH/NCI) [C]

If a module is included in another summary are we asking to have both Changes sections combined or would we only display the Changes section of the parent summary?

Comment entered 2013-09-16 13:50:26 by Juthe, Robin (NIH/NCI) [E]

We should just display the changes section of the parent summary in that case. The filter doesn't need to combine the changes sections. Thanks.

Comment entered 2013-09-16 14:27:01 by Englisch, Volker (NIH/NCI) [C]

I've modified the filter 'Denormalization Filter: Summary Module' (CDR712005) to include all SummarySections except for those with a SectionType='Changes to summary'.

This is ready for review on DEV.

(I've added a Changes to this Summary Section to the Peutz-Jahger summary module.

Comment entered 2013-09-16 14:36:07 by Englisch, Volker (NIH/NCI) [C]

Changes ready for review on DEV.

Comment entered 2013-09-26 15:43:26 by Juthe, Robin (NIH/NCI) [E]

Verified in DEV. This works as expected. Thank you!

Comment entered 2013-09-27 12:38:46 by Englisch, Volker (NIH/NCI) [C]

The filter has been versioned in SVN:

  • R12048: CDR712005.xml (Denormalization Filter: Summary Module)

Comment entered 2013-09-27 13:34:57 by Englisch, Volker (NIH/NCI) [C]

The filter needs to be installed using the following command (typed on one line):

 $ updateFilter.py <username> <password> CDR0000712005.xml 
                   --docid=712005 --version=Y  
                   --publishable=Y 
                   --comment="R12048 (OCECDR-3645): Remove changes section from module"
Comment entered 2013-11-07 13:07:37 by Juthe, Robin (NIH/NCI) [E]

This is not working correctly on QA. The changes section was added in the middle of the parent summary document when I added the Peutz-Jeghers module to CDR517309.

Comment entered 2013-11-07 20:22:05 by Englisch, Volker (NIH/NCI) [C]

Sorry, but it's getting too late to finish this. I haven't found the reason for the problem yet but I will look at it first thing Monday morning.
At the moment it is a puzzle why the Peutz-Jaeger module isn't displaying properly for the QC report but for the vendor output.

Comment entered 2013-11-12 15:10:45 by Englisch, Volker (NIH/NCI) [C]

This is not working correctly on QA.

I looked at (almost) everything and couldn't find a problem. Bob helped me to take another look and we identified that the Changes section in the PJ summary module wasn't created as a top level SummarySection. I'm guessing that the Changes section should always be a top level section and this placement was a mistake. Once I moved the section the filter correctly stripped out the Changes section of the module on QA.

Comment entered 2013-11-12 15:12:21 by Englisch, Volker (NIH/NCI) [C]

No changes needed. The included module document had the Changes section misplaced.

Comment entered 2013-11-22 16:51:46 by Englisch, Volker (NIH/NCI) [C]

Since this is on PROD now I'm setting the status to 'QA Verified'.

Comment entered 2014-02-20 15:19:21 by Juthe, Robin (NIH/NCI) [E]

We decided to go ahead and close this even though we haven't had an opportunity to test it on production. We'll reopen this if we have any issues in the future.

Elapsed: 0:00:00.001673