CDR Tickets

Issue Number 3401
Summary [Summaries] Summ. with Markup Report - Add option to show all summaries
Created 2011-08-11 09:19:02
Issue Type Improvement
Submitted By Juthe, Robin (NIH/NCI) [E]
Assigned To Englisch, Volker (NIH/NCI) [C]
Status Closed
Resolved 2011-10-03 14:14:41
Resolution Fixed
Path /home/bkline/backups/jira/ocecdr/issue.107729
Description

BZISSUE::5094
BZDATETIME::2011-08-11 09:19:02
BZCREATOR::Robin Juthe
BZASSIGNEE::Volker Englisch
BZQACONTACT::William Osei-Poku

The summaries with markup report currently displays a table including all summaries of a given type that currently have markup (whichever type(s) of markup are chosen).

We would like to add the option to display ALL summaries of a given type in the report output - regardless of whether they contain revision-level markup. Summaries without markup would appear in the table but the cells indicating the number of changes would be blank.

We would like to keep the default as is (only showing summaries with markup).

Comment entered 2011-08-11 14:28:21 by Juthe, Robin (NIH/NCI) [E]

BZDATETIME::2011-08-11 14:28:21
BZCOMMENTOR::Robin Juthe
BZCOMMENT::1

As discussed in today's meeting, please also rename this report to "Summary Markup Report" since not all summaries included in the output are required to have markup within them.

Comment entered 2011-08-18 16:23:59 by Englisch, Volker (NIH/NCI) [C]

BZDATETIME::2011-08-18 16:23:59
BZCOMMENTOR::Volker Englisch
BZCOMMENT::2

The new option to display empty rows as well has been added to the options page.
The program updated is
SummariesWithMarkup.py

This is ready for review on MAHLER.

Comment entered 2011-08-23 08:58:39 by Juthe, Robin (NIH/NCI) [E]

BZDATETIME::2011-08-23 08:58:39
BZCOMMENTOR::Robin Juthe
BZCOMMENT::3

(In reply to comment #2)
> The new option to display empty rows as well has been added to the options
> page.
> The program updated is
> SummariesWithMarkup.py
> This is ready for review on MAHLER.

I tried running this on Mahler but got an error when I selected the report from the list:

"Please select a summary type!"

Comment entered 2011-08-23 09:31:32 by Englisch, Volker (NIH/NCI) [C]

BZDATETIME::2011-08-23 09:31:32
BZCOMMENTOR::Volker Englisch
BZCOMMENT::4

That's more of a warning than an error. In fact, I noticed that you did receive an error if you don't select any summary type, so I made the change to tell you when you tried to run the report without selecting what summary type(s) to run the report for.
You need to check at least one check-box for the types to run the report.

Comment entered 2011-08-23 11:05:46 by Juthe, Robin (NIH/NCI) [E]

BZDATETIME::2011-08-23 11:05:46
BZCOMMENTOR::Robin Juthe
BZCOMMENT::5

(In reply to comment #4)

> You need to check at least one check-box for the types to run the report.

I'm not seeing a report interface though, so I don't have the option to select a type. I see this message as soon as I click "Summaries with markup report" from the Board manager management reports menu.

Comment entered 2011-08-23 12:08:15 by Englisch, Volker (NIH/NCI) [C]

BZDATETIME::2011-08-23 12:08:15
BZCOMMENTOR::Volker Englisch
BZCOMMENT::6

Oh, now I understand. I'll fix that tomorrow.

Comment entered 2011-08-24 11:14:50 by Englisch, Volker (NIH/NCI) [C]

BZDATETIME::2011-08-24 11:14:50
BZCOMMENTOR::Volker Englisch
BZCOMMENT::7

Please try again. This has been fixed now on MAHLER.

Comment entered 2011-08-25 12:06:13 by Juthe, Robin (NIH/NCI) [E]

BZDATETIME::2011-08-25 12:06:13
BZCOMMENTOR::Robin Juthe
BZCOMMENT::8

(In reply to comment #7)
> Please try again. This has been fixed now on MAHLER.

Verified on Mahler. The name of the report in the report menu still needs to be changed though (to "Summaries Markup Report") - removing the word "with".

Then this can be promoted to Bach.

Thanks!

Comment entered 2011-08-25 16:44:36 by Englisch, Volker (NIH/NCI) [C]

BZDATETIME::2011-08-25 16:44:36
BZCOMMENTOR::Volker Englisch
BZCOMMENT::9

I have made the changes to remove the "with" from the menu page. However, the option for OCECDR-3368 (Invitation History Report) is already included.
Would you like me to copy the changes to BACH anyway (knowing that the history report is not yet available) or wait to copy the menu page and list the slightly wrong title for now?

The following file has been copied to FRANCK and BACH:
SummariesWithMarkup.py - R10183

The changes for
BoardManagers.py
have not yet been copied.

Comment entered 2011-09-01 12:07:33 by Juthe, Robin (NIH/NCI) [E]

BZDATETIME::2011-09-01 12:07:33
BZCOMMENTOR::Robin Juthe
BZCOMMENT::10

(In reply to comment #9)
> I have made the changes to remove the "with" from the menu page. However, the
> option for OCECDR-3368 (Invitation History Report) is already included.
> Would you like me to copy the changes to BACH anyway (knowing that the history
> report is not yet available) or wait to copy the menu page and list the
> slightly wrong title for now?
> The following file has been copied to FRANCK and BACH:
> SummariesWithMarkup.py - R10183
> The changes for
> BoardManagers.py
> have not yet been copied.

Verified on Bach. Thank you!

Let's keep the slightly wrong title for right now and promote the revised title when we promote the Invitation history report. So, I'll keep this issue open in the meantime.

Comment entered 2011-09-01 16:37:49 by Juthe, Robin (NIH/NCI) [E]

BZDATETIME::2011-09-01 16:37:49
BZCOMMENTOR::Robin Juthe
BZCOMMENT::11

I have one more tweak to this upon further review...

Could the option to display all summaries read "Include summaries without markup" rather than "Include rows without markup"? I think that will be a little clearer.

Thanks.

Comment entered 2011-09-01 18:04:39 by Englisch, Volker (NIH/NCI) [C]

BZDATETIME::2011-09-01 18:04:39
BZCOMMENTOR::Volker Englisch
BZCOMMENT::12

I've made the string change for
SummariesWithMarkup.py - R10189

Since this was a very minor change I've already copied the changes to MAHLER, FRANCK and BACH.

Please verify on BACH and close this bug.

Comment entered 2011-09-02 14:28:16 by Juthe, Robin (NIH/NCI) [E]

BZDATETIME::2011-09-02 14:28:16
BZCOMMENTOR::Robin Juthe
BZCOMMENT::13

(In reply to comment #12)
> Please verify on BACH and close this bug.

I verifed this on BACH but I'm going to keep the issue open until we promote the change to the report title.

Thanks.

Comment entered 2011-09-29 16:47:01 by Englisch, Volker (NIH/NCI) [C]

BZDATETIME::2011-09-29 16:47:01
BZCOMMENTOR::Volker Englisch
BZCOMMENT::14

The menu has now been copied to FRANCK and BACH:
BoardManagers.py - R10213

Please verify on BACH and close this bug.

Comment entered 2011-10-03 14:14:41 by Juthe, Robin (NIH/NCI) [E]

BZDATETIME::2011-10-03 14:14:41
BZCOMMENTOR::Robin Juthe
BZCOMMENT::15

(In reply to comment #14)
> The menu has now been copied to FRANCK and BACH:
> BoardManagers.py - R10213
> Please verify on BACH and close this bug.

Verified. Closing issue.

Elapsed: 0:00:00.000678