CDR Tickets

Issue Number 3403
Summary [Summaries] CSS Change for Summary Module elements
Created 2011-08-11 12:22:51
Issue Type Improvement
Submitted By Juthe, Robin (NIH/NCI) [E]
Assigned To Englisch, Volker (NIH/NCI) [C]
Status Closed
Resolved 2011-10-20 14:19:42
Resolution Fixed
Path /home/bkline/backups/jira/ocecdr/issue.107731
Description

BZISSUE::5096
BZDATETIME::2011-08-11 12:22:51
BZCREATOR::Robin Juthe
BZASSIGNEE::Volker Englisch
BZQACONTACT::William Osei-Poku

We're adding a new element - SummaryModuleLink - to summary documents to allow the inclusion of modularized content. A separate issue (OCECDR-3332) exists for creating the elements, but this issue is for CSS changes in XMetaL.

Comment entered 2011-08-18 15:41:25 by Englisch, Volker (NIH/NCI) [C]

BZDATETIME::2011-08-18 15:41:25
BZCOMMENTOR::Volker Englisch
BZCOMMENT::1

Adding dependency.

Comment entered 2011-08-24 20:36:07 by Englisch, Volker (NIH/NCI) [C]

BZDATETIME::2011-08-24 20:36:07
BZCOMMENTOR::Volker Englisch
BZCOMMENT::2

Do you have any specifics on how you want the element to be displayed?

Comment entered 2011-09-01 17:45:48 by Englisch, Volker (NIH/NCI) [C]

BZDATETIME::2011-09-01 17:45:48
BZCOMMENTOR::Volker Englisch
BZCOMMENT::3

The following files have been modified to include the changes for the SummaryModuleLink:
summary.ctm
summary.css
summary_structure.css

The is ready for review on MAHLER. I hope you like the color.

By the way, I also added color to the SummaryTitle, Title, and AltTitle tags.

Comment entered 2011-09-06 12:03:59 by Juthe, Robin (NIH/NCI) [E]

BZDATETIME::2011-09-06 12:03:59
BZCOMMENTOR::Robin Juthe
BZCOMMENT::4

(In reply to comment #3)
> The following files have been modified to include the changes for the
> SummaryModuleLink:
> summary.ctm
> summary.css
> summary_structure.css
> The is ready for review on MAHLER. I hope you like the color.

Lovely!

> By the way, I also added color to the SummaryTitle, Title, and AltTitle tags.

Looks good, but the summary title is the same color as key point. These should probably be different colors if possible.

Comment entered 2011-09-06 12:59:35 by Englisch, Volker (NIH/NCI) [C]

BZDATETIME::2011-09-06 12:59:35
BZCOMMENTOR::Volker Englisch
BZCOMMENT::5

(In reply to comment #4)
> Looks good, but the summary title is the same color as key point. These should
> probably be different colors if possible.

Yes, I used the same color for the summary title and the key points. My thinking was that - given the fact there are only a limited number of clearly distinguishable colors - I would use the same color for both mainly because there exists only one single SummaryTitle element in a summary and it always appears in a clearly defined position.

However, if you feel strongly about it I will change the SummaryTitle tag color.

Comment entered 2011-09-07 13:35:00 by Juthe, Robin (NIH/NCI) [E]

BZDATETIME::2011-09-07 13:35:00
BZCOMMENTOR::Robin Juthe
BZCOMMENT::6

(In reply to comment #5)
> (In reply to comment #4)
> > Looks good, but the summary title is the same color as key point. These should
> > probably be different colors if possible.
> Yes, I used the same color for the summary title and the key points. My
> thinking was that - given the fact there are only a limited number of clearly
> distinguishable colors - I would use the same color for both mainly because
> there exists only one single SummaryTitle element in a summary and it always
> appears in a clearly defined position.
> However, if you feel strongly about it I will change the SummaryTitle tag
> color.

Seems like a good enough reason to me. I realize now that the "Title" element is actually a different color (slightly) from the Key Point box, and that is the one that can be repeated throughout the summary. But, you're right, summarytitle will only appear once.

Please promote these changes (with the schema changes in OCECDR-3332) to Bach.

Comment entered 2011-09-07 17:13:01 by Englisch, Volker (NIH/NCI) [C]

BZDATETIME::2011-09-07 17:13:01
BZCOMMENTOR::Volker Englisch
BZCOMMENT::7

The following files have been copied to FRANCK and BACH:
summary.ctm - R10196
summary.css - R10195
summary_structure.css - R10195

Please verify on BACH and close this bug.

Bob, please note comment #6 of this issue where Robin is asking for the schema (OCECDR-3332) to be moved.

Comment entered 2011-09-15 11:40:35 by Englisch, Volker (NIH/NCI) [C]

BZDATETIME::2011-09-15 11:40:35
BZCOMMENTOR::Volker Englisch
BZCOMMENT::8

I made additional changes to the CSS on MAHLER because I thought it was very hard to see the SummaryModuleLink once I used it in a test document, especially in the tags-off mode.

Comment entered 2011-09-22 11:58:53 by Juthe, Robin (NIH/NCI) [E]

BZDATETIME::2011-09-22 11:58:53
BZCOMMENTOR::Robin Juthe
BZCOMMENT::9

(In reply to comment #8)
> I made additional changes to the CSS on MAHLER because I thought it was very
> hard to see the SummaryModuleLink once I used it in a test document, especially
> in the tags-off mode.

These additional changes look good to me. Please promote. Thanks.

Comment entered 2011-09-22 18:36:01 by Englisch, Volker (NIH/NCI) [C]

BZDATETIME::2011-09-22 18:36:01
BZCOMMENTOR::Volker Englisch
BZCOMMENT::10

The new changes have been copied to FRANCK and BACH.

Comment entered 2011-10-20 14:19:29 by Juthe, Robin (NIH/NCI) [E]

BZDATETIME::2011-10-20 14:19:29
BZCOMMENTOR::Robin Juthe
BZCOMMENT::11

Verified on Bach.

Comment entered 2011-10-20 14:19:42 by Juthe, Robin (NIH/NCI) [E]

BZDATETIME::2011-10-20 14:19:42
BZCOMMENTOR::Robin Juthe
BZCOMMENT::12

Closing issue.

Elapsed: 0:00:00.001584