CDR Tickets

Issue Number 3234
Summary Enhancements to the Summaries with Markup Report
Created 2010-09-27 10:51:48
Issue Type Improvement
Submitted By Juthe, Robin (NIH/NCI) [E]
Assigned To Englisch, Volker (NIH/NCI) [C]
Status Closed
Resolved 2010-10-20 19:02:12
Resolution Fixed
Path /home/bkline/backups/jira/ocecdr/issue.107562
Description

BZISSUE::4922
BZDATETIME::2010-09-27 10:51:48
BZCREATOR::Robin Juthe
BZASSIGNEE::Volker Englisch
BZQACONTACT::William Osei-Poku

We would like to make a few enhancements to the Summaries with Markup Report:

1. Please link the CDR IDs in the left-hand column to the QC report of the CWD of the summary.

2. Please create a new instance of this report called "Drug Summaries with Markup Report" (to be placed on the Drug Information Reports page under "Other Reports"). We would like to use the same report logic to show which Drug Information summaries have markup in them. The interface could be pretty simple - I think we would only need to have the option of which type of markup (Publish, Approved, Proposed, Rejected. And, same as request #1, please link the CDR IDs to the QC report of the CWD of the drug information summary.

Comment entered 2010-09-28 10:58:15 by Englisch, Volker (NIH/NCI) [C]

BZDATETIME::2010-09-28 10:58:15
BZCOMMENTOR::Volker Englisch
BZCOMMENT::1

(In reply to comment #0)
> 1. Please link the CDR IDs in the left-hand column to the QC report of the CWD
> of the summary.

This is done and ready for testing on MAHLER.

Comment entered 2010-09-28 15:57:56 by Englisch, Volker (NIH/NCI) [C]

BZDATETIME::2010-09-28 15:57:56
BZCOMMENTOR::Volker Englisch
BZCOMMENT::2

(In reply to comment #0)
> 2. Please create a new instance of this report

This report has been implemented and is ready for review on MAHLER.

Comment entered 2010-09-29 15:56:24 by Juthe, Robin (NIH/NCI) [E]

BZDATETIME::2010-09-29 15:56:24
BZCOMMENTOR::Robin Juthe
BZCOMMENT::3

Could the QC reports display with the markup as chosen? i.e., if the user selects to view the Summaries with Markup Report with information about each type of markup, could the QC report also show these types of markup? Or if the user selects "Approved", the QC report would only show "Approved" markup? If adding this extra layer of a report within a report is pretty complicated to do, let me know...

We do not need to have "Advisory Board" markup as an option on the Drug Summaries with Markup Report.

Comment entered 2010-09-30 10:45:28 by Englisch, Volker (NIH/NCI) [C]

BZDATETIME::2010-09-30 10:45:28
BZCOMMENTOR::Volker Englisch
BZCOMMENT::4

(In reply to comment #3)
> Could the QC reports display with the markup as chosen?

This sounds simple but needs more discussion.
The first question would be if the report should function just like the QC reports? If the answer is 'Yes' then we will have to apply our hierarchy of applying mark-up according to the Markup Revision Table attachment listed in OCECDR-3226 and we should probably think of what else users might find to be part of a "standard" QC report (include glossary links at end of report, display images or placeholders, list standard wording, etc.).

> i.e., if the user
> selects to view the Summaries with Markup Report with information about each
> type of markup, could the QC report also show these types of markup? Or if the
> user selects "Approved", the QC report would only show "Approved" markup?

This sounds very similar to the QC report the translators have requested and would probably be a complete new report but it might be possible - I need to do more research on this - to create a report with an option to add/remove individual mark-up (similar to the Bugzilla report to add/hide text).
I would need to think about it and try it out first.

> We do not need to have "Advisory Board" markup as an option on the Drug
> Summaries with Markup Report.

I kept the Advisory Board markup because it's an attribute of the Insertion/Deletion element which is available to the DIS maintainers.
We could either have the option unchecked by default or remove it completely.
Please let me know which you'd prefer.

Comment entered 2010-10-04 15:47:23 by Englisch, Volker (NIH/NCI) [C]

BZDATETIME::2010-10-04 15:47:23
BZCOMMENTOR::Volker Englisch
BZCOMMENT::5

As discussed on Thursday, the link from the report to the summary will now redirect the users to the intermediary page allowing the users to specify which markup they would see and allowing them to check all other options available.

The Advisory option has been removed from the DIS report.

These changes are ready for review on MAHLER.

Comment entered 2010-10-05 09:45:34 by Juthe, Robin (NIH/NCI) [E]

BZDATETIME::2010-10-05 09:45:34
BZCOMMENTOR::Robin Juthe
BZCOMMENT::6

Both reports look good on Mahler with these changes. I asked Diana and Deb to take a look at the DIS markup report before we promote it, so I will let you know when I hear back from them.

Comment entered 2010-10-20 10:15:16 by Juthe, Robin (NIH/NCI) [E]

BZDATETIME::2010-10-20 10:15:16
BZCOMMENTOR::Robin Juthe
BZCOMMENT::7

Diana and Deb have reviewed the DIS report and it's good to go.

Please promote all changes to BACH.

Comment entered 2010-10-20 11:34:15 by Englisch, Volker (NIH/NCI) [C]

BZDATETIME::2010-10-20 11:34:15
BZCOMMENTOR::Volker Englisch
BZCOMMENT::8

The following programs have been copied to FRANCK and BACH:
SummariesWithMarkup.py - R9932
DrugInfoReports.py - R9932
DISWithMarkup.py - R9933

Please verify on BACH and close this bug.

Comment entered 2010-10-20 19:02:12 by Juthe, Robin (NIH/NCI) [E]

BZDATETIME::2010-10-20 19:02:12
BZCOMMENTOR::Robin Juthe
BZCOMMENT::9

Verified on BACH. Closing issue.

Elapsed: 0:00:00.000557