Issue Number | 3088 |
---|---|
Summary | Change chemical structure name element to chemical structure on cancer.gov? |
Created | 2010-02-12 16:08:46 |
Issue Type | Improvement |
Submitted By | Osei-Poku, William (NIH/NCI) [C] |
Assigned To | Englisch, Volker (NIH/NCI) [C] |
Status | Closed |
Resolved | 2010-11-01 12:07:16 |
Resolution | Fixed |
Path | /home/bkline/backups/jira/ocecdr/issue.107416 |
BZISSUE::4764
BZDATETIME::2010-02-12 16:08:46
BZCREATOR::William Osei-Poku
BZASSIGNEE::Volker Englisch
BZQACONTACT::William Osei-Poku
We have discussed this a few times in the past however, I forgot to follow up because we did not track the progress in Bugzilla. Below is the communication between Volker and Blair about this issue:
>From: Learn, Blair (NIH/NCI) [C]
>Sent: Friday, August 21, 2009 4:50 PM
>To: Englisch, Volker (NIH/NCI) [C]
>Cc: Safarnejad, Reza (NIH/NCI) [C]; Ramirez, Christine (NIH/NCI)
[C]
>Subject: RE: Change in Terminology Files
>
>GateKeeper doesn’t care what the value is for OtherNameType.
>
>But when CancerGov extracts the list of “other” names, it filters
them against a list of known OtherNameType values.
>
>I’d have to talk to Min about it, but I suspect the
TermOtherNameType table is maintained manually. Its main purpose seems
to be controlling the order in which “other” names are displayed. (As
opposed to the editors needing to remember the relative priority of each
type.)
>
>It is possible to use TermOtherNameType to translate “Chemical
structure name” to “'Chemical name”, but I don’t think this is a good
idea. If I put value A into the list at one end, having it magically
transformed into value B at the other end would be (at best)
confusing.
>
>
>_____________________________________________
>From: Englisch, Volker (NIH/NCI) [C]
>Sent: Thursday, August 20, 2009 2:00 PM
>To: Learn, Blair (NIH/NCI) [C]
>Cc: Safarnejad, Reza (NIH/NCI) [C]
>Subject: Change in Terminology Files
>
>
>Blair,
>
>The Term documents contain an element under the OtherName parent
called OtherNameType that is sometimes populated with the text (from a
LOV) 'Chemical structure name'. As an example, please see CDR37793
(rosiglitazone maleate)
>
>CIAT is asking to have this value changed from 'Chemical structure
name' to 'Chemical name'.
>
>Can you tell if this change would have any impact at your end?
>
>–
>Volker Englisch
>Contractor - Lockheed Martin
>phone: (301) 496-0102 (CTB)
>mailto:volker@mail.nih.gov
>
BZDATETIME::2010-05-11 17:48:08
BZCOMMENTOR::Volker Englisch
BZCOMMENT::1
I've looked at this with Blair and it brings up a few questions on
what exactly is supposed to happen:
a) Is the goal of this task to change the label that is being
displayed
on Cancer.gov from "Chemical structure name" to "Chemical name"?
This could be done by changing a string in the database but the
change
wouldn't have any effect on the existing data.
b) Is the goal to change the LOV for the OtherNameType to "Chemical
name"?
This would require to run a global update to change all of the
existing
values and make some more or less minor modifications to the
Cancer.gov
code.
c) Is the goal to keep the old "Chemical structure name" and
additionally
allow the new string "Chemical name" to be valid?
BZDATETIME::2010-05-13 10:34:08
BZCOMMENTOR::William Osei-Poku
BZCOMMENT::2
(In reply to comment #1)
> I've looked at this with Blair and it brings up a few questions on
what exactly
> is supposed to happen:
> a) Is the goal of this task to change the label that is being
displayed
> on Cancer.gov from "Chemical structure name" to "Chemical
name"?
> This could be done by changing a string in the database but the
change
> wouldn't have any effect on the existing data.
Yes. The goal is to make the change on cancer.gov only. But I also recognize that we do have a value for the OtherNameType that is 'Chemical structure name'. However, if you can make the change on cancer.gov without changing the value in the CDR, that will be fine. The user is only concerned that what is displayed on cancer.gov is not accurate.
> b) Is the goal to change the LOV for the OtherNameType to
"Chemical name"?
> This would require to run a global update to change all of the
existing
> values and make some more or less minor modifications to the
Cancer.gov
> code.
No
> c) Is the goal to keep the old "Chemical structure name" and
additionally
> allow the new string "Chemical name" to be valid?
No
BZDATETIME::2010-05-13 16:30:07
BZCOMMENTOR::Volker Englisch
BZCOMMENT::3
(In reply to comment #2)
> Yes. The goal is to make the change on cancer.gov only.
I've submitted the request to Blair to make this change part of the next Gatekeeper release.
BZDATETIME::2010-10-20 09:52:10
BZCOMMENTOR::Volker Englisch
BZCOMMENT::4
This needs to be discussed with Min who is on vacation for the past two weeks.
BZDATETIME::2010-11-01 11:15:13
BZCOMMENTOR::Volker Englisch
BZCOMMENT::5
The change is in production on Cancer.gov.
Please verify and close this bug.
BZDATETIME::2010-11-01 12:07:16
BZCOMMENTOR::William Osei-Poku
BZCOMMENT::6
(In reply to comment #5)
> The change is in production on Cancer.gov.
>
> Please verify and close this bug.
Verified on cancer.gov. Looks good. Thank you!
Issue closed
Elapsed: 0:00:00.001342