| Issue Number | 523 |
|---|---|
| Summary | [Home] Unexpected value for hotel request alert |
| Created | 2019-08-20 16:01:28 |
| Issue Type | Bug |
| Submitted By | Juthe, Robin (NIH/NCI) [E] |
| Assigned To | Kline, Bob (NIH/NCI) [C] |
| Status | Closed |
| Resolved | 2019-08-20 18:20:47 |
| Resolution | Fixed |
| Path | /home/bkline/backups/jira/oceebms/issue.248594 |
I'm seeing a number "1" beside hotel requests in the alert section of my home page (Robin Juthe) on PROD. There hasn't been a submitted hotel request from the Genetics Board since April 23 and Victoria doesn't have a "1" on her home page, so it doesn't seem to be tied to the Site Admin role either. Any idea what could be causing this?
Here's the ticket describing the hotel request alert functionality: OCEEBMS-168
~juther: I thought it would be prudent to pass on the fact that Kevin Zbuk did submit a Marriott hotel request on the evening of August 15 for the September 17 meeting, even before I have any idea why it's not showing up in the report table, so you could make sure he got his reservation. I'll comment again when I've unraveled the cause.
Please acknowledge when you've seen this comment.
I think I see what happened. The board member did not select a meeting, and the query needs the meeting to support the requirement introduced with TIR #2366 (support sorting by meeting column). The validation to ensure that the request can't be submitted works if there are meetings in the picklist and the board member doesn't select one, but if the board member brings up the request form before you've gotten the meeting on the calendar and there are no other meetings, then the form allows "No available meetings" to be selected (it is anyway, since it's all that the list has) and the submission to go through. I have tested a way to eliminate this loophole and make the required meeting validation work even if there are no meetings.
Interesting! Thanks for the heads up about Kevin. I’ll make sure Robyn is aware of his request.
Fixed on DEV.
I put it in the release, as this isn't the sort of thing you want happening very often (hotel requests falling on the floor), and the fix was easy (once I had tracked down the cause). We've actually been pretty lucky, as this has only happened once other time, also with Kevin Zbuk, requesting the Courtyard in Gaithersburg for the May 1 meeting this year. That's what he gets for being so prompt, getting to the form before you get the meeting in the system. 🙂
To test, log on as a member of a board which doesn't have any meetings on the calendar, and try to submit the form with "No available meetings" selected from the picklist.
Good thing you noticed the alert! 🙂
Verified on QA.
There isn't a clean way to verify this on PROD, but we'll reopen it if it becomes an issue.
Elapsed: 0:00:00.000716