Issue Number | 446 |
---|---|
Summary | [Printing] Remove Two Exclusion Reasons |
Created | 2017-06-14 14:29:41 |
Issue Type | Improvement |
Submitted By | Juthe, Robin (NIH/NCI) [E] |
Assigned To | Kline, Bob (NIH/NCI) [C] |
Status | Closed |
Resolved | 2017-06-14 15:30:31 |
Resolution | Fixed |
Path | /home/bkline/backups/jira/oceebms/issue.210067 |
Please remove the following exclusion reasons from the printed coversheet.
-Already cited in the PDQ summary
-Missing/incomplete outcome data; major protocol deviations
These were removed from the online list of exclusion reasons (OCEEBMS-444).
Is there any reason why Alan needed to hard-code the exclusion reasons instead of just pulling them from the database? Are there special needs for the print review sheets that wouldn't be met by using the same list as we use online?
It appears that he did customize the list a bit. Instead of "Other (specify reasons in the Comment(s) field)" he has "Other (specify reason[s] below)"; and he leaves out the "Conflict of interest" reason. Are these differences intentional?
No, they aren't intentional. It would be great to match this up with what we have online.
Oops, I missed your earlier comment. No, I don't see any reason to hard-code the exclusion reasons. It would be easier from a maintenance perspective if the data were pulled from the database, but I don't know about the technical requirements for doing so.
I have modified the code to pull the values from the database. I can see why he might have thought "specify reason[s] below" might be less odd than "specify reasons in the Comment(s) field," since people don't tend to think of paper forms having fields, particularly when the space for the information is blank lines instead of a box. But our board members are smart folks, and I'm pretty confident they'll figure it out. :-)
Go ahead and add this ticket to the sprint for the release.
Verified on QA.
We have not had an occasion to test this issue on PROD yet (no printed packets since the change went live). We'll reopen it if there are any problems.
Elapsed: 0:00:00.000590