| Issue Number | 34 |
|---|---|
| Summary | [Full Citation] Entering Bd Member Responses - Wiping out Previous Response |
| Created | 2013-09-17 10:28:44 |
| Issue Type | Improvement |
| Submitted By | Juthe, Robin (NIH/NCI) [E] |
| Assigned To | Kline, Bob (NIH/NCI) [C] |
| Status | Closed |
| Resolved | 2013-12-24 12:32:00 |
| Resolution | Fixed |
| Path | /home/bkline/backups/jira/oceebms/issue.113321 |
TIR #2498 entered 2013-04-15 by Robin Juthe
In testing TIR 2267 on QA, we noticed that we are able to enter a decision for a Board member who already responded, but this second decision replaces the earlier decision. This is good from the perspective of correcting mistakes, but bad from the perspective of losing history of decisions about the article. We thought it may help to either have a pop-up box ask if you really want to replace the Board member's first response OR for the second response for the same Board member to inactivate his/her earlier response.
We're pretty sure no decision history is lost. One of us would be able to provide an ad-hoc report of what the replaced decisions were for one or more articles. Is this sufficient, or would it be necessary to implement a user interface for access to those overridden decisions? LOE estimate is for implementing such a user interface.
Added Robin as a watcher so she'll see the question posted in November.
I looked more carefully at this issue, and discussed it further with Alan. Both of us have a vague recollection of the discussion which resulted in the comment I posted on November 7, but we have now come to the conclusion that the comment was not right: when you edit a board member's review of an article, you are replacing what the board member originally submitted. I will proceed with the attempt to add the popup originally requested for this ticket. If I am unsuccessful (this page is controlled by an extraordinarily complex code file), I will fall back on putting a warning on the form.
I looked carefully at the code for the full citation page, and I have come to the conclusion that it is not feasible to detect in Javascript whether the review about to be stored will replace an existing review, without a significant amount of work beyond the original estimate for this task, and I'm not sure the result would be reliably safe. I have instead put a prominent warning on the form. An alternate approach would be to add a checkbox labeled something like "Replace any existing reviews by the selected board member" and prevent the action in the PHP code if a review would be replaced and the box isn't checked. Let me know if you want to go down that path.
Erika:
Added you as a watcher so you can pull this into iteration 3.
Bob, I like the warning text you added. I think this will suffice. Thank you.
Promoted to QA.
Bob - just a quick note, on QA in the message, the word "completely" is spelled "competely." Please correct, thanks!
Thanks for catching that, Victoria. Typo fixed on DEV, QA, and in Subversion.
Would it be possible to tweak this wording? Bonnie found it confusing.
If you enter a review for an article that has already been recorded for the packet and reviewer combination you select, the original review will be completely replaced. Consider preserving information from the original review in the comment field.
Wording modified (DEV and QA).
Verified on QA.
Verified that the warning text is on prod. We haven't had an occasion to re-enter a Board member response, so we'll re-open this if we encounter any problems.
Elapsed: 0:00:00.000179