EBMS Tickets

Users discussed this and said another option would be to use a line to separate the articles.

I'm going to work on this while I'm waiting for an answer to a question I posed on the Drupal forums about another issue.

I have put a fixed version onto DEV and into version control.  The changes
are:

If (and only if) there are abstracts on the citation review display:

   Put a horizontal line separator between the bottom of one abstract and the
   top of the next.

I don't put a horizontal line over the first citation, thus treating the line
as a separator rather than a top border on all citations.

I tried it out using increased white space as a separator but, to my eye, it
looked better with a line separator.  Perhaps it would look better still if I
moved the separator line up a few pixels - but it's getting late and I don't
want to tweak it tonight.

I'm going to mark the issue Resolved as Fixed.

Doesn't look as if it's working in Chrome. Let's talk about a way to do it in PHP instead of client-side script.

Ah yes, I see I have made the same mistake before of using only a single browser for testing. Hopefully I will only make this mistake twice and not keep endlessly repeating it.

The code I wrote doesn't work in my version of IE either. I tried scaling back the specificity of the jQuery selector that finds where to insert the class that causes the line to draw made. That seemed the most likely feature of what I did that hadn't made it into every browser. That change made it work (after a full refresh of the pages) in all browsers. But we should still discuss whether there's a better way. Removing the advanced selector I used caused a line to appear above the first citation as well as the other citations. I think I can remove that if needed but maybe there's a better way to do it in PHP.

I have implemented a solution which doesn't depend on using Javascript to manipulate the HTML document on the fly. Ready for user review on DEV. When Robin's back in the office I'll show her the alternate version which adds a horizontal border between the articles to see which she prefers, and we can also discuss exactly how much white space she prefers between the articles.

Bob's approach was better than mine. I have reverted the citations.js code to the state it was in before my change.

Promoted to QA.

Verified on QA.

Verified on production.