EBMS Tickets

We discussed this issue a bit today and came up with potential solution for handling FYIs that would be worth investigating (and getting a story point estimate for).

We propose using the Flagged for FYI option to identify FYI articles. The advantage to doing this is that we are consistent with what has been done historically and we can easily identify the articles as FYIs (on the search page and on the full citation page). However, rather than have these FYI-flagged articles be "dead in the water", we would display them on the Create Packets page and allow them to be included in a packet.

On the Create Packets page, we would have two separate sections - one for approved articles (which lists the same articles that currently appear on the page for each topic) and a second section for FYI articles (where each of the articles that have been flagged for FYI but haven't yet been included in a packet for that topic would display). We would then create a packet for the approved articles as we do now and we would create a second packet for the FYI articles, which would display on the Board members' FYI Packets page.

I'm thinking we may also need modifications to the printing program to handle packets with a different summary page and response sheet, or no response sheet.

Since FYI packets don't have rows in the packet reviewer table, these packets aren't printed.

~JutheR: are there any additional refinements needed for this request?

This one needs discussion with the other Board managers to determine if we want to implement it at this time. Please hold off until I get a chance to run this past the group. Thanks.

We discussed this some more today and we are considering a different approach that I'll summarize below. Our preference would be to include FYI articles within an assigned packet rather than have them on the FYI packets page, so we would be removing the FYI packets page. (One of the reasons for combining FYI articles and assigned articles is to allow editorials/commentaries to be sent as FYIs but still keep them alongside their associated article.) This isn't ready to be implemented, but if you see any red flags or have any suggestions, let us know!

1. Use "Flagged for FYI" option to identify FYIs (including editorial articles).
2. Display FYI articles on the Create Packets page (perhaps in their own section) and allow them to be included in a packet together with assigned articles.
3. Need to determine how the assigned packet would display - i.e., would FYI articles be mixed in with assigned articles, or would they appear at the bottom of the page? FYI articles would not have REVIEW buttons.
4. Need to determine how a packet that contained only FYI articles would move from the Assigned Packets page to the Completed Packets page. (We would no longer have the FYI Packets page.)
5. Add a new display option to the create packet page to allow for the list of reviewers to be expanded for each article. The default would be to choose reviewers for the entire packet (as we do now), but this would allow flexibility in selecting reviewers for each article.

Thanks. Sorry to change gears. This one might stay in the backlog for a bit while we iron out what we want, but I just wanted to keep you in the loop as to what we are considering.

Adding Victoria.

We discussed this yesterday and all of the Board managers have agreed on the most recent proposed approach (above, Dec 9 comment). For #3, we would like to have the FYIs display beneath the assigned articles (and above reviewer uploads). Please replace the REVIEW button with FYI (in red) beside these articles.

#4 still needs to be worked out. Please let me know once you've had a chance to review the proposed approach and we can discuss potential solutions for when to move these packets to the completed page.

Thank you!

Just wanted to add a comment to recap some of our conversations surrounding this issue. (Bob, please add to this and/or correct me if I got anything wrong.)

The new proposal for handling FYIs is much more complicated - Bob has adjusted the LOE to 60 story points. The most challenging part (as I understand it) is the idea of associating Board member reviewers to articles on an article basis as opposed to a packet basis. There are 29 places in the system that rely on the reviewer-packet relationship that would be broken by this enhancement. Another sticking point is determining how a packet containing only FYI articles would move from the "Assigned Packets" page to the "Completed Packets" page.

We are considering other potential solutions, but this needs discussion with all of the Board managers, which won't be feasible until after Jan 4.

One possibility is to allow citations given the "Flag for FYI" decision to display on the Create packet page and be included in a packet together with assigned articles. Packets containing ONLY FYI articles would be displayed on the FYI Packets page.

We just discussed this issue as a group and came up with the following scaled-back approach for FYIs that will still help us greatly in managing these articles.

1. Use the "Flagged for FYI" option to identify FYI articles.

2. Display "Flagged for FYI" articles on the Create Packets page in a separate section beneath the assigned articles.

3. Allow for the inclusion of FYI articles in a packet together with assigned articles. FYI articles should appear beneath the assigned articles on the packet page a Board member sees, with the word "FYI" in red beside the article in place of the REVIEW button. When the last assigned article in such a packet is reviewed, the packet would move to the Completed Packets page (as it does now).

4. Packets that are comprised ONLY of FYI articles would appear on the FYI packets page. Board members would continue to see any packets for their topics to which he/she is not assigned to review on the FYI packets page (as happens now).

Bob, could you please adjust the story point estimate for this approach (if you think this seems reasonable)? Please let me know if you have any questions or see any problems with this approach. Thank you!

Story points dropped to 20, which should be enough if the requirements don't wiggle around. :-)

✔ use the "Flagged for FYI" option to identify FYI articles
✔ display "Flagged for FYI" articles on the Create Packets page in a separate section beneath the assigned articles
✔ allow for the inclusion of FYI articles in a packet together with assigned articles
✔ ignore FYI articles when determining packet completion
✔ packets that are comprised ONLY of FYI articles appear on the FYI packets page
✔ board members continue to see packets for their topics to which they are not assigned to review on the FYI packets page
✔ FYI articles should appear beneath the assigned articles on the packet page a Board member sees, with the word "FYI" in red beside the article in place of the REVIEW button

Implemented on DEV.

This is looking pretty good on DEV, but I noticed that the FYI Packets page is not sorting correctly by date or by packet name.

Good catch! Sorting bugs fixed.

While QCing this issue (on the new QA-SG site), we realized we can't upload articles on the full citation page. You can browse and select an article, but when you try to save it, you get error messages:

File upload error. Could not move uploaded file.
Unable to upload 8e-levine jco 2013 23169503.pdf

File system permissions had not been configured correctly. Problem fixed, I think. Please try again.

Yep, we're back in business! Thanks!

Sharon created a packet with just FYI citations and when she saved it, she got this error message:

Notice: Undefined index: articles in pdq_ebms_edit_packet_form_submit() (line 4665 of /local/drupal/sites/ebms.nci.nih.gov/modules/custom/ebms/review.inc)

The packet was created, and it was in the queue for Test Board Member2 to review. I was able to recreate the problem and got the exact same error message one time. However, after trying different scenarios to see what combination of articles (all FYI or FYI and regular review articles) causes the errors, I am no longer getting the error for an all FYI packet. Is it possible that something was interrupting the site earlier? I'm wondering if I should keep trying to create a packet that will duplicate the error. Thanks.

Just checking – this is something that worked correctly on DEV, but not on QA?

Sorry, I couldn't say for sure. I know we looked at this on DEV (see comment from Jan 20--we met that day to review the issues), but I don't remember if the packet that was created had just FYI articles or a combination.

Doesn't look like it would have worked on DEV, either. Could you try it on DEV, and if that works, I'll promote to the new QA.

Thanks!

On DEV, none of the pages under the LITERATURE PACKETS tab are there.

And just to be clear... Sharon and I only saw the error message once. I haven't been able to recreate the error again. (I said that before, but wanted to make sure it didn't get lost in the rest of the message.)

The CBIIT servers are doing their late Friday afternoon walkabout - very slow (and sometimes whacky) responses. If I can I'll take a look over the weekend when things are back to normal. Otherwise I'll have to investigate Monday morning.

Understood.

But... I did finally recreate the problem a few times using Chrome. (The first time, i was using Firefox, and haven't been able to re-create it there.) It only happens when ALL of the papers in the packet are FYI. If I unselect the non-FYI articles and send just the FYI articles, the error doesn't happen. So I had to create a packet that only had FYI articles to get the error.

However, while doing this, I uploaded a few packets that were just "regular review" articles (to get them out of the queue so I could create a new FYI-only packet) and I got an error message when I posted these packets:

Notice: Undefined index: fyi-articles in pdq_ebms_edit_packet_form_submit() (line 4668 of /local/drupal/sites/ebms.nci.nih.gov/modules/custom/ebms/review.inc).

I'm not getting either error message using Firefox.

On DEV, none of the pages under the LITERATURE PACKETS tab are there.

Not sure what you mean by this. Can you elaborate?

You had asked me to see if this worked on DEV (comment from 5:13 on Friday) but when I logged into DEV, none of the pages under the LITERATURE PACKETS tab were there. They were all blank, so I couldn't test this.

Do you mean when you hover over the LITERATURE PACKETS menu you don't get the dropdown with Create Packet on it (among other options)? Here's what I see (on ebms-dev):

Can you attach a screenshot of what you're seeing?

Thanks!

It's back now. Something weird must have been happening Friday.

Do you still want me to test the FYI packets on DEV?

Yes, please.

It is not happening on DEV. It is still happening on the QA SG site. Still seems to be only when a packet containing only FYI articles is posted.

I think QA SG is working correctly now. Can you confirm?

Thanks.

Yes, this is working correctly now on QA SG, with no errors. Thanks!!

With our new FYI enhancements, it appears all of the articles we have flagged as an FYI since 2013 (and have presumably shared with our Boards via email since we couldn’t share them via the EBMS) are now appearing on the Create Packet page and are eligible to be included in a packet. Would it be possible to make this change to FYIs effective from this point forward rather than retroactive, so that we don’t see all of those FYI articles that we have presumably already dealt with?

If I can figure out how to do that, what should the cutoff date be?

February 1 should be fine. Thanks, Bob.

Changed requirement implemented and installed on DEV and QA-SG.

Sorry - I missed this yesterday. The FYI citations are no longer appearing on that page, which is great, but the topics that have old FYIs still show up and the number in parentheses after the topic name includes those old FYI articles. For example, on QA-SG, if you go to the Create Packet page and select Cancer Genetics, you'll see that there are 7 articles for the Cancer Genetics Overview topic. Yet, when you click on that topic there are no articles (because they are old FYIs that are now suppressed).

I think it's working OK now. Please check.

This looks great! Thank you! Verified on QA-SG.

Verified on PROD.

Decision to save FYI articles for the end of a user's packet page rescinded by OCEEBMS-436.

testing comment

testing comment too

testing threaded comment by replying to ~burnskd