| Issue Number | 230 |
|---|---|
| Summary | [Literature] PHP warning issued when citation has no author |
| Created | 2014-07-24 16:52:31 |
| Issue Type | Bug |
| Submitted By | alan |
| Assigned To | alan |
| Status | Closed |
| Resolved | 2014-07-24 16:54:58 |
| Resolution | Fixed |
| Path | /home/bkline/backups/jira/oceebms/issue.135499 |
Several screens in the literature review section format brief citations. It's done in at least three different places because the formatting of the citations was requested to be slightly different in each place.
Three of the places had code that looped through the Author elements in the XML record from NLM but had no special handling for the case where there were no authors at all. The attempt to loop through a non-existent element list resulted in the PHP warning.
This was originally thought to have been a new bug introduced by the change to the sorting of articles in one of the review pages and so was recorded and fixed under the issue OCE PDQ EBMS-192. See the comments made on 24 July 2014 in that issue for more history.
To fix the problem, all three places in the code were modified to test for the absence of authors and to use the string "[No authors listed]" in place of authors if there were none.
Marking as resolved fixed.
In case anyone needs to test other displays for this problem, one record with no authors listed at all is EBMS article ID=331928, Pubmed ID=25006622. Screens tested for the problem are listed by Robin in issue OCEEBMS-192.
I'm marking this QA verified. As Alan noted, my comments about testing are in OCEEBMS-192.
Ah right!
Erika said we had some issues that were not yet marked QA verified and mentioned this one. I thought to myself, "I'm pretty sure Robin checked that", but I didn't remember that the status change was made on OCEBMS-192 and verified there.
Well, now it's official here too, as it needs to be.
Verified on prod.
Elapsed: 0:00:00.000672