| Issue Number | 184 |
|---|---|
| Summary | [Literature] Reviewed Packets - Visual Indicator for New Reviews |
| Created | 2014-05-29 11:15:12 |
| Issue Type | Improvement |
| Submitted By | Juthe, Robin (NIH/NCI) [E] |
| Assigned To | Kline, Bob (NIH/NCI) [C] |
| Status | Closed |
| Resolved | 2014-08-01 16:37:12 |
| Resolution | Fixed |
| Path | /home/bkline/backups/jira/oceebms/issue.127614 |
We would like to have a better way to identify new reviews that have been submitted on our Reviewed Packets page.
If possible, we would like to add something in red after the reviewer name indicating the number of new reviews that we haven't seen yet. It might look like this (if Mary had submitted 4 reviews that I hadn't seen yet):
Mary Daly 4 new
Susan Domchek
Ready for review on DEV. You may need to refresh the stylesheet by holding down the shift key while clicking on the browser refresh button.
Just as a reminder of what we originally decided for tracking "seen" reviews: the database remembers when the user who created the packet last viewed the reviews page for that packet. We don't keep track of every view of that page for every packet in the system for every user in the system (the users agreed that it was sufficient to know when the packet creator last saw the reviews page for a packet). So, for example, if Robin creates a packet on Monday, and a board member posts a review on Tuesday, and Margaret visits the reviews page for that packet on Wednesday, Robin will still see the "1 new" indication next to the reviewer's name for that packet when she visits the Reviewed Packets page on Thursday. And when Margaret visits the Reviewed Packets, the "... new" indicators that she sees reflect the number of reviews that haven't yet been seen by the packet creators, not the number of reviews that have been posted since she (Margaret) looked at the reviews pages.
I hope that description makes sense, in spite of being a bit long-winded. :-)
Would it be possible to have the notification visibility tied to the logged-in user or to the Board manager rather than the person who created the packet? Bonnie creates some of the Board packets but we would like the Board manager to be notified regarding new/unseen reviews on the reviewed packets page.
I wrote:
Just as a reminder of what we originally decided for tracking "seen" reviews: the database remembers when the user who created the packet last viewed the reviews page for that packet. We don't keep track of every view of that page for every packet in the system for every user in the system (the users agreed that it was sufficient to know when the packet creator last saw the reviews page for a packet).
You replied:
Would it be possible to have the notification visibility tied to the logged-in user ....
So are we saying we've changed our mind about tracking each user who's viewed each packet reviews page? This will require some re-working of the database tables, conversion of the existing data, and changes to the software logic.
I understand this is different than what we decided before but I'm having a hard time recalling that conversation so I'm not sure what we based that earlier decision on. Do you know where else this code is used? It seems we'll need to have a better understanding of the implications before we determine whether to make the change (now or in the future).
We decided to clear out the last seen column for all packets in the system where the packet creator and the manager of the Board for which the packet was created are different and to modify the software so that we record that value when it's the manager of the Board for the packet who is looking at the reviews and not the creator of the packet who is looking at the reviews.
I'm only going to show this if the user viewing the page is the manager of the packet's board. Does that seem reasonable? It would make no sense for Bonnie to see that indication if it's no longer tracking when she saw the reviews.
Yes, it makes sense to only show the indication on this page for the Board managers. Good idea. Thanks!
Changes have been made on DEV.
Database changes will have to be made through the DBA team:
R12780 /branches/ebms-3.1/sql/release-3.1-patch.sql
When testing this today in our meeting, we saw a packet with 4 new reviews. But, when I clicked on the packet, there were only 2 reviews. The packet is: Genetics of Pancreatic Cancer [Packet #13766] and the reviewed page for this packet is located here: https://ebms-dev.nci.nih.gov/review/reviews/13766
I've looked at several other packets since then and haven't noticed any other discrepancies between the number of new reviews and the number of reviews on the page.
Are you able to tell if the packet above has been edited to remove a member who had posted a review (or 2 reviews)? Just a thought.
If you click on the header for the last column ("ARCHIVE") you'll see the two reviews which someone archived. If you hover over the header before clicking on it, you'll see the popup reminder of what clicking on the header will do.
Ah-ha! Mystery solved. Thanks.
Everyone tested this issue and I didn't receive reports of any problems, so I'm considering this verified on DEV.
Robin J, Robin B, and I were able to test this issue and it worked fine for all of us. Verified on QA.
Some of us are seeing "new" indicators next to old reviews that we know we've seen before. For example, I am seeing a "new" indicator next to three reviews from March 2014. Robin B had 37 "new" indicators when she logged in this morning.
Who created the packets in question?
I can't be certain about Robin B's but I know Bonnie creates most of her packets. Now that I take a closer look at the comments above, I think this might explain why she saw so many new reviews.
(copied from above)
"We decided to clear out the last seen column for all packets in the
system where the packet creator and the manager of the Board for which
the packet was created are different and to modify the software so that
we record that value when it's the manager of the Board for the packet
who is looking at the reviews and not the creator of the packet who is
looking at the reviews."
From this point on, once she clicks on each of these new packets, all of her "new" visual indicators will be new to her regardless of who created the packet, right?
However, this doesn't explain the "new" reviews for the Genetics Board, since I created the packet. Here is the packet in question: Cancer Genetics Risk Assessment and Counseling (February 2014) - Group A [Packet #13623]
You were logged on as Test Board Manager when you created that packet. :-)
Can you look at the reviews for this packet and then go back and see if the software still thinks you haven't seen the reviews? Thanks.
Ah-ha! That explains it.
I looked at the reviews and my review total went back to "0" so I think we're good. Thanks!
Verified on prod. Closing issue.
Elapsed: 0:00:00.000782