CDR Tickets
| Issue Number | 5322 |
|---|---|
| Summary | Proposed changes to Spanish About this PDQ Misc board (filter changes) |
| Created | 2024-03-11 11:27:02 |
| Issue Type | Improvement |
| Submitted By | Osei-Poku, William (NIH/NCI) [C] |
| Assigned To | Englisch, Volker (NIH/NCI) [C] |
| Status | Closed |
| Resolved | 2024-03-12 18:46:20 |
| Resolution | Fixed |
| Path | /home/bkline/backups/jira/ocecdr/issue.394046 |
Would it be possible to modify the publishing filters for the Spanish About this PDQ summary Misc doc to
To always display a lowercase “c” whenever “consejos” does not begin a sentence. For example, Tratamiento del cáncer de próstata - NCI (cancer.gov)
In the case of multiple boards, would it be possible not to include the “el” and “la” in the link? That is, now the “el” and “la” are included in the board links as if they are part of the names of the board. You can reference 256754 on QA.
For the first change, please keep in mind that the text "Consejo editorial del PDQ sobre el tratamiento para adultos" is coming from the PlaceHolder element provided in the Misc. Document and the string provided as the PlaceHolder content is being replaced. This string does start with a uppercase "C". I'll think about it a bit but it might be most appropriate to introduce another PlaceHolder element to distinguish a text replacement with a change of the case vs a replacement as is.
For the second item I'd like you to write out the exact text for singular and plural boards to avoid any misinterpretation.
For the second item I'd like you to write out the exact text for singular and plural boards to avoid any misinterpretation.
The text is not changing for this one. The request is only to delink "el" and "la" from the rest of the link. Essentially, the link is not supposed to include "el" and "la".
Oh, now I see. Thanks for clarifying, ~oseipokuw!
Both changes have been implemented. As mentioned earlier I have created a new PlaceHolder that allows you to control if the board name starts with a capital 'C' or lower 'c'. When using the Placeholder name='BoardNameLink' the board name is displayed as it. If the Placeholder name=BoardNameLink-lc, the board name is displayed with a lower case.
This is ready for review on DEV.
The changes look good on DEV. Please install on QA. Thanks!
The following filter has been updated on QA:
CDR000157: Filter title: Vendor Filter: Summary
Verified on QA. Please install on PROD. Thanks!
The filter changes to the filter have been copied to STAGE and PROD:
CDR000157: Filter title: Vendor Filter: Summary
https://github.com/NCIOCPL/cdr-server/commit/cdaaae0
Please verify and close this ticket.
~bkline , the filter changes for this ticket were done as part of the "riemann" repository but this particular ticket isn't. We started the filter changes under OCECDR-5297. It wasn't known when we started working on that ticket that the summary with multiple boards needed to be published ahead of the "riemann" release. All filter changes already have been pushed to PROD but those changes haven't been merged into "main".
Let's discuss how to handle a PR for these filter changes.
You can just put the changes in a separate branch and create a PR
which we'll pull into the "master" branch, and then merge back into the
"riemann" branch. I believe git is smarter than
svn was for such merges.
Verified on PROD. Thanks!
Verified on PROD. Thanks!
~volker Should still proceed to close this ticket?
| File Name | Posted | User |
|---|---|---|
| image-2024-03-11-11-25-54-587.png | 2024-03-11 11:25:53 | Osei-Poku, William (NIH/NCI) [C] |
| image-2024-03-11-11-26-22-806.png | 2024-03-11 11:26:21 | Osei-Poku, William (NIH/NCI) [C] |
Elapsed: 0:00:00.001736