| Issue Number | 5305 |
|---|---|
| Summary | [Summary] Filter Code Cleanup - IncludedDevices/ExcludedDevices |
| Created | 2023-12-05 15:44:58 |
| Issue Type | Improvement |
| Submitted By | Englisch, Volker (NIH/NCI) [C] |
| Assigned To | Englisch, Volker (NIH/NCI) [C] |
| Status | Resolved |
| Resolved | 2023-12-19 18:53:47 |
| Resolution | Fixed |
| Path | /home/bkline/backups/jira/ocecdr/issue.371247 |
Once upon a time, dinosaurs roamed the earth, Pluto was still a planet, and Cancer.gov was not responsive. Back then, we implemented the attributes IncludedDevices/ExcludedDevices to control some sections we didn't want to include in the mobile display. We don't use these attributes anymore but our summary filters are still sprinkled with code to handle these attributes and making the code unnecessarily more complicated to maintain and understand.
I propose to clean up these parts of the code and get rid of that code.
If we are going to cleanup the filters we might want to clean the documents, too. There are 9 documents that are still using the ExcludedDevices attribute:
62707 |
Non-Hodgkin Lymphoma Treatment;Treatment;Health professionals |
/Summary/SummarySection/SummarySection/Para/@ExcludedDevices |
mobile |
62863 |
Genetics of Colorectal Cancer;Genetics;Health professionals |
/Summary/SummarySection/SummarySection/Para/@ExcludedDevices |
mobile |
62910 |
Prostate Cancer Treatment;Treatment;Health professionals |
/Summary/SummarySection/Para/@ExcludedDevices |
mobile |
62932 |
Non-Small Cell Lung Cancer Treatment;Treatment;Health professionals |
/Summary/SummarySection/SummarySection/@ExcludedDevices |
none |
256672 |
Tratamiento del cáncer de pulmón de células no pequeñas;Treatment;Health professionals |
/Summary/SummarySection/SummarySection/@ExcludedDevices |
none |
256677 |
Tratamiento del linfoma no Hodgkin;Treatment;Health professionals |
/Summary/SummarySection/SummarySection/Para/@ExcludedDevices |
mobile |
256716 |
Tratamiento del cáncer de próstata;Treatment;Health professionals |
/Summary/SummarySection/Para/@ExcludedDevices |
mobile |
328116 |
Spirituality in Cancer Care;Supportive care;Health professionals |
/Summary/SummarySection/SummarySection/Para/@ExcludedDevices |
mobile |
429650 |
Efectos tardíos del tratamiento anticanceroso en la niñez;Treatment;Patients |
/Summary/SummarySection/SummarySection/KeyPoint/@ExcludedDevices |
mobile |
The following filters will need to be modified:
CDR0000000157.xml: Vendor Filter: Summary
8 occurrences
CDR0000271370.xml: Module: Vendor Filter Templates
1 occurrences
CDR0000609947.xml: Vendor Filter: Convert CG to Public Data
9 occurrences
CDR0000797103.xml: Cancer Information Summary for Drupal
CMS
55 occurrences
The filters have been updated with the following commits:
The changes should not have any affects on the output.
Elapsed: 0:00:00.001774