CDR Tickets

Issue Number 5304
Summary [Internal] Ad-hoc Query Deletion
Created 2023-12-01 11:53:48
Issue Type Improvement
Submitted By Englisch, Volker (NIH/NCI) [C]
Assigned To Kline, Bob (NIH/NCI) [C]
Status Resolved
Resolved 2023-12-07 12:49:05
Resolution Fixed
Path /home/bkline/backups/jira/ocecdr/issue.369517
Description

Assume I have two queries in the query interface named A and B:
A = "Select dada from A"
B = "Select dada from B"

When I select A then the query A is highlighted in the "Saved Queries" window and the query is displayed in the "Active Window".  If I click the "Run" button I will see the result for query A.  The same is true when I click the query B.

If I click the query A and delete this query, the entry for query A is deleted from the "Saved Queries" window and query B is highlighted.  When I then click "Run" I will still see the result for query A, because "Select dada from A" is still displayed in the "Active Window".

That behavior could be confusing. It would probably make sense not to highlight anything in the "Saved Queries" window to require the user to load a query by clicking it or to clear the content of the "Active Window" or something else entirely in order to avoid a disconnect between what's displayed in both of the windows. 

 

This is a very minor issue but I wanted to at least have it documented.

Comment entered 2023-12-01 11:55:50 by Englisch, Volker (NIH/NCI) [C]

Screenshot before deletion:

Screenshot after deletion of "AA":

Comment entered 2023-12-07 12:49:05 by Kline, Bob (NIH/NCI) [C]

Fixed on DEV (and on my DEV VM). Tell me if you like this better.

https://github.com/NCIOCPL/cdr-admin/commit/569c5158

Comment entered 2023-12-12 16:42:50 by Englisch, Volker (NIH/NCI) [C]

Yes, this is much better - exactly what I would expect when deleting a query from the query interface.

One could possibly check if the SQL query is empty and not allow to run an empty query but that would be icing on the cake.  Currently, if you delete a query and then click the Run button without first clicking another query, an empty page is displayed.

Attachments
File Name Posted User
Screenshot 2023-12-01 at 11.53.09 AM.png 2023-12-01 11:54:41 Englisch, Volker (NIH/NCI) [C]
Screenshot 2023-12-01 at 11.53.37 AM.png 2023-12-01 11:55:24 Englisch, Volker (NIH/NCI) [C]

Elapsed: 0:00:00.000476