CDR Tickets

https://cdr-dev.cancer.gov/cgi-bin/cdr/show-PDQ-summary.py?doc-id=62824

I am not clear what the goal is for this ticket.  You are referring to the XSLT filter sample on the sFTP server but then are using the "show-PDQ-summary.py" script on the CDR server which isn't used by the partners. Additionally, the script is loading a document from the database when it should be using the sample document.

I did download the sample XML and XSLT documents from the sFTP server and the transformed HTML document didn't show those issues you're referring to.  Here is the screenshot:

Of course, the XSLT and XML documents are fairly dated but they still serve their purpose:  Showing our partners how to transform a summary document.

Do we want to refresh the sample documents for the partners or do we want to fix the script show-PDQ-summary.py?

The reason why your test didn't display the summary title is a result of the test using the published version of the document.  However, the XSLT filter expects to process a summary title that includes the string "(PDQ ^(R))".  That string is only included in the partner XML and therefore, splitting the summary title in order to insert the "<sup/>" tag for the registered trademark symbol removes the actual summary title.

I am not clear what the goal is for this ticket.

The goal is to have what's in source code control match what we give the partners. I thought there was a second problem, but as you pointed out, that second problem was in my head. 😛

I've made some changes to the filter to prevent the deletion of the SummaryTitle so that the filter works properly with published XML documents as well as partner XML output. At the same time I cleaned up the code a bit, removed sections that were commented out and removed code around unused/outdated parameters.  I also updated the location for our image files so that images are displayed again.

The following files have been updated in the pdqdocs directory:

• PDQ-summary.xml

• PDQ-summary.xsl

• PDQ-summary.html

https://github.com/NCIOCPL/cdr-publishing/commit/eece76f

Note: Copying these files to the sFTP server is a manual task.