| Issue Number | 5298 |
|---|---|
| Summary | [Summary] Adjust Reports to Properly Handle Multiple Editorial Boards |
| Created | 2023-11-09 15:26:27 |
| Issue Type | Improvement |
| Submitted By | Englisch, Volker (NIH/NCI) [C] |
| Assigned To | Kline, Bob (NIH/NCI) [C] |
| Status | Resolved |
| Resolved | 2023-11-30 11:32:02 |
| Resolution | Fixed |
| Path | /home/bkline/backups/jira/ocecdr/issue.367587 |
There are a few summary reports that need to be adjusted to handle multiple editorial boards correctly.
Summary TOC Lists
If a summary includes the Adult Treatment and Pediatric Treatment board, the report only shows that summary under one of those board sections. Even if only the Adult Treatment board section is selected for the report, a Pediatric board section is included with the summary that should be listed under the Adult Treatment section.
It seems the following report will need to be adjusted as well:
Summary Internal Links
The report produces and error "'NoneType' object is not iterable" for a summary attached to multiple boards.
I have created a new ad-hoc query named English Summaries With Multiple Editorial Boards on DEV and PROD. Should be useful for this mini-project.
I have half of the work for this ticket done. the Summary TOC Lists report should now behave properly on DEV when summaries have more than one PDQ editorial board. Moderately tricky. 😛
It is a useful report to have but I would ask to recreate this one under a different name. As a user I would not think about looking under the letter 'E' when looking for a Summaries report. Maybe we want to rename this report to "Summaries With Multiple Editorial Boards - English"?
And if we're already on a roll we might want to do the same with the report "English Summary Editorial Boards". 🙂
The second problem (with the Summary Internal Links report) has been fixed as well. It turns out that this second failure was unrelated to the presence of multiple editorial boards in the summary, but was caused by a long-standing bug which blows up the script when the summary has no internal links. the report has been rewritten to detect all the possible failure paths and report problems to the user above the redrawn form.
You have my permission to rename the query any way you like. 😃
As you are probably already aware, you have to create the query again under the new name, copying in the SQL from the original, and then delete the original.
The query names have been adjusted as discussed on DEV and PROD.
The ad-hoc query has been added to the QA server.
CIAT/OCC > Summary Reports > Summaries With Links > Summary Internal Links
Enter 62843 in the Summary ID field
Click Submit
The Excel report is generated and delivered. No error is displayed
CIAT/OCC > Summary Reports > Summary Content Reports > TOC Levels
Select the Cancer Genetics board
Click Submit
There should only be a Cancer Genetics section, showing CDR62843's TOC hierarchy; no Pediatric Treatment section should appear on the report
Return to the tab with the report form
Clear the Cancer Genetics selection and select Pediatric Treatment instead
Click Submit
There should only be a Pediatric Treatment section, showing CDR62843's TOC hierarchy; no Cancer Genetics section should appear on the report
Elapsed: 0:00:00.001750