| Issue Number | 5272 |
|---|---|
| Summary | [Internal] XMetaL CSS Files |
| Created | 2023-08-18 11:27:16 |
| Issue Type | Bug |
| Submitted By | Englisch, Volker (NIH/NCI) [C] |
| Assigned To | Englisch, Volker (NIH/NCI) [C] |
| Status | Closed |
| Resolved | 2023-08-24 11:53:15 |
| Resolution | Fixed |
| Path | /home/bkline/backups/jira/ocecdr/issue.355487 |
Most of our CSS selector groups include a trailing comma ( , ) which is not standard CSS syntax. This hasn't been a problem in the past but we have experienced that XMetaL is enforcing CSS rules more strictly. Therefore, we should fix this before it becomes a problem
I had tried to create a regular expression that would allow me to modify all files in each buffer created by vim but ran into some strange results. I spent some time to investigate but realized I could make those fairly simple changes faster by using vim macros than by finding the issue with the editor.
There were a few patterns I corrected:
selector with comma and rule following on the same line
"Type, Year, { display: block; }"
selector with comma and rule following on next line - various
amounts of white space after the last comma
"Type, Year,
{ display: block; }"
selector with comma and rule following after a blank line
"Type, Year,
{display: block; }"
I created individual vim macros for each of these situations which I ran in each file.
The following files have been updated:
CTGovProtocol.css
CTGovProtocol_structure.css
CdrCommonSchema.css
CdrCommonSchema_structure.css
Citation.css
CitationSupplementaryInfo.css
Citation_structure.css
ClinicalTrialSearchString.css
ClinicalTrialSearchString_structure.css
CommonProtocolInfo.css
CommonProtocolInfo_structure.css
Country.css
Country_structure.css
Documentation.css
DocumentationToC.css
DocumentationToC_structure.css
Documentation_structure.css
DrugInformationSummary.css
DrugInformationSummary_Structure.css
GlossaryTermConcept.css
GlossaryTermConcept_structure.css
GlossaryTermName.css
GlossaryTermName_structure.css
Licensee.css
Licensee_structure.css
Mailer.css
Mailer_structure.css
Media.css
Media_Structure.css
MiscellaneousDocument.css
Organization.css
Organization_structure.css
PDQBoardMemberInfo.css
PDQBoardMemberInfo_Structure.css
Person.css
Person_structure.css
PoliticalSubUnit.css
PoliticalSubUnit_structure.css
PublishingSystem.css
PublishingSystem_structure.css
Summary.css
Summary_structure.css
SupplementaryInfo.css
SupplementaryInfo_structure.css
Term.css
TermSet.css
TermSet_structure.css
Term_structure.css
schema.css
I double-checked all CSS files in the "../Clientfiles/Display" directory and confirmed those commas at the end of a CSS rule have been deleted.
I'm confirming that the CSS files have been updated on PROD and the extra comma (,) has been removed from the rules.
Closing ticket.
Elapsed: 0:00:00.001408