Issue Number | 5142 |
---|---|
Summary | [Summary] Modify Comment element to easily identify notes meant for translators |
Created | 2022-09-21 16:44:41 |
Issue Type | New Feature |
Submitted By | Osei-Poku, William (NIH/NCI) [C] |
Assigned To | Kline, Bob (NIH/NCI) [C] |
Status | Closed |
Resolved | 2022-09-23 13:32:14 |
Resolution | Fixed |
Path | /home/bkline/backups/jira/ocecdr/issue.328099 |
As a translator, I want to be able identify comments in a summary that have specifically been left for me so that I can apply it during translation.
Several comments are left in a summary document for both internal and external users. Some of the internal comments are meant specifically for translators. However, it is sometimes difficult to identify the specific translation comments among the other comments within the summary document. We would want to be able mark a comment that has specifically been left for translators so that they can be easily identified.
Acceptance criteria:
Scenario: CDR has the ability to mark comments specifically for translation
Given I am a CDR summary editor
And I have permissions to create or modify summaries
When I create or modify a summary that needs to be translated
And I add a comment for translators
Then I want to be able to “tag” the comment accordingly
Your two scenarios are asking for two distinct things. The second
would be a styling change which ~volker would implement (so probably needs a
separate ticket). The first would seem to call for expanding the list of
valid values for the audience
attribute of the
Comment
element (type {}CommentAudience{
}). Do
you agree?
I agree on moving the second scenario to another ticket.
The first would seem to call for expanding the list of valid values for theaudience
attribute of theComment
element (type{}CommentAudience{
}). Do you agree?
I am hesitant to add another value to the list of audiences because that captures the two main categories of audience and what we are asking for is a type of Internal audience. Would it be possible to make change so that when Internal is selected, there will be a secondary attribute value of "ForTranslators", for example to select within the element? I think there is a similar feature in Person and Organization address blocks or so. The default would just be internal without any further selection but there will be an option to select "ForTranslators", if needed.
I agree with ~oseipokuw. Modifying the 'audience' feels like a can of worms. I would still consider the translator comments as internal - with an asterisk.
Hmm, it would seem then that we picked the wrong name for that
attribute, because the "{}audience{
}" for the comment is
exactly what you're trying to convey. Perhaps
"{}visibility"{
} or "{}scope"{
} would have
been more appropriate. Oh, well, probably too late now to do anything
about that problem.
Can you show me an example of the feature you referred to for Person and Organization address blocks?
Can you show me an example of the feature you referred to for Person and Organization address blocks?
Please see CDR0000002202 and CDR0000029008 on DEV. Here are screenshots too.
What I'm looking for is an example of the behavior you described above, in which a second attribute appears on an element only if a first attribute has a specific value.
We don't have that currently.
As we discussed in the CDR meeting yesterday, I have removed the second scenario so that this ticket will focus on just the schema change.
New optional specific-internal-audience
attribute added
to the Comment
element, with a valid value set initially
containing only the single "translators" value. Installed on CDR
DEV.
Verified on DEV.
Verified on QA.
Verified on PROD. Thanks!
File Name | Posted | User |
---|---|---|
Public contact.PNG | 2022-09-22 12:00:29 | Osei-Poku, William (NIH/NCI) [C] |
Public contact1.PNG | 2022-09-22 12:00:52 | Osei-Poku, William (NIH/NCI) [C] |
Elapsed: 0:00:00.001475