| Issue Number | 5120 |
|---|---|
| Summary | [Summary] Filter Change to Fix non-unique SummaryURL Values Problem |
| Created | 2022-06-06 17:51:11 |
| Issue Type | Improvement |
| Submitted By | Englisch, Volker (NIH/NCI) [C] |
| Assigned To | Englisch, Volker (NIH/NCI) [C] |
| Status | Closed |
| Resolved | 2022-06-09 18:29:38 |
| Resolution | Fixed |
| Path | /home/bkline/backups/jira/ocecdr/issue.319628 |
Currently, there exists a bug allowing summaries to be validated even when the documents SummaryURL value is not unique as required. This issue has been fixed as part of Ohm.
The validation rule will not get triggered for document including the "WillReplace" element. The users added this element. so that a partner document and the corresponding SVPC documents could contain the same SummaryURL value. However, any summary with a "WillReplace" element will not be picket up for publishing therefore preventing those document from going out to Cancer.gov. This means neither the SVPC not the partner document can contain this element and the URL for both documents must be unique.
As a temporary solution we want to reuse the SummaryURL from the dedicated SVPC for the partner document but append the string "/partner" to the URL in that document. We will then modify the publishing filters to strip out that string from the final version of the partner document being delivered.
Would it be possible to have the filters programmatically use the SummaryURL of the Overview summary (or the SummaryURL of any of the linked SVPC summaries) that is always linked in the partner summary? Currently, we are copying the SummaryURL from the overview summary to replace the old/legacy SummaryURL of the partner summary. Since you are going to make changes to the filters anyway, I was wondering if you can instead make the change to pick the SummaryURL of one of the linked SVPC summaries. This will mean that we would not have to replace the old/legacy SummaryURL of the partner summary so there will not be a duplicate. We will have to go back and replace SummaryURLs of the existing partner summaries that we just completed but that would be only a one time thing to do.
If you don't replace or modify the SummaryURL of the partner document you will not be able to save a publishable version of the Overview document because both, the partner document and the overview document would display the same value resulting in a validation error.
Let's say the legacy document has the following URL
/liver-cancer
You now convert the legacy document to become a partner document and the SVPC documents will receive the following URLs:
Overview
/liver-cancer
Screening
/liver-cancer-screening
Prevention
/liver-cancer-prevention
You won't be able to save the Overview document unless the URL of the partner document has been modified (as proposed) to
/liver-cancer/partner or
/liver-cancer-partner or something similar
Does that make sense or did I misunderstand what you were asking for?
If you don't replace or modify the SummaryURL of the partner document you will not be able to save a publishable version of the Overview document because both, the partner document and the overview document would display the same value resulting in a validation error.
Yes, I recognize that and that is why I said in my last statement that we need to go back and fix the existing ones.
We will have to go back and replace SummaryURLs of the existing partner summaries that we just completed but that would be only a one time thing to do.
The idea is to leave the legacy/partner SummaryURLs to retain the original/old URLs that used to go to Cancer.gov. Essentially, we will not need to modify any new partner summaryURLs. That is, if the filter can pick up any one of the SummaryURLs from the SVPC summaries that are linked. We will also not have any duplicate SummaryURLs in the CDR because the partner summaries will retain their original/old URLs and the SVPC will have their new Summary URLs.
This ticket was created because you said (in OCECDR-5100) we needed to find a solution for the non-unique SummaryURLs. If I understand you correctly we don't have a problem with non-unique SummaryURLs anymore. I should probably rename the title for this ticket to reflect that.
In that is correct, all you have to do is give me the instructions on how the program should identify the SVPC module to extract its SummaryURL from.
After talking with ~oseipokuw, we decided to use the URL of the first SVPC module to replace the partner document's SummaryURL.
The following filters have been updated to replace the SummaryURL element of a partner document with the one from the first SVPC module linked:
CDR712005.xml - Denormalization Filter: Summary Module
https://github.com/NCIOCPL/cdr-server/commit/0242495
CDR000157.xml - Vendor Filter: Summary
https://github.com/NCIOCPL/cdr-server/commit/0242495
A test publishing job ran successfully on DEV.
Verified on DEV. Thanks!
Verified on QA. Thanks!
~oseipokuw, given the fact that we're about to publish the next set of SVPC documents, I'm assuming that these Ohm tickets related to validating summary documents with duplicate SummaryURL values are working as expected in PROD, right?
Is it OK to close these tickets?
Yes, it is OK to close this ticket. We have not ran into any problems. Thanks!
Elapsed: 0:00:00.001793