CDR Tickets

While I'm working on the report, I thought you might want to be aware that CDR258195 (Plasma Cell Neoplasms (Including Multiple Myeloma) Treatment;Treatment;Patients) has a link to http://www-new.cancer.gov/cancertopics/treatment/types/targeted-therapies/targeted-therapies-fact-sheet (so it won't show up on the report, but possibly of interest nevertheless).

Report attached.

The updated list is attached. We have removed a few extra rows for docs that don't need updating. Could you please run the global on DEV? 

Please change the link and display text to the following:

• https://www.cancer.gov/about-cancer/treatment/types/targeted-therapies

• Targeted Therapy to Treat Cancer

We've also updated the Plasma Cell Neoplasms URL manually (to the targeted therapies page that we're keeping) - thanks for catching that.

I just realized that the original spreadsheet was generated from documents on CDR DEV, but you probably wanted documents from PROD. It won't make any difference for the runs on DEV, but would you like me to fold in some or all of the documents which didn't get picked up by the original spreadsheet as we roll up the tiers? Here they are.

Test run complete on DEV.

https://cdr-dev.cancer.gov/cgi-bin/cdr/ShowGlobalChangeTestResults.py?dir=2022-06-10_10-11-36

~bkline  Do you know why the test results display horizontally across the page rather than wrapped vertically. In the past, it wasn't like this but recently the results all display horizontally like it is now even if I try the link in other browsers. When the documents are not as big as summaries, they are manageable but for summaries like these, you have to scroll horizontally for a long time in order to see the changes. 

In the past, it wasn't like this ...

I think your memory is playing selective tricks on you. We've had this same discussion more than once over the years. For example:

Addressing this phenomenon might be possible, but it would certainly not be trivial. I don't know whether we would need to undertake a massive reformatting of the CDR documents to introduce whitespace where we want it, avoiding injecting it in the wrong places (though I'm not confident the work of such an undertaking wouldn't be undone by subsequent saves of the documents from XMetaL), or if this would instead require creating our own custom parser and comparison tool which would understand the structure of each of the document types (and need to be maintained as the schemas change). In any case, if you want to revisit these discussions the appropriate place would be in a separate ticket which would need to be estimated, approved by management, and scheduled for a release.

I do remember this exchange with Volker last year but didn't create the ticket because I thought it will be manageable but some of the globals affecting summaries are so difficult to review in the current format. I will create a ticket to address this issue.

Please run this global in test mode on QA. Thanks!

I never got a response to my question about expanding the list from what was in the original spreadsheet. Should I take that to mean it's not needed?

Please proceed to expand the list to capture the missing ones from PROD. Thanks!

Test mode completed on QA.

https://cdr-qa.cancer.gov/cgi-bin/cdr/ShowGlobalChangeTestResults.py?dir=2022-09-21_11-57-42

Please run this global in live mode on QA. Thanks!

Done.

2022-09-27 17:16:13.068 [INFO] Run completed.
   Docs examined    = 252
   Docs changed     = 241
   Versions changed = 522
   Could not lock   = 0
   Errors           = 0
   Time             = 0:24:25.215123
Specific versions saved:
  new cwd = 41
  new pub = 239
  new ver = 42
  old cwd = 69

Please run this global in test mode on QA again. Thanks!

Done.

2022-10-06 15:43:47.925 [INFO] Run completed.
   Docs examined    = 252
   Docs changed     = 0
   Versions changed = 720
   Could not lock   = 0
   Errors           = 0
   Time             = 0:14:36.846412

https://cdr-qa.cancer.gov/cgi-bin/cdr/ShowGlobalChangeTestResults.py?dir=2022-10-06_15-29-11

Global change implemented and run on lower tiers.

Would you be able to modify the global to change the data in the SourceTitle fields to the new page title "Targeted Therapy for Cancer - NCI" as part of this global? We enter this information manually when we first add the URLs to capture the page title. This information is later used by the URL check report to compare the page titles for changes. Since the URL is changing, the page title must also change to reflect the current page.

Run on DEV

2022-11-02 07:33:02.291 [INFO] Run completed.
{{   Docs examined    = 242}}
{{   Docs changed     = 0}}
{{   Versions changed = 703}}
{{   Could not lock   = 0}}
{{   Errors           = 0}}
{{   Time             = 0:13:24.987913}}

https://cdr-dev.cancer.gov/cgi-bin/cdr/ShowGlobalChangeTestResults.py?dir=2022-11-02_07-19-37

I just checked a few documents and so far, I have not seen changes to the SourceTitle data.

Ah, I didn't realize you were talking about a separate attribute. I thought you were just asking for the denormalized title to be changed in the linking element's text content. I'll modify the code to set that value back to what it was for the original global change, add code to change the other attribute, and run the job again.

https://cdr-dev.cancer.gov/cgi-bin/cdr/ShowGlobalChangeTestResults.py?dir=2022-11-02_10-31-00

I see that the anchor text is changed from "Targeted Cancer Therapies" to "Targeted Therapy to Treat Cancer"  but I don't see any instructions in the comments regarding that. I hope it is not Jira hiding comments from me 🙂. It is also possible that this is inferred from the original request. 

Also, for this test run, I don't seem to see that the SourceTitle data is changed.  Rather at least some of the anchor texts are changed to "Targeted Therapy for Cancer - NCI" if I am reading the diff report right. 

That's the title of the page you asked me to switch the link to, right?

1. There is a SourceTitle attribute on some of the linking elements that contains the old page title information (Targeted Cancer Therapies Fact Sheet - National Cancer Institute). This is what needs to change to the "Targeted Therapy for Cancer - NCI", if possible. This is for internal use (URL Check Report). 

• <RelatedExternalRef SourceTitle="Targeted Cancer Therapies Fact Sheet - National Cancer Institute" UseWith="en" cdr:xref="https://www.cancer.gov/about-cancer/treatment/types/targeted-therapies/targeted-therapies-fact-sheet">Targeted Cancer Therapies</RelatedExternalRef> ? --------------------------— ^^^^^^^^^^^^^^^^

• + <RelatedExternalRef SourceTitle="Targeted Cancer Therapies Fact Sheet - National Cancer Institute" UseWith="en" cdr:xref="https://www.cancer.gov/

2. The anchor text issue is a different question. I just want to make sure that is the anchor text we want in the documents since that will display on cancer.gov

Can you give me in one comment a complete statement of exactly the things you want this global change to do?

Sure. For the selected documents, for any linking element that has the SourceTitle attribute, if the attribute value is populated, replace it with "Targeted Therapy for Cancer - NCI". If the attribute value is not populated, please add the attribute value "Targeted Therapy for Cancer - NCI" (this is a new request). The anchor text should remain "Targeted Cancer Therapies". It should only change if it says, "Targeted Cancer Therapies Fact Sheet". In that case, it (anchor text) should change to "Targeted Cancer Therapies".

I didn't want to repeat the original request of changing the URLs here.

https://cdr-dev.cancer.gov/cgi-bin/cdr/ShowGlobalChangeTestResults.py?dir=2022-11-02_17-27-14

Please run in live-mode on DEV. Thanks!

Done.

Please run the global in test mode on QA. Thanks!

https://cdr-qa.cancer.gov/cgi-bin/cdr/ShowGlobalChangeTestResults.py?dir=2022-11-17_11-43-58

Please run in live mode on QA. Thanks!

Done.

Please run the global in test mode on PROD. Thanks!

https://cdr-dev.cancer.gov/cgi-bin/cdr/ShowGlobalChangeTestResults.py?dir=2022-11-29_06-52-58

Thanks! Please run the global in live mode on PROD.

JIRA's hiding William's most recent comment, so I can't post a threaded reply. The job has been run in live mode on the production server.

Verified on PROD. Thanks!