| Issue Number | 4949 |
|---|---|
| Summary | [Media] Allow Repeated Downloads of ZIP File on FTP Server |
| Created | 2021-03-02 17:54:58 |
| Issue Type | Improvement |
| Submitted By | Englisch, Volker (NIH/NCI) [C] |
| Assigned To | Englisch, Volker (NIH/NCI) [C] |
| Status | Closed |
| Resolved | 2021-05-06 15:44:45 |
| Resolution | Fixed |
| Path | /home/bkline/backups/jira/ocecdr/issue.285927 |
The software to grab the *.zip file from the FTP server moves the Week_YYYY_ww.zip file from the directory Term_Audio to the directory Audio_Transferred (I don't remember why we are using this extra step). The system is designed to allow moving/copying the *.zip file multiple times when run in TEST mode. However, in LIVE mode, the program fails if the *.zip file about to be moved over already exists in the destination directory.
We want to modify this process and allow multiple runs in LIVE mode. An existing file in the directory Audio_Transferred would be moved out of the way and save with a different file name (appending a time stamp).
The following file has been modified to allow multiple runs in LIVE mode.
This is ready for review on DEV.
I tested this and it seems to be working but with some limitation. No errors are reported. However, a repeat download does not appear to overwrite the content of the previously downloaded zip file with the same name. For example, if I download Week_2020_53.zip which contains CDR 305993_es, I can see this file in the Audio Review Glossary Terms report. If I go back to the file on my computer and remove CDR 305993_es from the Week_2020_53 file and create another zip file, and upload this new zip file (with same name) to the sftp site and download it again - overwriting the earlier Week_2020_53.zip, I expect CDR 305993_es to be removed from the Audio Review Glossary Terms page but that is not what is happening. It looks like once the file is downloaded, it remains on the page.
It appears to me that you are testing a process that is not part of this ticket.
What we are trying to achieve in this ticket is to give you the ability to download a (updated?) *.zip file multiple times from the FTP server to the CDR server in live mode. Previously these multiple copies would only succeed in test mode and looking at the logs I can verify that you had successfully downloaded the zip file Week_2020_53.zip multiple times in live mode. Therefore, considering that this ticket is only dealing with the copy of *.zip files between the FTP and the CDR server, I would think that the requirement has been met.
Moving on to the Glossary Terms Audio Review report, I can see that the file Week_2020_53.zip is listed with a status of Completed. Does this mean you have already loaded the content of the zip file to the database? Also, when looking at the members of this zip file I do see the file you mentioned - 305993_es - being part of the zip file although you said you removed it from that zip file. Maybe we can talk at our meeting tomorrow about additional goals you have in mind and if the audio download program would be the appropriate program to put those in place?
As discussed at our status meeting, the ticket does address the requested changes and doesn't require additional changes. Any changes to the current audio load and review process will be addressed through new Jira tickets if the need arises.
Verified on QA. Thanks!
Closing this ticket and will report if we are not able to confirm this change. Thanks!
Elapsed: 0:00:00.001539