CDR Tickets

Issue Number 4945
Summary Fix links to LOE within glossary pop up window in Pub preview
Created 2021-02-18 10:31:03
Issue Type Improvement
Submitted By Osei-Poku, William (NIH/NCI) [C]
Assigned To Englisch, Volker (NIH/NCI) [C]
Status Closed
Resolved 2021-02-19 11:47:31
Resolution Fixed
Path /home/bkline/backups/jira/ocecdr/issue.285087
Description

Currently, the links within the popups aka modal window that go to the Level of Evidence terms do not work in Pub Preview but they work on Cancer.gov. It would be good to have this working in Pub Preview instead of the current 404 page displayed for users. If this is not possible, then alternatively display a page with a warning message that letting the user know that the link does not work in pub preview. 

Comment entered 2021-02-18 12:50:31 by Englisch, Volker (NIH/NCI) [C]

This is the content provided in ElasticSearch for the definition:
"html": "Ensayo clínico controlado aleatorizado en el que se usa la mortalidad total como un criterio de valoración. Para obtener más información, consultar el sumario <a href="/espanol/publicaciones/pdq/grados-comprobacion/tratamiento">Grados de comprobación científica de los estudios sobre el tratamiento del cáncer en adultos y niños (PDQ®)</a>."
Since the URL doesn't include the hostname for this link the browser will include the current server which is www.cancer.gov on our site and cdr.cancer.gov when running the PublishPreview report.  Only one of those specifies the correct location for the document.

Comment entered 2021-02-19 11:41:47 by Englisch, Volker (NIH/NCI) [C]

I was going through our code trying to identify how we are handling SummaryRefs (or RelatedSummaryRefs) compared to the LOERefs since these should be processed similarly.  It looks like we do include the production domain name when we're creating the URL for the SummaryRefs, therefore I made the filter change to handle the LOERefs the same.

The following filter has been modified:

This change will fix the reported problem and the link will always point to the LOE document on the production server.

Please note, in order to test the change, a Drupal configuration file will need to be temporarily modified so that the glossary API points to the DEV server. William and I will need to coordinate this.  Also, the glossary dictionary will need to be reloaded to ElasticSearch - this is already done.

Comment entered 2021-02-19 11:46:10 by Englisch, Volker (NIH/NCI) [C]

Here is a screenshot of the links on DEV before and after the change:

 

Comment entered 2021-02-25 09:29:05 by Osei-Poku, William (NIH/NCI) [C]

bq. William and I will need to coordinate this.  Also, the glossary dictionary will need to be reloaded to ElasticSearch - this is already done.

Please let me know when you want us to test this. Thanks!

Comment entered 2021-02-25 13:03:30 by Englisch, Volker (NIH/NCI) [C]

Is this something that you would be testing or somebody else on your team?  Since I have to modify a configuration file I want the time that the changes are in place to be as limited as possible.  If you and I can work on this together it shouldn't take longer than 10-15 minutes.

Comment entered 2021-02-25 13:19:29 by Osei-Poku, William (NIH/NCI) [C]

I can test myself. If you like, let's plan to test right after the CDR meeting today.

Comment entered 2021-03-01 17:46:36 by Englisch, Volker (NIH/NCI) [C]

I've copied the filter changes to QA and refreshed the glossary entries.  We can run another round of testing, .

Comment entered 2021-03-04 10:20:37 by Osei-Poku, William (NIH/NCI) [C]

I am available this morning for testing or we can wait after the CDR meeting to test.

Comment entered 2021-03-04 10:45:17 by Englisch, Volker (NIH/NCI) [C]

Let's test after our CDR meeting.  That works better for me.

Comment entered 2021-03-08 13:53:10 by Osei-Poku, William (NIH/NCI) [C]

We tested this on QA last Thursday and it worked as expected. I think it is ready for PROD now.

Comment entered 2021-03-08 14:50:30 by Englisch, Volker (NIH/NCI) [C]

The filter change has been copied to STAGE and PROD.

Please verify on PROD (after the next nightly glossary load) and close this ticket.

Comment entered 2021-03-11 10:32:09 by Osei-Poku, William (NIH/NCI) [C]

Verified on PROD. Thanks!

Attachments
File Name Posted User
404 popup error.PNG 2021-02-18 10:30:56 Osei-Poku, William (NIH/NCI) [C]
popup window LOE link.png 2021-02-18 10:28:48 Osei-Poku, William (NIH/NCI) [C]
Screen Shot 2021-02-19 at 11.32.13 AM.png 2021-02-19 11:44:41 Englisch, Volker (NIH/NCI) [C]
Screen Shot 2021-02-19 at 11.36.33 AM.png 2021-02-19 11:43:41 Englisch, Volker (NIH/NCI) [C]

Elapsed: 0:00:00.001536