CDR Tickets

The GlossaryTerm vendor filter was checking for the "Rejected" term status but it was checking against all translated definitions.  In other words, if one definition existed with an "Approved" or "Pending" status a definition was displayed regardless of its status.

The following filter has been modified to fix the issue:

• CDR616048: Vendor Filter: GlossaryTermName
  https://github.com/NCIOCPL/cdr-server/commit/9dcde88

The filter changes are ready for review on DEV.  When testing please also include glossary terms using the "English Name (en ingles)" display and those with multiple translated term names.

Note:  The CDR has been refreshed yesterday, so the state of the data is close to what's available on PROD.

This appears to be working as expected in pub preview. 

 When testing please also include glossary terms using the "English Name (en ingles)" display and those with multiple translated term names.

I tested with CDR0000689627 on DEV and it displayed correctly with the (en ingles) label but I am not sure exactly what I should be looking for other than checking to see if the (en ingles) is displayed.

The diff reports on QA show that there is still an issue with the output.  It's possible a Spanish term is included in the vendor output if the Spanish name exists but there isn't any definition or the entire definition is within markup.

I will have to make some additional changes to the filter.

I've made additional changes to exclude those terms for which there doesn't exist the definition text (or the entire definition text is in mark-up).  

These changes are ready for review on DEV.

I retested this fix and the display looks good. The blocked definition does not show in PP but I assume you would want us to do more testing with different scenarios and not just to look at terms that have been rejected.

Verified on DEV. Thanks!

We discussed at the status meeting to run a test load on QA but wait until Monday in order to use the latest weekend backup file as the base for the refresh.

The filter changes have been setup on QA after yesterday's refresh of the database.  ~oseipokuw, you can now prepare rejected Genetics terms prior to running a publishing job and glossary dictionary load.

I just realized that you added the dictionary element back into CDR302456, which is the affected definition reported above. I was going to do the same so we can use the same document for testing. I have made it publishable now so it should be good to go. 

I've published the two terms on QA and ran a glossary load.

These two links show the output from the publishing job:
https://cdr-qa.cancer.gov/cgi-bin/cdr/ShowCdrDocument.py?Session=guest&Request=Submit&selection_method=id&doc-id=642015&vtype=exported
[
https://cdr-qa.cancer.gov/cgi-bin/cdr/ShowCdrDocument.py?Session=guest&Request=Submit&selection_method=id&doc-id=302456&vtype=exported]

These two links indicate that the rejected definitions were not created in the genetics dictionary: 
https://webapis-qa.cancer.gov/glossary/v1/Terms/genetics/HealthProfessional/es/642015

[
https://webapis-qa.cancer.gov/glossary/v1/Terms/genetics/HealthProfessional/es/302456]

Testing the non-existence of these terms on Cancer.gov would again require for me to adjust a configuration file to have the QA version of Cancer.gov point to the QA dictionary.

~oseipokuw, please let me know when you would like me copy the modified filter to PROD or if you would like to test once more on QA prior to the copy.

Verified. Please proceed to copy it to PROD. Thanks!

The filter changes have been copied to PROD.  After the next weekend publishing job and glossary dictionary refresh the results can be checked.

We have added the dictionary element back into the term document. It will be published on Friday, after which we can close this ticket. Thanks!

Verified on PROD. Thanks!