| Issue Number | 4852 |
|---|---|
| Summary | [Summaries] Problem with spacing around gene names on QC reports |
| Created | 2020-07-15 16:24:06 |
| Issue Type | Bug |
| Submitted By | Juthe, Robin (NIH/NCI) [E] |
| Assigned To | Englisch, Volker (NIH/NCI) [C] |
| Status | Closed |
| Resolved | 2020-07-20 19:25:43 |
| Resolution | Fixed |
| Path | /home/bkline/backups/jira/ocecdr/issue.266335 |
We have noticed a problem with spacing around gene names on RLSO and B/U QC reports. It seems to have to do with whether the spaces are added within the gene name tag or outside of the tag.
We thought this problem had corrected itself (magically!), but not surprisingly that turns out not to be the case. It seems to be an issue only in marked up text, so once the markup has been accepted, the spacing is OK.
An example on PROD is the Genomics of AML summary module (CDR779362). I will try to recreate this on QA and provide an example there as well.
In the attached screenshot, see the gene name KIT after reference 41. The spacing is correct in the CDR but the QC report displays a missing space.
I had introduced this problem with our last QC report modifications. By trying to remove "empty" span elements I also removed those containing a single, significant space. The filter has been modified. The change won't save the world but it will save the space. 🙂
The following filter has been modified:
CDR434822 :Module: QC Filter Templates - Summary
https://github.com/NCIOCPL/cdr-server/commit/fbf522a
The filter has also been copied to QA and I ran a diff report on all summary QC reports without detecting any differences.
This is ready for review on DEV or QA.
This looks good to me (I think) on QA. I checked several sections including gene names in markup and the spacing looked fine. Ready to go to PROD. Thanks!
Did you also check GeneName in markup next to other elements?
The problem only occurred if you had a GeneName element right next to
a citation or ScientificName element for instance. Something like
<Insertion>This is a special <GeneName>dada</GeneName> name from Volker.</Insertion>
would not display the problem but the following would.
<Insertion>This is a special <Citation>...</Citation> <GeneName>dada</GeneName> name from Volker.</Insertion>
The changes have been copied to STAGE and PROD.
Please verify on PROD and close this ticket.
I did check that. Sorry, just seeing this now. We'll confirm everything looks good on PROD and close this issue. Thank you!
We haven't come across any issues on PROD so far so I believe everything is A-OK. Will reopen if we uncover any problems. Thanks!
| File Name | Posted | User |
|---|---|---|
| QCreport.jpg | 2020-07-15 16:25:36 | Juthe, Robin (NIH/NCI) [E] |
Elapsed: 0:00:00.001869