CDR Tickets

Issue Number 4856
Summary [Summaries] Ambiguous QC Report Error
Created 2020-07-26 21:30:51
Issue Type Bug
Submitted By Juthe, Robin (NIH/NCI) [E]
Assigned To Englisch, Volker (NIH/NCI) [C]
Status Closed
Resolved 2020-07-30 16:55:24
Resolution Fixed
Path /home/bkline/backups/jira/ocecdr/issue.271080
Description

I'm struggling to find out what the error is that's preventing me from generating a B/U QC report for CDR62865 on PROD. 

 

The message reads "filtering error: Publishable version doesn't exist for". That's the end of the message. I'll post a screenshot.

Comment entered 2020-07-26 21:36:33 by Juthe, Robin (NIH/NCI) [E]

Ah, found it. Had empty SummaryFragmentRef tags in the summary. Once I deleted those tags, the QC report ran. 

I'll leave this open for now so we can discuss whether it's possible to improve this error message. 🙂

Comment entered 2020-07-27 11:04:53 by Englisch, Volker (NIH/NCI) [C]

Well, the report did want to give you the CDR-ID for the document it was expecting a publishable version but that ID was missing as well. 

We could possible modify the text string to something like
   "filtering error: Publishable version doesn't exist for document <12345>"
In your case you'd still get
   "filtering error: Publishable version doesn't exist for document <>"
as the output which might make the error a little easier to recognize.

Comment entered 2020-07-30 11:56:36 by Juthe, Robin (NIH/NCI) [E]

I see what you mean.

 

Alternatively, would it be possible to say something like "Empty SummaryFragmentRef tags"?

Comment entered 2020-07-30 16:31:27 by Englisch, Volker (NIH/NCI) [C]

I'm going to combine both messages into:

Publishable version doesn't exist for document (), or empty SummaryRef/SummaryFragmentRef tags

If there is a CDR-ID but the publishable version is missing, the CDR-ID will be displayed within the parenthesis.

Comment entered 2020-07-30 16:55:16 by Englisch, Volker (NIH/NCI) [C]

The following filter has been modified on DEV:

  • CDR335424.xml - Denormalization Filter: Summary

This is ready for review on DEV.  I added an empty SummaryFragmentRef element to CDR62902 - of course.

Comment entered 2020-07-31 20:01:22 by Englisch, Volker (NIH/NCI) [C]

The filter change has been copied to QA.  The Summary QC reports have been diffed and - as expected - no changes were detected.

Please let me know if/when you'd like me to push these changes to STAGE and PROD.

Comment entered 2020-08-06 13:27:01 by Juthe, Robin (NIH/NCI) [E]

This looks good on DEV.

Comment entered 2020-08-06 21:06:52 by Englisch, Volker (NIH/NCI) [C]

The following filter has been copied to PROD and STAGE:

Please verify on PROD and close this ticket.

Comment entered 2020-09-10 13:27:57 by Juthe, Robin (NIH/NCI) [E]

Closing this ticket. I'll reopen if we run into the problem again.

Attachments
File Name Posted User
QC report error.png 2020-07-26 21:31:04 Juthe, Robin (NIH/NCI) [E]

Elapsed: 0:00:00.001987