Issue Number | 4850 |
---|---|
Summary | [DIS] Modify vendor filter to strip out new FDA Approved attributes |
Created | 2020-07-07 16:39:06 |
Issue Type | Improvement |
Submitted By | Osei-Poku, William (NIH/NCI) [C] |
Assigned To | Englisch, Volker (NIH/NCI) [C] |
Status | Closed |
Resolved | 2020-07-07 17:05:17 |
Resolution | Fixed |
Path | /home/bkline/backups/jira/ocecdr/issue.265658 |
Please modify the vendor filter to strip out the two new FDAApproved attributes added recently in OCECDR-4689.
Adding our offline communication below:
---— From: Englisch, Volker
(NIH/NCI) [C] <volker@mail.nih.gov> Sent: Tuesday, July 7, 2020
4:12 PM To: Osei-Poku, William <William.Osei-Poku@icf.com>; Kline,
Robert (NCI) <bkline@rksystems.com> Subject: Re: [PROD] Status and
Error Report for Weekly PublishingOriginal Message
Yes, that change seems to be the reason why the DIS is now failing.
Could you please create a ticket to update the vendor filter?
Thanks,
Volker
Volker Englisch
NCI OCPL – Office of Communications & Public Liaison
Contractor: publicis sapient
NCI: 240-276-6583
On 7/7/20, 3:44 PM, "Osei-Poku, William" <William.Osei-Poku@icf.com> wrote:
Hi Volker,.
It looks like we only started using them after modifications in OCECDR-4689. I think these are only meant for QC reports so option one should be good.
Thanks,
William
------Original Message
From: Englisch, Volker (NIH/NCI) [C] <volker@mail.nih.gov>
Sent: Tuesday, July 7, 2020 2:58 PM
To: Osei-Poku, William <William.Osei-Poku@icf.com>; Kline, Robert (NCI) <bkline@rksystems.com>
Subject: Re: [PROD] Status and Error Report for Weekly Publishing
Hi William,
It appears that we have never before used an attribute for the element FDAApproved. These two attributes, Accelerated and ApprovedInChildren, are allowed in the schema but not in the DTD that validates the vendor output.
We could:
- modify the vendor filters to strip out these attributes from the vendor output or
- modify the DTD to allow the attributes to be passed on to the vendor output.
Thanks,
Volker
Volker Englisch
NCI OCPL – Office of Communications & Public Liaison
Contractor: publicis sapient
NCI: 240-276-6583
On 7/6/20, 1:20 PM, "Osei-Poku, William" <william.osei-poku@icf.com> wrote:
Hi Bob & Volker,
Any ideas what the error messages for the following DISs mean? I think I know why the GTN failed but not the DISs,
Failures
ID Type Details
44440 GlossaryTermName Unable to resolve uri 'CDR0000634812/lastp'
764622 DrugInformationSummary ['No declaration for attribute Accelerated of element FDAApproved', 'No declaration for attribute ApprovedInChildren of element FDAApproved']
787910 DrugInformationSummary ['No declaration for attribute Accelerated of element FDAApproved', 'No declaration for attribute ApprovedInChildren of element FDAApproved']
Thanks,
William
------Original Message
From: NCIPDQoperator@mail.nih.gov <NCIPDQoperator@mail.nih.gov>
Sent: Friday, July 3, 2020 4:48 PM
To: amiddles@mail.nih.gov; bkline@rksystems.com; christina.norwood@nih.gov; hansenlm@mail.nih.gov; Barnstead, Mary <Mary.Barnstead@icf.com>; mbeckwit@mail.nih.gov; ncipdqoperator@mail.nih.gov; Yu, Ning <Ning.Yu@icf.com>; reyesk@mail.nih.gov; robin.juthe@nih.gov; robin@mail.nih.gov; sershenca@mail.nih.gov; volker@mail.nih.gov; vshields@mail.nih.gov; Osei-Poku, William <William.Osei-Poku@icf.com>
Subject: [PROD] Status and Error Report for Weekly Publishing
Status and Error reports for the latest weekly publishing/push jobs:
Publishing Job Report:
https://cdr.cancer.gov/cgi-bin/cdr/PubStatus.py?id=18150
Push Job Report:
I've made the filter changes on DEV. If you want to prepare one or two documents on QA I can go ahead and run the before/after diff reports to confirm.
These two documents are ready for testing on DEV. Thanks!
Capecitabine 496354
Docetaxel 496383
Oh, I thought you'd prepare a couple documents on QA to run a diff report.
I went ahead and prepared a few documents on QA, ran the before and after diff report with the expected result: All documents are identical and those DIS documents containing the new attributes are again valid.
The following filter has been updated:
CDR505580 - Vendor Filter: DrugInfoSummary
https://github.com/NCIOCPL/cdr-server/commit/5ab7fe06
The filter changes have been copied to STAGE and PROD.
Please verify and close this ticket.
Verified on PROD. Thanks!
Elapsed: 0:00:00.001816