CDR Tickets

Volker will investigate. It appears that the web site is already displaying these alternate names, and showing them too many times, duplicating the same names.

I don't know what we were looking at during the meeting but when I look at the document on Cancer.gov I don't see those multiple displays of the names anymore.

Adding the alternate Spanish terms will not be as simple as just adding the terms to the list of Also called list because we're not just adding a comma delimited list.  If we're adding the alternate terms we will need to know if there already exist 1, 2, or more of the Also called term and adjust the text accordingly:

• Adding alternate1 to the text Also called spanish1 and spanish2. would require replacing the and and the period at the end of the sentence to get something like Also called spanish1, spanish2, and alternate1.

• Similarily, adding alternate1 and alternate2 to the text Also called spanish1, spanish2, and spanish3 would require text changes to achieve Also called spanish1, spanish2, spanish3, alternate1, and alternate2.

I will have to modify the way we're currently creating the Also called text in order to integrate the Spanish alternate names but I believe this should still be able to be done with a filter change.

> I don't know what we were looking at during the meeting

I do: https://www.cancer.gov/espanol/publicaciones/diccionario/def/mastectomia-parcial

I've looked at the partial mastectomy term again and now I'm a little confused.  We have seen yesterday that two issues currently exist with the term when looking on Cancer.gov:

• multiple Also called terms are displayed including those that are listed as alternates

• many terms are displayed multiple times

The second issue is a bug in my filter which I can easily fix.  

My confusion comes from the title of this ticket Display Spanish synonyms in glossary term definitions.  It implies that the alternate names aren't displayed.

Are there alternate names that are currently not displayed or is the goal of this ticket to correctly display these alternate names instead of displaying some of them multiple times?

From what I understand, the alternates were not displayed in the definitions as also calleds so it was a surprise to me to see that they are displayed. There is also another problem with where the synonyms are displayed. If you look at the CDR0000045758 which is the record for lumpectomía, you will find that tumorectomía and tilectomía have been added as alternates and yet, they don't display as also-called in the definition for lumpectomía.

https://www.cancer.gov/espanol/publicaciones/diccionario/def/lumpectomia

Rather, we see that the alternates have been added to CDR0000045105  - mastectomía parcial

https://www.cancer.gov/espanol/publicaciones/diccionario/def/mastectomia-parcial

which doesn't have the alternates. The correct display is to have the alternates display as also-calleds in the GTN they are found in. In this case, CDR0000045758.

I've updated CDR45105 (mastectomía parcial) and CDR45758 (lumpectomía) on www-red-dev.cancer.gov to remove the duplicates.

I see the problem and it's something that can be fixed in the SQL query selecting the alternate names.  I have two questions:

• Do other types of names exist or are there only 'alternate' types?  Might there be other types in the future?

• Do 'alternate' names also exist for the English terms or is this purely a Spanish feature?

We're currently using one SQL query for both, the English and the Spanish also-called names but I may need to break this in two depending on your answers.

Another question:

Would you know of a glossary term for which an also called exists for both, the English and the Spanish version or could we create such a document on DEV for testing?

Verified that the duplicates have been removed. Thanks!

• Do other types of names exist or are there only 'alternate' types?  Might there be other types in the future? {quote}

No other types exist. Only 'alternate'. Also, it is possible that in the future, there might be other types but there are no immediate plans for that. 

• Do 'alternate' names also exist for the English terms or is this purely a Spanish feature?

Here are three examples:

CDR 575436 

CDR 44418 

CDR 559453

The filter to produce the output for the Also-called English terms was setup so that the term itself would not be repeated on its glossary page.  This had the effect that the alternate TermTypes were excluded on the pages on which those were supposed to be displayed and were displayed multiple times on all other related glossary pages.

The SQL query used by this filter has been updated to display both, the English Also called and the Spanish alternates properly.  The following filter has been updated on QA:

• CDR616048: Vendor Filter: GlossaryTermName
  https://github.com/NCIOCPL/cdr-server/commit/b8c1ec7

Please review on QA (DEV is currently not working).

Let's try this again.  I have reworked the SQL query to only display the alternate names on its glossary page as we discussed on Thursday.

• CDR616048: Vendor Filter: GlossaryTermName
  https://github.com/NCIOCPL/cdr-server/commit/0bb6cba

Please review on QA.

Verified on QA. Thank you!

The filter has been updated on STAGE.

Please review on STAGE and let me know if it's ready to copy to PROD.

Verified on STAGE. Thanks!

Did you want me to copy this change to PROD?

Yes, please.

The modified filter has been updated on PROD.

Please verify and close this ticket.

Verified on PROD. Thank you!