Issue Number | 4527 |
---|---|
Summary | [Media] Add TranslationOf element to cloned documents |
Created | 2018-09-20 13:08:23 |
Issue Type | Inquiry |
Submitted By | Osei-Poku, William (NIH/NCI) [C] |
Assigned To | Englisch, Volker (NIH/NCI) [C] |
Status | Closed |
Resolved | 2018-09-25 13:52:03 |
Resolution | Fixed |
Path | /home/bkline/backups/jira/ocecdr/issue.233375 |
When a media document is cloned, would it be possible to add the TranslationOf element by default? Also, would it be possible to programmatically create the link to the English document as part of the clone command?
I've never cloned a document: Do you only clone Media documents?
It looks like the only other doc type we close besides Media is the Supplementary Info Doc type.
We've never used this element before for Media documents. Is that correct? If I'm trying to link to another document I'm getting a message indicating No links permitted from this element.
This ticket is a duplicate of OCECDR-4503. Since you've started work on this ticket, I will update it so that it captures all the requirements.
We always use it for Media docs and Supplementary Info documents. The "C" icon (please see attached screenshot) is what creates the cloned document. There is really no href link between the original document and the cloned document. It just creates an unsaved template or version with text from the original document.
The schema allows Comment elements after the
TranslationOf element. This means the TranslationOf
element will need to be placed before the Comment unless you
don't want to copy the Comment which really belongs to the
original document.
Should the Comment be included in the cloned document?
The Comment element can be excluded from the cloned document.
This has been implemented on DEV. Please review the changes.
For my information: The changes are in the local branch [ cdr4527-clone a5ec9a3 ]
Can you please display the Media Title instead of the CDR ID? This link is created correctly but the Media Title does not show in the TranslationOf field.
The text of the TranslationOf element will be overwritten with the MediaTitle text as soon as the document is saved. I could have left the text blank but opted for a placeholder I had already extracted from the original - the CDR-ID.
It would actually be better to have the title in the field since we have to go to the English and copy the title and then use it to create the link. So, please place the title in the TranslationOf field, I will let users know to create the link before saving the document.
I will add the title for you but I'm not understanding what you are saying.
I will let users know to create the link before saving the document.
Isn't this ticket asking to create the link as part of the macro? There is nothing the user would need to do in order to create the link after cloning the English document except for saving the cloned document and, of course, replacing the to-be-translated fields.
I must have misunderstood you then about the overwriting of the text of the TranslationOf field. I thought you meant the text will no longer be there when the document is saved. So, the user would have to 'recreate' the link by copying the media title from the original document, typing CTRL + Enter, enter the text and retrieve the original document to create the link. If we don't have to do that and all we need to do is to save the document, then there is nothing else to be worried about.
The CDR-ID of the English document has been replaced with the MediaTitle in the new TranslationOf element.
Please review on DEV.
Perfect. Verified on DEV. Ready for QA.
This ticket will likely be part of Joule, so I'll keep it on DEV for now until we're ready for Joule.
Manual step: We will need to update the linking table to allow the new element.
The file is modified in the branch [cdr4527-clone]:
The changes have been merged into Joule
This has been verified on DEV (and QA already). Thanks!
This new feature appears to have been wiped out from DEV. Could you please re-install it ? Thanks!
This new feature has been merged into the Joule branch. If I were to restore the macro file from Joule you wouldn't be able to verify the cloning changes implemented for OCECDR-4600.
Once OCECDR-4600 has been confirmed I'll merge the changes into Joule which then will include the modifications for both tickets.
Verified on DEV. Thanks!
Verified on QA. Thanks!
Verified on PROD. Thanks!
File Name | Posted | User |
---|---|---|
Clone.JPG | 2018-09-24 10:12:31 | Osei-Poku, William (NIH/NCI) [C] |
Elapsed: 0:00:00.000765