CDR Tickets

Issue Number 4527
Summary [Media] Add TranslationOf element to cloned documents
Created 2018-09-20 13:08:23
Issue Type Inquiry
Submitted By Osei-Poku, William (NIH/NCI) [C]
Assigned To Englisch, Volker (NIH/NCI) [C]
Status Closed
Resolved 2018-09-25 13:52:03
Resolution Fixed
Path /home/bkline/backups/jira/ocecdr/issue.233375
Description

When a media document is cloned, would it be possible to add the TranslationOf element by default? Also, would it be possible to programmatically create the link to the English document as part of the clone command?

Comment entered 2018-09-20 13:44:03 by Englisch, Volker (NIH/NCI) [C]

I've never cloned a document: Do you only clone Media documents?

Comment entered 2018-09-20 13:53:05 by Osei-Poku, William (NIH/NCI) [C]

It looks like the only other doc type we close besides Media is the Supplementary Info Doc type.

Comment entered 2018-09-21 18:57:35 by Englisch, Volker (NIH/NCI) [C]

We've never used this element before for Media documents. Is that correct? If I'm trying to link to another document I'm getting a message indicating No links permitted from this element.

Comment entered 2018-09-24 09:25:51 by Osei-Poku, William (NIH/NCI) [C]

This ticket is a duplicate of OCECDR-4503. Since you've started work on this ticket, I will update it so that it captures all the requirements.

Comment entered 2018-09-24 10:12:36 by Osei-Poku, William (NIH/NCI) [C]

We always use it for Media docs and Supplementary Info documents. The "C" icon (please see attached screenshot) is what creates the cloned document. There is really no href link between the original document and the cloned document. It just creates an unsaved template or version with text from the original document.

Comment entered 2018-09-24 11:09:08 by Englisch, Volker (NIH/NCI) [C]

The schema allows Comment elements after the TranslationOf element. This means the TranslationOf element will need to be placed before the Comment unless you don't want to copy the Comment which really belongs to the original document.
Should the Comment be included in the cloned document?

Comment entered 2018-09-24 11:19:52 by Osei-Poku, William (NIH/NCI) [C]

The Comment element can be excluded from the cloned document.

Comment entered 2018-09-25 13:51:50 by Englisch, Volker (NIH/NCI) [C]

This has been implemented on DEV. Please review the changes.

For my information: The changes are in the local branch [ cdr4527-clone a5ec9a3 ]

Comment entered 2018-09-25 20:55:03 by Osei-Poku, William (NIH/NCI) [C]

Can you please display the Media Title instead of the CDR ID? This link is created correctly but the Media Title does not show in the TranslationOf field.

Comment entered 2018-09-26 10:30:04 by Englisch, Volker (NIH/NCI) [C]

The text of the TranslationOf element will be overwritten with the MediaTitle text as soon as the document is saved. I could have left the text blank but opted for a placeholder I had already extracted from the original - the CDR-ID.

Comment entered 2018-09-26 11:04:20 by Osei-Poku, William (NIH/NCI) [C]

It would actually be better to have the title in the field since we have to go to the English and copy the title and then use it to create the link. So, please place the title in the TranslationOf field, I will let users know to create the link before saving the document.

Comment entered 2018-09-26 11:27:49 by Englisch, Volker (NIH/NCI) [C]

I will add the title for you but I'm not understanding what you are saying.

I will let users know to create the link before saving the document.

Isn't this ticket asking to create the link as part of the macro? There is nothing the user would need to do in order to create the link after cloning the English document except for saving the cloned document and, of course, replacing the to-be-translated fields.

Comment entered 2018-09-26 12:05:08 by Osei-Poku, William (NIH/NCI) [C]

I must have misunderstood you then about the overwriting of the text of the TranslationOf field. I thought you meant the text will no longer be there when the document is saved. So, the user would have to 'recreate' the link by copying the media title from the original document, typing CTRL + Enter, enter the text and retrieve the original document to create the link. If we don't have to do that and all we need to do is to save the document, then there is nothing else to be worried about.

Comment entered 2018-09-26 13:45:47 by Englisch, Volker (NIH/NCI) [C]

The CDR-ID of the English document has been replaced with the MediaTitle in the new TranslationOf element.

Please review on DEV.

Comment entered 2018-09-26 16:58:27 by Osei-Poku, William (NIH/NCI) [C]

Perfect. Verified on DEV. Ready for QA.

Comment entered 2018-09-27 10:59:32 by Englisch, Volker (NIH/NCI) [C]

This ticket will likely be part of Joule, so I'll keep it on DEV for now until we're ready for Joule.

Comment entered 2018-09-27 11:00:54 by Englisch, Volker (NIH/NCI) [C]

Manual step: We will need to update the linking table to allow the new element.

Comment entered 2019-03-28 18:47:45 by Englisch, Volker (NIH/NCI) [C]

The file is modified in the branch [cdr4527-clone]:

Comment entered 2019-06-20 11:12:43 by Englisch, Volker (NIH/NCI) [C]
Comment entered 2019-06-21 08:33:12 by Osei-Poku, William (NIH/NCI) [C]

This has been verified on DEV (and QA already). Thanks!

Comment entered 2019-06-27 10:55:36 by Osei-Poku, William (NIH/NCI) [C]

This new feature appears to have been wiped out from DEV. Could you please re-install it ? Thanks!

Comment entered 2019-06-27 13:14:37 by Englisch, Volker (NIH/NCI) [C]

This new feature has been merged into the Joule branch.  If I were to restore the macro file from Joule you wouldn't be able to verify the cloning changes implemented for OCECDR-4600.

Once OCECDR-4600 has been confirmed I'll merge the changes into Joule which then will include the modifications for both tickets.

Comment entered 2019-07-10 15:48:21 by Osei-Poku, William (NIH/NCI) [C]

Verified on DEV. Thanks!

Comment entered 2019-08-05 16:07:36 by Osei-Poku, William (NIH/NCI) [C]

Verified on QA. Thanks!

Comment entered 2019-09-09 09:32:58 by Osei-Poku, William (NIH/NCI) [C]

Verified on PROD. Thanks!

Attachments
File Name Posted User
Clone.JPG 2018-09-24 10:12:31 Osei-Poku, William (NIH/NCI) [C]

Elapsed: 0:00:00.000765