CDR Tickets

Issue Number 4525
Summary [DIS] Showing markup in QC report
Created 2018-09-19 14:11:51
Issue Type Improvement
Submitted By Osei-Poku, William (NIH/NCI) [C]
Assigned To Englisch, Volker (NIH/NCI) [C]
Status Closed
Resolved 2019-02-21 18:34:01
Resolution Fixed
Path /home/bkline/backups/jira/ocecdr/issue.233321
Description

When some elements are marked up in a DIS document, the markups are not displayed in the DIS QC report. Please modify the QC report so that changes are displayed when marked up.

1. Approved Indications
2. Entry Date

Comment entered 2018-09-19 16:11:28 by Englisch, Volker (NIH/NCI) [C]

Could you please include the CDR-ID of a sample document where I can see the problem?

Comment entered 2018-09-19 16:37:04 by Osei-Poku, William (NIH/NCI) [C]

CDR0000791122 on DEV. I have marked up one Approved Indication and Entry Date.

Comment entered 2018-09-20 18:53:01 by Englisch, Volker (NIH/NCI) [C]

The DIS QC reports were never intended to display any of the block level elements (i.e. the _DrugInfoMetaData information) with markup. If I remember correctly when we created the QC reports for DIS we decided to re-use the SummarySection element along with all of it's markup display.
Before rewriting the denormalization and revision level markup filters we should decide if the listed two elements are the only ones that should be allowed to be displayed with markup or if we want to be able to mark up other elements as well, i.e. DateLastModified, Description, DrugInfoType, etc. and if we want to allow proposed, approved, published markup and how to have the markup display based on the Source attribute.

Comment entered 2018-10-04 10:42:45 by Osei-Poku, William (NIH/NCI) [C]

We are reviewing the DIS schema to see which other DIS elements to be added to the QC report. I will provide the list when we are done.

Comment entered 2018-10-23 16:52:13 by Osei-Poku, William (NIH/NCI) [C]

We've reviewed the schema and the two elements are the only ones that need to be have markup applied (in addition to what currently shows up in markup). Also, allow the different revision level markup as well (proposed, approved, and publish).

Comment entered 2019-02-21 18:32:04 by Englisch, Volker (NIH/NCI) [C]

The following filter has been modified to add markup for these additional elements:

  • CDR0000486311.xml: DrugInformationSummary QC Report Filter

This is ready for review on DEV.

The changes have been pushed to github using branch cdr4525-DISmarkup.

Comment entered 2019-02-22 14:04:40 by Osei-Poku, William (NIH/NCI) [C]

Verified on DEV. Thank you!

Comment entered 2019-02-22 19:09:01 by Englisch, Volker (NIH/NCI) [C]

The filter has been copied to QA and STAGE.

Comment entered 2019-02-28 12:15:50 by Osei-Poku, William (NIH/NCI) [C]

Verified on STAGE. Thanks!

Comment entered 2019-03-01 19:09:36 by Englisch, Volker (NIH/NCI) [C]

The following filter has been copied to PROD:

Please verify on PROD.

Comment entered 2019-03-04 16:53:02 by Englisch, Volker (NIH/NCI) [C]

Oops!
I was testing this filter change and remembered that this is actually a two-part ticket:

I forgot the second part because it lives in a different repository.
The QCReport.py has to be copied to production by CBIIT which makes this ticket a Joule ticket.

Comment entered 2019-06-20 17:01:26 by Englisch, Volker (NIH/NCI) [C]

The filter change is already in production, the QcReport change has been merged into Joule:
https://github.com/NCIOCPL/cdr-admin/commit/98aef1ab

Comment entered 2019-07-10 11:46:25 by Osei-Poku, William (NIH/NCI) [C]

Verified on DEV. Thanks!

Comment entered 2019-08-05 13:35:35 by Osei-Poku, William (NIH/NCI) [C]

Verified on QA. Thanks!

Comment entered 2019-09-09 13:51:02 by Osei-Poku, William (NIH/NCI) [C]

Verified on PROD. Thanks!

Elapsed: 0:00:00.001333