| Issue Number | 4531 |
|---|---|
| Summary | Remove duplicate Insertion tags |
| Created | 2018-09-27 12:19:24 |
| Issue Type | Bug |
| Submitted By | Osei-Poku, William (NIH/NCI) [C] |
| Assigned To | Englisch, Volker (NIH/NCI) [C] |
| Status | Closed |
| Resolved | 2019-08-05 13:40:56 |
| Resolution | Fixed |
| Path | /home/bkline/backups/jira/ocecdr/issue.233689 |
When an Insertion element is added from the the Elements List, it is duplicated. This appears to happen when no you attempt to add the element without selecting another element or text before selecting the Insertion element.
Do you know if this started happening with a recent CDR release? I was under the impression the double-insert of the markup tags when double-clicking was related to the last XMetaL upgrade.
Anyway, after taking a quick look at some of the other inline elements it appears that the same behavior is showing up not only for the Insertion/Deletion elements. Elements like GeneName, ForeignWord, or Emphasis are acting the same.
This appears to be a known issue for quite a long time.
Finding the bug: 5 hours
Fixing the bug: 5 seconds
Getting it done before the weekend: Priceless! :-)
I believe I have identified and fixed the problem that caused inline elements to be inserted twice. There was a bug in the macro On_Application_ElementList_Insert. This is a macro that is used for the ProcessingStatus of the GlossaryTermConcept and GlossaryTermName documents. Therefore please make sure to take a look at these two document types as well!
As a side benefit, I was able to "link" the Bold and Italic buttons at the top of the menus to our Strong and Emphasis elements and users are now able to toggle italics and bold using these buttons (see attached image).
The changes are ready for review on DEV.
The following files have been updated in github (branch cdr4531-duptags):
The modified files have been merged into Joule:
https://github.com/NCIOCPL/cdr-client/commit/9ba87934
Could you please re-install the changes? It appears they have been deleted.
Same response as my comment for OCECDR-4527. Once ticket OCECDR-4600 has been verified I'll restore the version of Joule which then will contain the changes for all three requested macro changes.
OCECDR-4600 has been verified. Please reinstall this change for testing. Thanks!
The current Joule version of the macro has been installed on DEV.
(... and the RefreshManifest has been run, too.)
Verified on DEV. Thanks!
It doesn't look like this has been installed on QA. I am getting duplicate insertion tags.
I'll take a look to see what's going on.
~oseipokuw, could you
please tell me the steps you're following to create the duplicate
insertion tags?
I tried on QA and I'm getting single insertion tags. I've tried both, to
highlight text and then create Insertion tags from the CDR
Styles menu as well as double-click from the Element List
and I was doing the same without highlighting text first but creating
empty Insertion tags.
I am getting the duplicate tags when double-clicking on the Insertion tags from the element list. I have logged out and logged back in and still getting the duplicate tags. Using the Insertion tags from the CDR Styles does not duplicate the tags.
Could you try to connect to DEV (or PROD) and back to QA? I'm wondering if your client files haven't been updated since the update on QA.
I will do the same on my machine.
I switched to STAGE, opened a summary, place the cursor inside a Para
element (without highlighting text), and double-click the Insertion
element from the Element List. I confirmed the Insertion tag
was inserted twice.
I then repeated the same process on QA and the Insertion tag was
inserted correctly (once).
We should ask another user to try to see which behavior is the common
one.
Looks like it works in Summaries but not in Glossary Terms after logging into PROD and back into QA.
It worked for me in summaries but not in Glossary Terms.
Ahh! Good to know there is an easy explanation.
I had assumed this was only a Summary issue and did not make any changes
affecting Glossaries. Is doesn't say in your description that this
problem was limited to Summaries but that's what we had looked at while
testing on DEV. Obviously, the Glossaries hadn't been tested on DEV or
we would have seen this issue earlier. The Insertion/Deletion tags are
still duplicated on DEV at this point.
I suggest to enter a new ticket for Kepler to address this issue for
Glossaries as a next step.
Okay. Sounds good. Thanks!
Verified on QA. Thanks!
Verified on PROD. Thanks!
| File Name | Posted | User |
|---|---|---|
| BoldItalic.png | 2018-10-12 15:49:19 | Englisch, Volker (NIH/NCI) [C] |
Elapsed: 0:00:00.001495