CDR Tickets

Issue Number 4424
Summary [Summary] Translation job queue not sorting
Created 2018-02-20 15:46:29
Issue Type Bug
Submitted By Osei-Poku, William (NIH/NCI) [C]
Assigned To Kline, Bob (NIH/NCI) [C]
Status Closed
Resolved 2018-04-06 08:59:06
Resolution Fixed
Path /home/bkline/backups/jira/ocecdr/issue.221463
Description

The translation job queue and the translation job workflow report are not sorting on PROD as they should be, using the translation status. They sort fine on QA though .

Comment entered 2018-02-28 10:43:19 by Kline, Bob (NIH/NCI) [C]

Actually, it's random, and pure coincidence that the queue on QA looks better than on PROD (but still not perfect):

This is not a release-independent change, so you'd need to put it in Hawking (or a later release) to have the sort order be deterministic.

Comment entered 2018-03-08 06:12:00 by Kline, Bob (NIH/NCI) [C]

Installed on QA.

https://github.com/NCIOCPL/cdr-admin/commit/58fc387b

Comment entered 2018-03-08 11:46:39 by Osei-Poku, William (NIH/NCI) [C]

Verified on QA. Thanks!

Comment entered 2018-03-15 12:30:40 by Osei-Poku, William (NIH/NCI) [C]

I was re-testing this and noticed that the Translation Workflow Report does not appear to sort correctly. When I run the report with 2017-12-01/2018-03-15 start and end dates and leave all defaults as is, the first summary listed has a "Translation Status" of "Implement Changes from Peer-Review" instead of starting with the "Ready for Translation".

Comment entered 2018-03-15 16:17:14 by Kline, Bob (NIH/NCI) [C]

Try it again (on QA). The report was sorting the states alphabetically.

https://github.com/NCIOCPL/cdr-admin/commit/9de77141

Comment entered 2018-03-20 13:37:26 by Osei-Poku, William (NIH/NCI) [C]

Verified on QA. Thanks!

Comment entered 2018-04-05 16:16:03 by Osei-Poku, William (NIH/NCI) [C]

Please proceed to display all the text in the job history report without truncating the comments. Thanks!

Comment entered 2018-04-06 08:59:06 by Kline, Bob (NIH/NCI) [C]

I have adopted a slightly more flexible approach to the comment display, allowing you to control whether comments are displayed in full or truncated for either flavor (current or historical) of the report. This is on DEV. If you prefer, I will switch to the less flexible approach, and always truncate comments for the current jobs report and always display them in full for the historical report. After you have let me know your preference I'll deploy to QA.

Comment entered 2018-04-10 14:35:55 by Kline, Bob (NIH/NCI) [C]

I think you meant your previous comment for OCECDR-4241, . In any case, I'm still waiting for feedback on my previous comment.

Comment entered 2018-04-11 13:19:16 by Osei-Poku, William (NIH/NCI) [C]

That is right. Sorry about that.

Comment entered 2018-04-11 15:10:06 by Osei-Poku, William (NIH/NCI) [C]

Verified on QA. Thanks!

Comment entered 2018-05-09 15:51:07 by Osei-Poku, William (NIH/NCI) [C]

Verified on PROD. Thanks

Attachments
File Name Posted User
Screen Shot 2018-02-28 at 10.38.14 AM.png 2018-02-28 10:39:07 Kline, Bob (NIH/NCI) [C]

Elapsed: 0:00:00.001796