| Issue Number | 4423 |
|---|---|
| Summary | [Summary] Unable to run QC reports for summaries without a publishable version |
| Created | 2018-02-20 15:17:09 |
| Issue Type | Improvement |
| Submitted By | Osei-Poku, William (NIH/NCI) [C] |
| Assigned To | Englisch, Volker (NIH/NCI) [C] |
| Status | Closed |
| Resolved | 2018-02-28 15:15:26 |
| Resolution | Fixed |
| Path | /home/bkline/backups/jira/ocecdr/issue.221455 |
We are not able to run QC reports (BU and RLSO) for summaries that
have no publishable versions.
Here are some sample documents. 785664 783592 788182
Error message:
filtering error: Unable to resolve uri u'CDR0000788182/lastp'
Could you create a sample document on DEV?
In the meantime, would the QC QD report be enough to get by?
We can use CDR0000774170 on DEV. It is coming up with the same error message. Yes, we are using the QD report for now but definitely prefer to have the main reports working as soon as possible.
I am not sure if this additional information will be helpful but when you run the RLSO report and select both "With approved attribute" and "With proposed attribute", for summaries that have publishable versions, you get the same error message.
Tagging ~juther
The additional information doesn't help but it's also not hurting. :-)
The problem is a bug in Gauss. Gauss currently doesn't allow a SummaryFragmentRef in the document pointing to itself as long as the document doesn't have a publishable version.
Then it looks like the new information is actually a different bug since in this case, it is happening to documents that have publishable versions as well. Should I create a new ticket or you will take care of it in this ticket?
If it's a new bug I'd prefer a new ticket but if you give me the CDR-ID I could take a look to see if the new problem is related.
62792 - That is the CDR ID. The error message is the same except that in this case, it is happening even in cases where there is a publishable version of the document.
Adding ~bkline as a watcher.
There appears to be a bug in the Gauss code when the result of the function to identify the latest publishable version of a document
cdrutil:/get-pv-numdoes not return the value 0 (zero) when no publishable version exists.
I've updated the filter code to work around this problem. The following filter has been modified:
CDR335424: Denormalization Filter: Summary
This is ready for review on DEV.
The filter is located in branch [cdr4423-qcpv 33e36b].
The problem related to CDR62792 is related to the ticket OCECDR-4384 (Citations without publishable version). The citation CDR792371 fails to be included because a publishable version doesn't exist.
You were right, ~oseipokuw. This is another problem but there is no need to add another ticket since the issue has already been reported.
It could be argued that None (or an empty value) is a more appropriate answer to the question "what's the version number of the latest publishable version for this document" than zero would be when the document has no publishable versions. Just sayin'. :-)
I actually agree with you but the function was originally setup to return an integer value and that's what the filters are expecting. If we want to leave the function as is we should create a ticket to adjust any filter using get-pv-num accordingly.
CDR335424: Denormalization Filter: Summary
This is ready for review on DEV.The filter is located in branch [cdr4423-qcpv 33e36b].
Verified on DEV. It seems to be working as expected. Thanks!
Verified changes on QA. Please promote to PROD. Thanks!
The filter change has been copied to STAGE and PROD.
Please verify and close this ticket.
Verified on PROD. Thank you, ~volker
Elapsed: 0:00:00.001767