| Issue Number | 4358 |
|---|---|
| Summary | [Media] Linking unpublishable media docs to summaries |
| Created | 2018-01-02 17:01:53 |
| Issue Type | Bug |
| Submitted By | Osei-Poku, William (NIH/NCI) [C] |
| Assigned To | Englisch, Volker (NIH/NCI) [C] |
| Status | Closed |
| Resolved | 2018-07-17 18:00:22 |
| Resolution | Fixed |
| Path | /home/bkline/backups/jira/ocecdr/issue.219193 |
It appears there has been a recent change on PROD which prevents us from getting QC reports when a linked media doc in a summary does not have a publishable version. We used to be able to do link unpublishable media docs in the past. I have attached the validation message from XMetal and below is the error message from running QC reports.
<Errors> <Err>XSLT error: code: 61 msgtype:error code:61 module:Sablotron URI:cdr:CDR0000791732/lastp node:attribute 'encoding' msg:could not open document 'cdr:CDR0000791733/lastp' </Err> </Errors>
Just like OCECDR-4339 , the only reason we link media docs that are not publishable to summaries is for the them to display in QC reports for the Peds board and since we have not been told to stop doing that, the report may have to be fixed so that it can display images that are not publishable.
Moved this to the Hawking queue. Please feel free to remove it if it doesn't belong.
~oseipokuw, are we
talking about the Media QC report or the summary RS/BU reports
here?
Is there a sample media document on DEV I could use?
Its about the summaries RS/BU reports.
In ticket OCECDR-4335 we have made the change to only pick up
publishable versions of Media documents because marked-up caption text
got published because it was versioned.
This request would revert the change we had put in place in
December.
I will hold off to make these changes until we're able to discuss.
If we're going to revert the earlier change this would be a release independent change. I'm therefore moving this ticket out of hawking.
Decided in the status meeting to add a new parameter to the denormalization filter indicating whether it is acceptable to process links to unpublishable images. The default will be "don't allow."
~oseipokuw, I wanted to make it clear that we're referring to unpublishable versions of images, right? We're trying to select between a publishable version and a non-publishable version of an image and not between a publishable version and the current working document, which may or may not have been versioned.
The following filters and programs have been updated:
QcReport.py
CDR339576.xml - Module: InLine Markup Formatter
CDR410709.xml - Module: Multimedia Denormalization
These are in my local repository [ cdr4358-media ].
This is ready for review on DEV. I've used CDR62902 as a sample document.
~oseipokuw, this is ready for testing on DEV.
Is there supposed to be an option in the report interface to choose which one you want? I don't seem to see it on DEV.
Is there supposed to be an option in the report interface to choose which one you want? I don't seem to see it on DEV.
Yes, there is an option to choose. Since this option only makes sense when displaying images it's only displayed when the Display Images checkbox has been selected. The ellipses has been used at the end of the label to indicate the additional hidden options.
Got it. Thanks!
Verified on DEV. Please install on QA. Thanks!
The changes have been copied to QA for review.
The branch has been moved to github:
Verified on QA. Ready for PROD. Thanks!
~oseipokuw, while I was comparing the changes with PROD I noticed that some previous changes had been removed. I restored those changes and updated the filters on DEV and QA. Therefore, I would like you to take a quick look on QA again to ensure everything is still working as expected.
These are the latest updates on github:
Verified on QA again. Thanks!
The following files have been updated on STAGE and PROD:
QcReport.py
CDR339576.xml - Module: InLine Markup Formatter
CDR410709.xml - Module: Multimedia Denormalization
Please verify on PROD and close this ticket.
Verified on PROD. Thank you!
| File Name | Posted | User |
|---|---|---|
| non publishable error.JPG | 2018-01-02 17:02:08 | Osei-Poku, William (NIH/NCI) [C] |
Elapsed: 0:00:00.001382