CDR Tickets

Issue Number 4352
Summary [DIS] Alphabetize List of Brand Names in DIS
Created 2017-12-13 15:34:41
Issue Type Improvement
Submitted By Juthe, Robin (NIH/NCI) [E]
Assigned To Englisch, Volker (NIH/NCI) [C]
Status Closed
Resolved 2018-01-24 12:43:46
Resolution Fixed
Path /home/bkline/backups/jira/ocecdr/issue.218340
Description

The list of brand names that appears in drug information summaries on Cancer.gov appears to be in a random sort order. We would like to sort the list alphabetically. We would also like to sort the names such that "nothing" appears before "something" - this is best illustrated with an example:

See https://www.cancer.gov/about-cancer/treatment/drugs/methotrexate

In this DIS, Mexate should appear before Mexate-AQ.

Thanks!

Comment entered 2017-12-14 16:51:26 by Englisch, Volker (NIH/NCI) [C]

had provided the following documents with sorting issues:

I've changed the filter to add sorting to the output of the brand names and it does improve the display but some of the listed documents did not get fixed and I'll have to look into this some more.

Changes are committed for

  • CDR505580.xml: Vendor Filter: DrugInfoSummary [cdr4352-dis-sort 63cd530d]

Comment entered 2018-01-23 20:15:59 by Englisch, Volker (NIH/NCI) [C]

After looking at the output again I suspect that the terms for which the brand names aren't displayed sorted on DEV are somewhat "newish" terms. When I ran a full publishing job from the CDR these newer DIS documents did not get updated because they don't exist yet in the (very old) copy of the CDR on DEV, i.e. Melphalan Hydrochloride.

I will verify this by running a full re-publish job tomorrow on DEV.

Comment entered 2018-01-24 12:43:34 by Englisch, Volker (NIH/NCI) [C]

All DIS documents from DEV have been updated and can be reviewed here:
https://www-blue-dev.cancer.gov/about-cancer/treatment/drugs

I checked a few document for which the sort order had not been corrected and the few that I saw did not get updated with the latest publishing job because they don't exist yet on DEV.

, please review and let me know if you'd like me to promote the filter changes.

Comment entered 2018-01-24 12:50:18 by dblais

Volker, where do you want me to check these? On dev?

Comment entered 2018-01-24 13:00:33 by Englisch, Volker (NIH/NCI) [C]

Yes, on the Cancer.gov development site. Just follow the link I included in my last comment.

Comment entered 2018-01-24 14:12:11 by dblais

OK. I looked at a bunch of these and they look good. But I stumbled on one that's still 'out of order"

https://www-blue-dev.cancer.gov/about-cancer/treatment/drugs/melphalan-hydrochloride

So maybe not totally fixed?

Comment entered 2018-01-24 14:24:31 by Englisch, Volker (NIH/NCI) [C]

So maybe not totally fixed?

No, please look at my explanation in an earlier comment. The data on www-blue-dev.cancer.gov is a copy of the production site. The DIS melphalan hydrochloride exists in production. However, that document doesn't exist in the CDR on DEV because the data on DEV is close to 2 years old. The publishing job on DEV only updated the documents that exist on DEV but not those that only exist on PROD.
Melphalan hydrochloride is CDR778087 and was not part of the list of documents updated this morning.

We should run the publishing test job again on QA since the data there is much more recent but I'm pretty certain the filter changes are fixing our sorting issue.

Comment entered 2018-01-25 08:09:46 by dblais

OK, great. Please go ahead and run it. I'm so glad to have these alphabetized :-)

I apologize for not reading your comments more carefully.

Thanks,
Diana

Comment entered 2018-01-26 12:59:37 by Englisch, Volker (NIH/NCI) [C]

No problem. Even if you had read it, it still may not have made sense.

I ran a publishing job on QA and now it's totally fixed:
https://www-qa.cancer.gov/about-cancer/treatment/drugs/melphalan-hydrochloride

Please have a look and we may be able to push the filter change to PROD before publishing starts later today.

Comment entered 2018-01-31 14:08:52 by Englisch, Volker (NIH/NCI) [C]

are we planning to get this into Friday's publishing job?

Comment entered 2018-01-31 14:33:32 by dblais

I just looked at several of these and they look good! I think we can move forward. Thanks ;-)

Comment entered 2018-02-02 18:06:26 by Englisch, Volker (NIH/NCI) [C]

Unfortunately, it turns out that all the programs for updating filters are currently setup for the Gauss release but the release hasn't landed on PROD yet. This means we're not able to copy the new filter until after Gauss finished.

Comment entered 2018-02-05 09:17:44 by dblais

OK, thanks for the update, Volker. They've beeen 'wrong' for a long time; a few more weeks won't matter...

Comment entered 2018-02-20 11:31:03 by Englisch, Volker (NIH/NCI) [C]

These changes have been part of Gauss.
Please verify on PROD and close this ticket.

Comment entered 2018-02-20 15:11:17 by Englisch, Volker (NIH/NCI) [C]

Changes are committed for

  • CDR505580.xml: Vendor Filter: DrugInfoSummary [master 5fdce61]

Comment entered 2018-02-21 09:24:30 by dblais

I was looking at these on PROD in the CDR but it seems like they're already displaying correctly on cancer.gov?

Comment entered 2018-02-21 10:15:28 by Englisch, Volker (NIH/NCI) [C]

That's correct.

Comment entered 2018-02-21 10:17:47 by dblais

Well the ones I checked look great. Thanks!

Elapsed: 0:00:00.001304