Issue Number | 4352 |
---|---|
Summary | [DIS] Alphabetize List of Brand Names in DIS |
Created | 2017-12-13 15:34:41 |
Issue Type | Improvement |
Submitted By | Juthe, Robin (NIH/NCI) [E] |
Assigned To | Englisch, Volker (NIH/NCI) [C] |
Status | Closed |
Resolved | 2018-01-24 12:43:46 |
Resolution | Fixed |
Path | /home/bkline/backups/jira/ocecdr/issue.218340 |
The list of brand names that appears in drug information summaries on Cancer.gov appears to be in a random sort order. We would like to sort the list alphabetically. We would also like to sort the names such that "nothing" appears before "something" - this is best illustrated with an example:
See https://www.cancer.gov/about-cancer/treatment/drugs/methotrexate
In this DIS, Mexate should appear before Mexate-AQ.
Thanks!
~dblais had provided the following documents with sorting issues:
Methotrexate https://www.cancer.gov/about-cancer/treatment/drugs/methotrexate
Melphalan Hydrochloride https://www.cancer.gov/about-cancer/treatment/drugs/melphalan-hydrochloride
Aminolevulinic Acid https://www.cancer.gov/about-cancer/treatment/drugs/aminolevulinicacid
Azacitadine https://www.cancer.gov/about-cancer/treatment/drugs/azacitidine
Fluorouracil (Topical) https://www.cancer.gov/about-cancer/treatment/drugs/fluorouracil-topical
I've changed the filter to add sorting to the output of the brand names and it does improve the display but some of the listed documents did not get fixed and I'll have to look into this some more.
Changes are committed for
CDR505580.xml: Vendor Filter: DrugInfoSummary [cdr4352-dis-sort 63cd530d]
After looking at the output again I suspect that the terms for which the brand names aren't displayed sorted on DEV are somewhat "newish" terms. When I ran a full publishing job from the CDR these newer DIS documents did not get updated because they don't exist yet in the (very old) copy of the CDR on DEV, i.e. Melphalan Hydrochloride.
I will verify this by running a full re-publish job tomorrow on DEV.
All DIS documents from DEV have been updated and can be reviewed
here:
https://www-blue-dev.cancer.gov/about-cancer/treatment/drugs
I checked a few document for which the sort order had not been corrected and the few that I saw did not get updated with the latest publishing job because they don't exist yet on DEV.
~dblais, please review and let me know if you'd like me to promote the filter changes.
Volker, where do you want me to check these? On dev?
Yes, on the Cancer.gov development site. Just follow the link I included in my last comment.
OK. I looked at a bunch of these and they look good. But I stumbled on one that's still 'out of order"
https://www-blue-dev.cancer.gov/about-cancer/treatment/drugs/melphalan-hydrochloride
So maybe not totally fixed?
So maybe not totally fixed?
No, please look at my explanation in an earlier comment. The data on
www-blue-dev.cancer.gov is a copy of the production site. The DIS
melphalan hydrochloride exists in production. However, that
document doesn't exist in the CDR on DEV because the data on DEV is
close to 2 years old. The publishing job on DEV only updated the
documents that exist on DEV but not those that only exist on PROD.
Melphalan hydrochloride is CDR778087 and was not part of the list of
documents updated this morning.
We should run the publishing test job again on QA since the data there is much more recent but I'm pretty certain the filter changes are fixing our sorting issue.
OK, great. Please go ahead and run it. I'm so glad to have these alphabetized :-)
I apologize for not reading your comments more carefully.
Thanks,
Diana
No problem. Even if you had read it, it still may not have made sense.
I ran a publishing job on QA and now it's totally
fixed:
https://www-qa.cancer.gov/about-cancer/treatment/drugs/melphalan-hydrochloride
Please have a look and we may be able to push the filter change to PROD before publishing starts later today.
~dblais are we planning to get this into Friday's publishing job?
I just looked at several of these and they look good! I think we can move forward. Thanks ;-)
Unfortunately, it turns out that all the programs for updating filters are currently setup for the Gauss release but the release hasn't landed on PROD yet. This means we're not able to copy the new filter until after Gauss finished.
OK, thanks for the update, Volker. They've beeen 'wrong' for a long time; a few more weeks won't matter...
These changes have been part of Gauss.
Please verify on PROD and close this ticket.
Changes are committed for
CDR505580.xml: Vendor Filter: DrugInfoSummary [master 5fdce61]
I was looking at these on PROD in the CDR but it seems like they're already displaying correctly on cancer.gov?
That's correct.
Well the ones I checked look great. Thanks!
Elapsed: 0:00:00.001304