CDR Tickets

Issue Number 4349
Summary [Glossary] English Dictionary Terms without Spanish Translation
Created 2017-12-13 09:49:55
Issue Type Improvement
Submitted By Osei-Poku, William (NIH/NCI) [C]
Assigned To Englisch, Volker (NIH/NCI) [C]
Status Closed
Resolved 2021-04-29 14:19:02
Resolution Won't Fix
Path /home/bkline/backups/jira/ocecdr/issue.218260
Description

Linda has brought to our attention display problems in the Spanish dictionary. We have discussed at least part of the problem before but no decision was made at that point because it affected just about two or three terms. However, over the years many more terms have been created that are also having the same display problems. Please see attached list of affected terms.
Terms like "biometry" (See attached screenshot) which are usually also calleds have no Spanish Translations. However, they are given a dictionary entry in Spanish with (en ingles) in parenthesis. They also display in the dictionary definition the same way. These are terms without the Spanish Translation blocks so essentially should not have entries in the Spanish dictionary. Please look into the possibilities of blocking these terms from displaying as entries in the Spanish dictionary.

Comment entered 2018-02-16 07:34:40 by Kline, Bob (NIH/NCI) [C]

: please assign story points for this ticket.

Comment entered 2018-03-14 15:59:06 by Englisch, Volker (NIH/NCI) [C]

I probably don't understand the problem. Here is a comment from the GlossaryTerm filter:

If a translated name exists, process it. If a translated name does not exist, it's because a translation for the word does not exist in the translated language and we're using the English word with the note "en englais".
However, we only want to do this if a translated concept definition exists for this term.

This is telling me: "If we have a Spanish translation we want to display it."

Your example biometry can simply be resolved by removing the Spanish translation from the GTC document which I have done on DEV.

Comment entered 2018-03-14 16:04:03 by Englisch, Volker (NIH/NCI) [C]

, how would I identify an "also-called" term?

Comment entered 2018-03-14 18:34:21 by Osei-Poku, William (NIH/NCI) [C]

They are terms that share the same definition and would be listed at the end of the definition starting with "Also called..." If you look at the definition for this term CDR0000046472 you will get a better idea.

Comment entered 2018-03-15 13:05:58 by Englisch, Volker (NIH/NCI) [C]

, this is another ticket that has a WCMS dependency but I'm not clear yet about the full extend of this dependency.
At a minimum, it needs to be discussed how the "English/Spanish" toggle on Cancer.gov would need to be modified to ensure those terms without a Spanish translation wouldn't display the language toggle. This change is outside of a simple XSLT filter change.

Comment entered 2018-03-20 17:26:36 by Englisch, Volker (NIH/NCI) [C]

, I'm putting this ticket back to the Open pile and out of the Hawking release since it needs to be coordinated with a WCMS release.

Comment entered 2018-03-22 08:44:15 by Dugan, Amy (NIH/NCI) [C]

Thanks, !

Comment entered 2020-07-16 20:23:45 by Englisch, Volker (NIH/NCI) [C]

I submitted a ticket to remove the language toggle if a translation does not exist:

https://github.com/NCIOCPL/glossary-app/issues/195

Comment entered 2021-03-08 13:51:15 by Osei-Poku, William (NIH/NCI) [C]

Currently there is only one dictionary term (PI) that meets the issue reported in this ticket. All the other terms have had Spanish translations added recently. It may still be worth it to implement the solution to the issue but I just wanted to add that it is probably not as urgent as it used to be.

Comment entered 2021-04-29 14:19:02 by Kline, Bob (NIH/NCI) [C]

Decided it wasn't worth doing anything about a single instance of this problem.

Comment entered 2021-05-05 12:50:35 by Englisch, Volker (NIH/NCI) [C]

I've added a comment to the git ticket indicating that the CDR ticket has been closed.

Attachments
File Name Posted User
Biometry.JPG 2017-12-13 09:48:42 Osei-Poku, William (NIH/NCI) [C]
ENGLISH TERMS DISPLAYING ON DICCIONARIO DE CÁNCER.docx 2017-12-13 09:49:41 Osei-Poku, William (NIH/NCI) [C]

Elapsed: 0:00:00.001309