| Issue Number | 4293 |
|---|---|
| Summary | Display PerDoctypeErrorThreshold Job Options |
| Created | 2017-07-28 12:47:03 |
| Issue Type | Improvement |
| Submitted By | Englisch, Volker (NIH/NCI) [C] |
| Assigned To | Kline, Bob (NIH/NCI) [C] |
| Status | Closed |
| Resolved | 2018-04-10 17:45:00 |
| Resolution | Fixed |
| Path | /home/bkline/backups/jira/ocecdr/issue.212125 |
We have no easy way to display and/or modify the new element PerDoctypeErrorThreshold option causing publishing failures on the lower tiers.
We need to be able to display or modify these options as part of the Job Options when submitting a publishing job on the lower tiers.
We have a number of ways to tackle this. We've only got one document
type left standing (Summary) which uses a per-doctype error threshold.
So we could move the information from the
PerDoctypeErrorThreshold block into a
SubsetParameter with ParmName of
MaxSummaryErrors. If we ever had another document type which
needed such treatment, then we'd have a parameter like
MaxKumquatErrors. Or we could create a new table along the
lines of
CREATE TABLE per_doctype_error_threshold_override
(pub_proc INTEGER NOT NULL FOREIGN KEY ...,
doc_type INTEGER NOT NULL FOREIGN KEY ...,
threshold INTEGER NOT NULL)
PRIMARY KEY (pub_proc, doc_type)(or maybe a string for the doc_type column), and we'd
modify the publishing.Job class to accept more information
in the constructors, and modify the cdr.publish() function,
as well as the CGI web admin interface which calls that function.
What's your preference?
It seems the second option is a little overkill. I was thinking about option 1 when I created the ticket. All I wanted was a way to see and/or update the value if necessary.
Is that vague enough? :-)
Which option do you think is easier to implement?
Which option do you think is easier to implement?
The first one.
Then we agree: Option 1 is the winner.
I thought option 1 to be easier to implement but today you finished a gazillion tickets I can't even keep up with the emails for the tickets.
No worries. This one will slow me down. :-)
~volker: You've got the Primary publishing control document checked out.
On DEV I'm guessing?
It's unlocked now.
Installed on DEV. Please test, ~volker.
https://github.com/NCIOCPL/cdr-publishing/commit/653cfb0
https://github.com/NCIOCPL/cdr-lib/commit/7f75f19
When I'm trying to start an Export publishing job I'm getting an error message:
invalid 'MaxSummaryErrors' value '0'This is happening for both, DEV and QA.
I believe this is fixed on DEV. Please try again, and if it works, I'll check it in and copy the fixed publishing control document to QA.
Yes, it works now on DEV.
Correct validation specification installed on QA.
... and it works on QA.
This option is now available on PROD. Closing ticket.
Elapsed: 0:00:00.001327