| Issue Number | 4296 |
|---|---|
| Summary | [Summaries] Modify Display of Images in QC Reports |
| Created | 2017-08-03 12:57:55 |
| Issue Type | Improvement |
| Submitted By | Juthe, Robin (NIH/NCI) [E] |
| Assigned To | Englisch, Volker (NIH/NCI) [C] |
| Status | Closed |
| Resolved | 2017-08-08 15:27:16 |
| Resolution | Fixed |
| Path | /home/bkline/backups/jira/ocecdr/issue.212407 |
Images are now right-justified with the title of the image right-justified beneath them and a blue box to the left of and below the image. Could this be modified so that the image and image title are centered without a blue box?
I'm looking at this ticket and I had expected a different change.
You are asking to eliminate the blue box. In that case how would you like to have the no-image version of the QC report displayed? The difference between the "Display image" and "Don't display image" version is to include the image inside the blue box and the box is acting as a placeholder.
As for the display of the image title and the image having those
centered is no problem.
Would you want the title displayed above or below the image?
Don't answer the "blue box" comment yet. I think I should look at the filter first since the boxes are handled slightly differently this change may be easier than I thought.
The following filters have been updated to display the images and image title centered without a blue box:
CDR339576: Module: InLine Markup Formatter
CDR380958: Module: STYLE QC Summary
Please review on DEV.
Some of the CSS for the module display changes are included in the filter change.
This looks good on DEV.
Which CSS module display changes are included? Are you referring to the changes for OCECDR-4276, which is now in Hawking? I didn't see any differences between the module text and the rest of the summary text in the B/U and RLSO QC reports, so maybe those were backed out. Or I'm not understanding what I should be looking for!
Stored in git under [cdr4296 5fdb5026]
CDR339576: Module: InLine Markup Formatter
CDR380958: Module: STYLE QC Summary
There are some CSS rules included in the filter changes which relate to the module display discussed in OCECDR-4276 but none of these changes are applied.
For the moment you can ignore that comment.
~juther, I have restored
the filter changes to display the images and image title centered
without a blue background.
This is on DEV (Yes, I said DEV) for you to review.
I'm not seeing this on DEV... the image box still has a blue background and both the image and its title are right justified.
I hope it didn't get overwritten by a hawking update. Let me check.
Sure did. The changes were overwritten on DEV. I have restored them
for now.
Please check again - but you have to be quick. :-)
Ah, much better. This looks good on DEV. Thanks.
I've moved the changes to QA and - because the modifications were fairly minor - to STAGE and PROD.
Please verify on PROD and close this ticket.
Verified on PROD. Thank you!
Elapsed: 0:00:00.001393