CDR Tickets

Issue Number 4243
Summary Modify XML used for world server translation
Created 2017-03-20 13:06:18
Issue Type Improvement
Submitted By Osei-Poku, William (NIH/NCI) [C]
Assigned To Kline, Bob (NIH/NCI) [C]
Status Closed
Resolved 2018-03-26 10:23:28
Resolution Fixed
Path /home/bkline/backups/jira/ocecdr/issue.205074
Description

Please modify the XML document that is downloaded and used for translation in world server; remove the following elements from the XML.

1. Related Documents
2. Type of Summary Change

3. Changes to this Summary *

*This is not an element. It is stored in a title element but It is also not translated. If possible, please exclude from the XML file as well.

Here is here a link to the interface for reference.

https://cdr.cancer.gov/cgi-bin/cdr/get-english-summary.py

Comment entered 2018-02-16 07:19:36 by Kline, Bob (NIH/NCI) [C]

I may need clarification on the idea that "Changes to this Summary" is stored in a title element. Not sure what that means.

Comment entered 2018-03-08 13:47:06 by Juthe, Robin (NIH/NCI) [E]

Need to clarify whether the Changes to This Summary section should really be removed since this section does get translated.

If it should indeed be removed, please note that this text exists in a summary section title element and should be used to identify which section to delete.

Comment entered 2018-03-13 06:47:57 by Kline, Bob (NIH/NCI) [C]

Waiting for feedback from on the Changes To This Summary section.

Comment entered 2018-03-14 11:04:11 by Osei-Poku, William (NIH/NCI) [C]

The request for the Changes To This Summary section remains. According to the Spanish team, while the changes section is translated for summaries that are being updated regularly, only new and comprehensively revised summaries go through the WS process and the wording in the Changes To This Summary section for these summaries is very short (one sentence) for such summaries and does not need to go through WS translation.

Comment entered 2018-03-14 13:09:29 by Kline, Bob (NIH/NCI) [C]

I just looked at the code and it appears that it's already removing SummarySection blocks whose section type is "Changes to summary" – is that not the same thing as what you're referring to above as "Changes To This Summary"?

Comment entered 2018-03-14 13:14:02 by Osei-Poku, William (NIH/NCI) [C]

Yes, it is the same thing. In that case, please ignore this part of the request.

Comment entered 2018-03-14 13:32:12 by Kline, Bob (NIH/NCI) [C]

Enhancements installed on DEV.

https://github.com/NCIOCPL/cdr-admin/commit/50438388

Comment entered 2018-03-21 11:43:25 by Osei-Poku, William (NIH/NCI) [C]

Could you please also remove the PMID and Comprehensive Review elements as well?

Comment entered 2018-03-26 10:23:28 by Kline, Bob (NIH/NCI) [C]

Changed requirements implemented on DEV.

https://github.com/NCIOCPL/cdr-admin/commit/5188b473

Comment entered 2018-03-27 16:42:21 by Osei-Poku, William (NIH/NCI) [C]

Verified on DEV. Thanks!

Comment entered 2018-04-11 10:43:46 by Osei-Poku, William (NIH/NCI) [C]

Verified on DEV.

Comment entered 2018-05-10 13:07:31 by Osei-Poku, William (NIH/NCI) [C]

Verified on PROD. Thanks!

Elapsed: 0:00:00.001367