CDR Tickets

Implemented on DEV. I kept the shadowed background for the count cells the user asked to be excluded in the Summaries with Markup report, even though we're moving toward white backgrounds for all of the report table cells. What's your preference here? If was going on the theory that there were two separate incentives for abandoning the non-white cell backgrounds:

1. makes the cell data harder to read

2. uses up ink when the reports are printed

I don't know if these reports are printed, and even if they are, I think it might be possible (at least with some browsers) to suppress the printing of the shadowed background. Easy to do whichever way you prefer.

I think the way you have it with light shading looks good.

Could you please replace "Any Board" with "All Boards" on the interface for these three reports? Thanks.

The Summaries Cleanup Report doesn't seem to be working properly. I'm not getting any results and there's quite a long list of results on PROD... I added a few empty tags to CDR299612 just in case there really weren't any cleanup data to report (unlikely), but I'm still not getting any results.

"Any Board" has been replaced with "All Boards" on all three reports. I'm seeing results for the Summaries Cleanup Report, but I have to confess I don't completely understand the requirements here – I was just replicating the functionality I saw the original code doing. I may give you a call to talk about this one. On the other hand, I'm a little puzzled by the protocol links report, in that I see results for the other boards but not for Genetics. Can your board really not be referencing clinical trials in its summaries?

I fixed a bug (the code that was looking to see if a section node had any children wasn't skipping over non-elements like processing instructions or XML comments), so you test is showing up now.

Here the logic used to decide what to show:

FOR EACH SUMMARY SECTION:
  IF THERE ARE NO CHILD ELEMENTS:
    REPORT THIS SECTION AS EMPTY
    SHOW THE NEXT SECTION (OR INDICATE THAT THIS WAS THE LAST SECTION)
  OTHERWISE, IF THE FIRST CHILD IS A TITLE ELEMENT:
    IF THERE ARE NO NORMAL CONTENT CHILDREN:
      IF NONE OF THE ANCESTORS OF THIS ELEMENT IS AN INSERTION ELEMENT:
        SHOW THE TITLE OF THIS SECTION, AS WELL AS THE TAGS OF THE CHILDREN

~oseipokuw, could you please review the Summaries Cleanup and Summaries With Protocol Links/Refs reports since those are typically used by CIAT? The Board managers are reviewing the Summaries With Markup report. Thanks.

Yes, we will review all the reports. Thanks!

There appears to be a problem with the Summaries with Protocol Links/Refs report. When you run the report for some individual summaries (62855, 62786) for example, it does not retrieve anything even though there are protocols refs in the summaries and you select the option to see all protocols refs and not just the ones with changed statuses. Also, selecting Cancer Genetics Board and leaving all the options on the default selections produces not results.

Also, selecting the PEDS Board while leaving all other options on default appears to retrieve only a limited number of summaries.

Fixed on DEV. Please verify that it's working properly now. (Just as a reminder, the Revision Markup filter is applied before parsing the document, so some links you see in the CWD won't necessarily show up on the report).

Fixed on DEV. Please verify that it's working properly now.

Verified on DEV. Seems to be working well on DEV.

On QA - When you click on the Summaries Markup Report, it says "Summary Section Cleanup Report" at the top of the page (even though it functions as the Summaries Markup Report).

Fixed on DEV.

Verified on DEV - thanks!

I've verified the Summaries with Markup report on QA - looks good. ~oseipokuw, can you please check the other reports on QA and move this to QA verified if they look OK? Thanks.

Verified on QA.

Verified on PROD.