CDR Tickets

Schema change installed on DEV and global change implemented and run on test mode; please review:

https://cdr-dev.cancer.gov/cgi-bin/cdr/ShowGlobalChangeTestResults.py?dir=2016-03-24_22-21-17

Volker needed the new values in order to proceed with his filter change work, so I went ahead with the live job on DEV without waiting for user review of the test mode results.

Verified the schema change and global on DEV.

Verified on QA.

Sorry, spoke too soon...

Robin B. said a couple of these should NOT be updated to IACT. About CAM and Questions about CAM will remain as is. For clarity, we would like to add "IACT" before patient summary in each of these. Here are the specific changes:

1. Please change "About IACT - Patient summary" to "About CAM - IACT patient summary".
2. Please change "Questions about IACT - Patient summary" to "Questions about CAM - IACT patient summary".

Reopening this issue; we'll plan to take another look in IT-2. Thanks!

The global change script has been rewritten and run on DEV in live mode. The new version, in addition to changing the old values to the new ones, also fixes the ones that were set to the wrong new values following the original request.

Note that there are no documents on any tier with the value Questions about CAM - [IACT] Patient summary (though there are documents with the value "Questions to Ask Your Health Care Provider About CAM").

Apparently the "Questions to Ask Your Health Care Provider About CAM" was given the same type "About CAM - [IACT] Patient Summary" on PROD when it really should have the type "Questions about CAM - [IACT] patient summary". (I just confirmed this with Robin B.) I made this substitution on DEV, but will that break anything? I know there's a related ticket (OCECDR-4068) that has to do with filter changes related to these misc docs, but I don't think that one has been started yet.

Has this updated global been run on QA? I'm still seeing the old value - "About IACT - Patient summary" - in CDR0000445621 and CDR0000445622 and they don't appear to have been checked out at the time.

No, the global change hadn't been run a second time. I just ran it again. Please give it another look.

Looks good. Verified on QA.

Hi Bob,

Have these globals been run on PROD? I'm still seeing the old types.

Thanks,
Robin

Here's the log for OCECDR-4047 on PROD:

!3656 Thu May 12 18:36:00 2016: running in live mode
2016-05-12 18:36:00: Running in real mode.  Updating the database
2016-05-12 18:36:00: 3 documents selected
  Purpose: Change CAM misc doc type names (OCECDR-4047)
2016-05-12 18:36:01: Processing CDR0000256925 [pub:13/last:14/cwd:14]
2016-05-12 18:36:03: saveDoc(256925, ver='Y' pub='Y' val='Y' new pub)
2016-05-12 18:36:03: saveDoc(256925, ver='Y' pub='N' val='Y' new ver)
2016-05-12 18:36:04: Processing CDR0000445623 [pub:22/last:22/cwd:22]
2016-05-12 18:36:06: saveDoc(445623, ver='Y' pub='N' val='N' old cwd)
2016-05-12 18:36:06: saveDoc(445623, ver='Y' pub='Y' val='Y' new pub)
2016-05-12 18:36:07: Processing CDR0000446984 [pub:5/last:7/cwd:7]
2016-05-12 18:36:09: saveDoc(446984, ver='Y' pub='Y' val='Y' new pub)
2016-05-12 18:36:09: saveDoc(446984, ver='Y' pub='N' val='Y' new ver)
2016-05-12 18:36:10: Run completed.
   Docs examined    = 3
   Docs changed     = 3
   Versions changed = 8
   Could not lock   = 0
   Errors           = 0
   Time (hh:mm:ss)  = 00:00:10
 Specific versions saved:
   new pub = 3
   new ver = 2
   old cwd = 1

Here's the MiscellaneousDocumentType (for example) for CDR256925:

It looks like some values were updated and others were not. I'm still seeing "About CAM - Patient summary" in several docs - for example, CDR445621, CDR445622, CDR446985.

Ah, yes. I see that in the process of trying to handle the multiple conditions (documents which had been processed before the requirements were changed and those which had not) I broke some of the logic. I think it's fixed now and I've run it again. Here's the log from the second run:

2016-05-13 16:21:59: Running in real mode.  Updating the database
2016-05-13 16:21:59: 6 documents selected
  Purpose: Change CAM misc doc type names (OCECDR-4047)
2016-05-13 16:22:01: Processing CDR0000445621 [pub:9/last:9/cwd:9]
2016-05-13 16:22:02: saveDoc(445621, ver='Y' pub='N' val='N' old cwd)
2016-05-13 16:22:03: saveDoc(445621, ver='Y' pub='Y' val='Y' new pub)
2016-05-13 16:22:04: Processing CDR0000445622 [pub:1/last:1/cwd:1]
2016-05-13 16:22:06: saveDoc(445622, ver='Y' pub='N' val='N' old cwd)
2016-05-13 16:22:06: saveDoc(445622, ver='Y' pub='Y' val='Y' new pub)
2016-05-13 16:22:07: Processing CDR0000446985 [pub:3/last:3/cwd:3]
2016-05-13 16:22:08: saveDoc(446985, ver='Y' pub='Y' val='Y' new pub)
2016-05-13 16:22:09: Processing CDR0000446986 [pub:3/last:3/cwd:3]
2016-05-13 16:22:11: saveDoc(446986, ver='Y' pub='Y' val='Y' new pub)
2016-05-13 16:22:12: Processing CDR0000766007 (BLOCKED) [/last:5/cwd:5]
2016-05-13 16:22:13: saveDoc(766007, ver='Y' pub='N' val='Y' new ver)
2016-05-13 16:22:14: Processing CDR0000766008 (BLOCKED) [/last:5/cwd:5]
2016-05-13 16:22:15: saveDoc(766008, ver='Y' pub='N' val='Y' new ver)
2016-05-13 16:22:16: Run completed.
   Docs examined    = 6
   Docs changed     = 6
   Versions changed = 12
   Could not lock   = 0
   Errors           = 0
   Time (hh:mm:ss)  = 00:00:16
 Specific versions saved:
   new pub = 4
   new ver = 2
   old cwd = 2

Can you check and see if all is well now?

Yes, that looks good now. Thanks!

Verified on PROD. Manual updates in progress.