CDR Tickets

Issue Number 4046
Summary [Summaries] Links Within Modules Showing Page Not Found Error
Created 2016-03-18 16:07:16
Issue Type Bug
Submitted By Juthe, Robin (NIH/NCI) [E]
Assigned To Englisch, Volker (NIH/NCI) [C]
Status Closed
Resolved 2017-03-17 14:28:07
Resolution Fixed
Path /home/bkline/backups/jira/ocecdr/issue.181078
Description

Within a summary module with the flag ModuleOnly=YES, a link that has a destination that is also within the same summary module works on QC reports, but does not work on Cancer.gov. Is this working as expected, or is this a bug?

Example: Peutz-Jeghers Syndrome (CDR738176)

This module is included in the Genetics of Colorectal Cancer summary and contains a link to Table 14, which is also within that module. Clicking on the link to the table on Cancer.gov brings up a Page Not Found error.

Comment entered 2016-03-21 09:17:20 by Kline, Bob (NIH/NCI) [C]

I suspect the problem has something to do with the fact that, even thought the P-J summary is marked as "module only" it has a SummaryUrl, which we're passing to Cancer.gov. Easy to see why they thought that was the URL to use for the link. Adding Volker in case he has any additional insights.

Comment entered 2016-03-21 17:13:00 by Englisch, Volker (NIH/NCI) [C]

Yes, that's correct. The WCMS team requested to receive the URL for a summary as an attribute so that Gatekeeper won't have to query Percussion for this information. When I updated the filter accordingly I did not take into account the module issue.
I guess we'll have to insert the URL of the parent summary whenever the href attribute of the SummaryRef element contains the string sm (summary module).

Comment entered 2017-02-01 18:01:45 by Englisch, Volker (NIH/NCI) [C]

I've made some changes in the vendor filter to solve this problem of a link inside a module to itself failing:

  • CDR000157: Vendor Filter: Summary

The best way to test this would probably be to publish a document rather than using PP and we want to test many linking options:

  • linking from parent document to module section

  • linking from module section to itself

  • linking from module section to parent document

  • linking from parent document to another summary (not a module section)

  • linking from module section to another summary (not a module section)

  • linking from parent document to another summary (module section - should this work?)

  • linking from module section to another summary (module section - should this work?)

  • linking from one module section to a second module section within the same parent document

Did I miss anything?

Comment entered 2017-03-09 15:23:20 by Englisch, Volker (NIH/NCI) [C]

Once Einstein made it to PROD and these changes have been reviewed and tested we should be able to move this modified filter to PROD as well.

Comment entered 2017-03-16 18:02:11 by Englisch, Volker (NIH/NCI) [C]

I don't know how this happened other than that I must have worked in the wrong branch. This filter was supposed to be updated as a release-independent change, however, looking at the content in trunk it seems the changes made it to PROD. Yikes!!!

We can either test the changes on PROD tomorrow as good as we can or undo the changes and update the changed filter on PROD before the publishing job starts.

Comment entered 2017-03-16 18:12:48 by Kline, Bob (NIH/NCI) [C]

This was checked into Einstein on Feb 2 as r14574.

Comment entered 2017-06-14 14:55:02 by Englisch, Volker (NIH/NCI) [C]

/: Since this filter change is on PROD I was wondering if we can close the ticket.

Comment entered 2017-08-04 11:39:41 by Juthe, Robin (NIH/NCI) [E]

Verified on PROD.

Elapsed: 0:00:00.001605